Open file in EDITOR

[037g]

Hi,

Thank you so much for making this.

Previously, I could use CTRL-O and it would let me open a file in the system editor. This does not seem to be available anymore. Can you please help direct me to the best way to accomplish this?

When I add this bind --mode insert \co '__fzf_open --editor' in my conf.d/fzf.fish
I get: fish: Unknown command: __fzf_open

Thank You

[PatrickF1]

I didn't implement that. The closest thing is to use type vim or whatever you use and then hit Ctrl+F. I'm not going to implement a tool just for opening files because I want the commands to be composable. Sorry about that.

[kidonng]

@PatrickF1 Not sure if you are interested, do you think it is favorable to output everything to stdout when executing a command substitution?

Currently all functions insert the output into the command line, which is fine for interactive usage, but not very interpolatable.

We can rewrite everything into something like:

if status is-command-substitution
    printf $output
else
    commandline --current-token --replace $output
end

That way people can reuse existing functions to achieve more niche usage, for example this feature request can become $EDITOR (__fzf_search_current_dir).

[PatrickF1]

All of the stuff scanning current token and doing stuff with it would be irrelevant. Maybe I'm making too big of a deal out of it

[ovv]

I think we could split the functions in two:

1. A base you can use in substitution (taking a token as optional parameter)
2. A wrapper of 1, that deals with what's necessary to make it run with a key binding and fetch the token

[PatrickF1]

Yeah that's what I'm thinking too. Gonna take a lot of work though!

[ovv]

my 0,02$, we might want to go ahead with #110 in the meantime.

Personally I would love to do something like abbr -a ga 'git add (__fzf_search_git_status)'

[tommyknows]

Is there a solution for doing bind [key] vim (_fzf_search_current_dir)? Not quite sure what changed in the meantime, but I'd definitely also be interested in such a feature :-)

[PatrickF1]

Hi all, opening a file in editor is now very possible with a bit of work. With the merging of #140, it is now possible to configure a key binding to open the current line in vim. This has a working example: junegunn/fzf#1360. Just combine it with fzf_dir_opts.

[kidonng]

I hope this doesn't mean you will ditch #110 because it's from a different aspect.

[PatrickF1]

No I even have an idea of how to make it work but it's not high on my priority list currently. I will open a new discussion to track this idea.
EDIT: here is the new conversation. please direct your comments there #144

[notDavid]

Hi there, thank you for making this!

I’m trying to get this to work, but i’m not sure what i’m doing wrong… here’s what i did:

set --export fzf_dir_opts '--bind \"ctrl-v:execute(vim {} < /dev/tty)\"'

However, when attempting to start fzf.fish with Ctrl+Alt+F i get this error:

unknown option: --bind \"ctrl-v:execute (vim {7 < /dev/tty)\"

Could you please advise? thank you!

fish, version 3.3.1
fzf 0.28.0 (brew)

PS.
executing fzf --bind 'ctrl-v:execute(vim {} < /dev/tty)' on the commandline without using fzf.fish does work fine.

[PatrickF1]

Hi David, can you see if the discussion here helps? #203

[notDavid]

Hi Patrick, thank you for your reply! I’m not sure how to translate this solution into my situation. I tried this, and the problem remains the same:

set --export fzf_dir_opts '--bind "ctrl-v:execute(vim {} &> /dev/tty)”'

However, executing set v (ls | fzf --bind "ctrl-v:execute(vim {} &> /dev/tty)") directly in the fish shell without using fzf.fish works fine.

Is what i did correct, or is the value i’m setting fzf_dir_opts to wrong?

[PatrickF1]

how about set --export fzf_dir_opts --bind "ctrl-v:execute(vim {} &> /dev/tty)
basically remove the single quotes wrapping the whole thing

[notDavid]

Thank you so much @PatrickF1, this works! 👌🏼

set --export fzf_dir_opts --bind "ctrl-v:execute(vim {} &> /dev/tty)"