Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support videojs-contrib-quality-levels #38

Open
stevendesu opened this issue Apr 16, 2019 · 1 comment
Open

Does not support videojs-contrib-quality-levels #38

stevendesu opened this issue Apr 16, 2019 · 1 comment

Comments

@stevendesu
Copy link

I just made the switch from @videojs/http-streaming to videojs-contrib-hls.js to try and fix playback of several different videos that were not working properly in @videojs/http-streaming. However my player has a quality selector button which displays the various renditions available (1080p, 720p, 540p, etc) - and his button stopped functioning with HLS.js

If HLS.js provides events for the detection of new renditions or hooks for determining which rendition is currently playing or limiting which renditions are allowed, then adding support for videojs-contrib-quality-levels shouldn't be impossible. If HLS.js does not provide this and instead black-boxes all of the playback details, then a pull request on HLS.js may be necessary.

@mbc-audiovisuales
Copy link

Checked with Novage p2p-media-loader-hlsjs demo.

Adding videojs-hls-quality-selector dependency breaks p2p-media-loader P2P nature, letting quality selector to come to scene.

Seems not compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants