Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the wildcard field to the ElasticDsl #2236

Closed
alexwlchan opened this issue Oct 26, 2020 · 3 comments
Closed

Add the wildcard field to the ElasticDsl #2236

alexwlchan opened this issue Oct 26, 2020 · 3 comments
Labels

Comments

@alexwlchan
Copy link
Contributor

alexwlchan commented Oct 26, 2020

We use the ElasticDsl to define our index mappings, e.g.

import com.sksamuel.elastic4s.ElasticDsl._

val fields: Seq[FieldDefinition] =
  Seq(
    keywordField("name"),
    keywordField("place")
  )

It would be useful if we could define wildcard fields using the DSL. I can see some support was merged in wellcomecollection/platform#2217, but there's no DSL support.

I think this would involve:

Currently I'm inlining a FieldDefinition for wildcard, but it would be nice to have this in the core library. I quickly discovered this doesn't work unless I want to vendor way more stuff.

I could write a patch if you're interested and have time to review.

(Part of wellcomecollection/platform#4859, wellcomecollection/storage-service#1028)

@sksamuel
Copy link
Collaborator

Patch would be great.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@alexwlchan
Copy link
Contributor Author

I haven't had a chance to use this yet, but I believe this was finished in wellcomecollection/platform#2237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants