Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Database support #37

Open
pehala opened this issue Aug 26, 2020 · 5 comments
Open

Implement Database support #37

pehala opened this issue Aug 26, 2020 · 5 comments

Comments

@pehala
Copy link
Collaborator

pehala commented Aug 26, 2020

We could reintroduce MongoDB support that is mostly commented out.

@pehala
Copy link
Collaborator Author

pehala commented Sep 4, 2020

I was thinking about this and I propose this:

  • We leave tracks in the separate folder
  • We only save ratings and best scores

Another thing I was thinking about was if we have any reason to use only Mongo or any database will do just fine. We could use ORM and be database agnostic.

@PhilippvK
Copy link
Owner

I do not really have any opinion on this. How would you like handle credentials for a public highscore server? Or should the database be running on the same host as the server, for example inside a docker container?

If you want to implement something, feel free to do so.

@pehala
Copy link
Collaborator Author

pehala commented Sep 4, 2020

I don't really have users figured out yet, so for this the users would as they are now, basically just unprotected nickname. So all the data would be bound to a string instead of a User object.

I suspect the DB would be separate for each server. Also to not be depending on external database, if user does not specify any database for server, we can use some file based dB like H2 or SQLite. Meaning user can still just start server and it will.work.

@pehala pehala changed the title Fix MongoDB integration Implement Database support Nov 2, 2020
@pehala
Copy link
Collaborator Author

pehala commented Nov 2, 2020

@PhilippvK I have experimented a bit with this feature and it turns out adding database support is not very lightweight and will add at least 10Mb to a size of the server. Are we in any way concerned about binary size here?

@PhilippvK
Copy link
Owner

No, I do not have anything against that increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants