-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments: Add button / icon to open the original post in a new tab #240
Comments
This looks great! Should also check if this works well on mobile. Popup dialogs like this tend to be difficult to use on mobile devices. |
I was looking into the code today. |
The dialog element and showModal method are newer elements, but they’re available in all major browsers. I’m unclear why you think this will be an issue with React. I actually did make a version with I think a way to clear the localStorage would be nice, but was unclear where we’d like to expose controls for that. Maybe we could just store it as a cookie with a short expiration date. Otherwise, asking the user to clear it manually isn’t that complicated: |
Hi @nathangathright ,
I thought about adding an extra item in the menu, like "forget my account home instance" or something like that.
Take into account I'm writing as someone that learns React on demand (i.e. the minimum I need to contribute). You typically don't give commands like Thanks for clearing out the drawback on using |
Regarding the remote interact (i.e. follow, reply, etc...), the patterns Here are some references:
@nathangathright , if you have any good references for this, please share. |
…y and other actions This commit implements Podcastindex-org#240 and initial support for Podcastindex-org#233. A menu is added to comments that support initiating the following actions: - Reply to post - currently just navigates to the post in it is original system - Copy link to post - Open in original site - opens the post in its original system at another tab - Follow author of the post - currently just navigates to the profile of the author on its original system This commit is based on nathangathright/comment-thread-mockup@6b2f716 Related issues: - Podcastindex-org#240 - Podcastindex-org#233 Co-authored-by: Nathan Gathright <[email protected]>
I did some more tests with the WebFinger protocol to get the remote interact URL pattern. As far as I can tell, the remote interact URL pattern does not change from user to user, yet we will need to pass a user to get it. We'll have to prompt for the account of the user initiating the interaction then, not only the instance host. ExampleI want to I need to send the request {
"subject": "acct:[email protected]",
"aliases": [
"https://fosstodon.org/@dellagustin",
"https://fosstodon.org/users/dellagustin"
],
"links": [
{
"rel": "http://webfinger.net/rel/profile-page",
"type": "text/html",
"href": "https://fosstodon.org/@dellagustin"
},
{
"rel": "self",
"type": "application/activity+json",
"href": "https://fosstodon.org/users/dellagustin"
},
{
"rel": "http://ostatus.org/schema/1.0/subscribe",
"template": "https://fosstodon.org/authorize_interaction?uri={uri}"
}
]
} I'll get the |
This commit implements one next step to automate the remote interactions with comments and commenters. This uses the WebFinger protocol and API and also the OStatus Subscribe mechanism. There are very little guardrails, so some might need to be implemented later (e.g. verifying the input for the interactor account). Known issues: When the user is first prompted to enter their account, the opening of a new tab for interaction will be blocked as a pop-up. Related issues: - Podcastindex-org#233 - Podcastindex-org#240 Related links: - https://socialhub.activitypub.rocks/t/represent-endpoint-for-remote-interaction/480
Implemented with #253. |
Currently the only way to comment on the podcasts in the podcast index is to copy the link of the post and use it to find it in the instance where the user has and account.
The only way to get the original post link, currently, is to copy it from the timestamp. Having a link to the post/comment is a comment UX practice, but it is kind of a hidden feature, as it is not that intuitive.
I suggest that we add a more clear indication on how to open the original post or copy the post link.
A common icon for opening a link in another domain is like the one shown in the screenshot below:
Related issues
Links and References
The text was updated successfully, but these errors were encountered: