[BUG] Crashes on joining world with Fabric/Forge + Offline account

[khanhduytran0]

Describe the bug

We have got a lot of reports about getting crash while joining world with Forge + offline account recently (see #2668, #2669, #2674):

• Shutting down internal server might displays before crash.
• java.lang.IllegalArgumentException: Name and ID cannot both be blank is found in the latestlog.txt and the crash report.
• Game exited with code 1(?)

The log file and images/videos

latestlog.txt
Tested version: 1.16.5 Forge 36.2.26
Highlighted point:

java.lang.IllegalArgumentException: Name and ID cannot both be blank
	at com.mojang.authlib.GameProfile.<init>(GameProfile.java:26)
	at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillGameProfile(YggdrasilMinecraftSessionService.java:192)
	at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillProfileProperties(YggdrasilMinecraftSessionService.java:179)
	at net.minecraft.client.Minecraft.loadWorld(Minecraft.java:1799)

As the stack trace says, it seems that the authentication server returned an empty profile when an invalid access token is sent to the server. In this case, offline account doesn’t hold a valid access token.

Steps To Reproduce

1. Open PojavLauncher
2. Install Forge (any versions?)
3. Login with an offline/local account.
4. Launch the installed Forge.
5. Enter a world.

Expected Behavior

The game should launch with an offline account.

Platform

- Device model: Any
- CPU architecture: Any (mine: x86_64)
- Android version: Any (mine: Android 9)
- PojavLauncher version: Any (mine: commit fb7a4b2)

Anything else?

It seems Mojang authentication system has changed as explained above, lead to broken offline account support as expected (probably they are trying to stop people playing full Minecraft for free). There are some ways to get around this bug:

• [Removed solution]
• Login with an online account <- recommended

Note that I haven’t tried with joining server, please let me know below if the problem happens while joining server.
Update: the problem doesn’t happen in multiplayer.

Anyways, this is another reason for the offline account to be replaced with local account soon. You should buy the game before playing it (unless you’re going to play demo mode).

[RealEthanPlayzDev]

👍 Buy an online account! Stop relying on offline account because it's gonna get replaced eventually.

[MistyStory1]

thanks!problem solved!

[Jamespoxdxdxd]

Oh i see but you guys are going to replace the offline acc as local acc? Is this means that we have to pay to play this game? To play it fully or not?

[KEN66I]

I don't understand how to do a solution for crash forge 1.16.5 when I enter the world.

[jtghph]

THIS is what a real bug report should look like, not those brainless stupid "help me" issues

[peigenxiansheng]

emm，所以老子不能愉快游玩pojav了？

[NotAHero04]

Oh i see but you guys are going to replace the offline acc as local acc? Is this means that we have to pay to play this game? To play it fully or not?

Always has been.

[NotAHero04]

UPDATE: Fabric is now known to be affected by this change. It's still unknown whether this change targets 1.17+ or not.
Sample log file

[jtghph]

Bhai. Pirates 👌😂

[kedrick021]

Fuck turn off all your data or wifi and try again stupid

[Voiasis]

[XavierErrorLog]

This seems very dumb to pay for an app that it's very likely to crash 88% of the time and I have a Samsung galaxy tablet which literally is a beast so unless you guys are going broke. I see no reason for this change might as well move to an older version just to play the game smh.

[khanhduytran0]

This seems very dumb to pay for an app that it's very likely to crash 88% of the time and I have a Samsung galaxy tablet which literally is a beast so unless you guys are going broke. I see no reason for this change might as well move to an older version just to play the game smh.

You’re paying for Mojang/Microsoft, not us. Also, it’s a PC game running on mobile after all, so what do you expect? Stability is a thing, but it depends on user settings.

I see no reason for this change might as well move to an older version just to play the game smh.

Do you want Microsoft to sue us? If so, go ahead. As I said, offline account will be removed, closing the door for pirates. Support for pirates will also be dropped then.

[huoguo520]

👍购买一个在线帐户！停止依赖离线帐户，因为它最终会被替换。

No💵😧

[huoguo520]

👍购买一个在线帐户！停止依赖离线帐户，因为它最终会被替换。

No💵😧

👍购买一个在线帐户！停止依赖离线帐户，因为它最终会被替换。

No💵😧

[huoguo520]

Mainly because it is too expensive and has no money.😂 爆炒火锅 ***@***.***

…

---Original--- From: ***@***.***&gt; Date: Sun, Apr 3, 2022 14:56 PM To: ***@***.***&gt;; Cc: ***@***.******@***.***&gt;; Subject: Re: [PojavLauncherTeam/PojavLauncher] [BUG] Crashes on joining world with Fabric/Forge + Offline account (Issue #2679) 👍 Buy an online account! Stop relying on offline account because it's gonna get replaced eventually. No — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***&gt;

[Plum-mc]

Can you make a Yggdrasil-logging-in?Perhaps it will solve this problem in a better way.

[Plum-mc]

I have a question, if Mojang really changed the login mode, then why don't the other launchers, such as Mio-Ultimate, not have that problem?

[Tiger56c]

And 1.12.2 it crash at offline account

[Tiger56c]

Forge

[Mathias-Boulay]

offline accounts don't work anymore. No fix will be provided

[KentangGG121]

Fabric 1.18.1 crashing using new renderer holy gl4es

[kingsmen1234]

does anyone have help no matter what version i play the only way the game works is with optifine and i would like to play using forge but it always say game closed with the error code 1(?)

[Felix14-v2]

Do you want Microsoft to sue us?

Misrosoft has been successfully turning a blind eye to the largest pirate launcher project owned by TLauncher Incorporated for more than 7 years. Moreover, this is not just a pirate launcher — it is a whole complex of legal and illegal software that allows its owners to make a profit of millions of dollars every year. And microsoft just doesn't do anything with them! Do you really think that they will care about a relatively small project that is not even monetized in any way?

However, I understand that you really should have done that. As for me, it's just inconvenient for me now to constantly wait for the authorization process to complete before each new launch of the game, because the launcher constantly logs me out when it closes.

[Fl414r]

You really blocks offline accounts..?
Something tells me that after a bunch of bans for no reason, you will have much fewer users...
(I strongly disapprove of this policy, as I myself have been playing without a license for a long time, since I simply did not have the opportunity to buy it. But damn it, I IMMEDIATELY bought this game when I had the opportunity to do so. This game cannot be damaged by pirates. After piracy, 90% will eventually buy it. The only ones that can hurt this game are Microsoft itself and its reporting system 1.19.1)

[Felix14-v2]

after a bunch of bans for no reason, you will have much fewer users.

What do you mean? PojavLauncher does not ban anyone. The only limitation for offline accounts is the inability to download versions from the Mojang repository, and this is the Mojang requirement justified in the EULA. But even this can be circumvented by downloading the archive with the version separately from the launcher.

Let me remind you that the decision to stop supporting offline accounts without a license is not the desire of the development team, but the requirement of the Minecraft EULA.

[Fl414r]

What do you mean? PojavLauncher does not ban anyone.
I about 1.19.1 reporting system and 2 bugs in reports system. If you got banned you can't play Multiplayer and Rearms in 1.6(or 1.16...)-1.19.1
upd. oh and this
offline accounts don't work anymore. No fix will be provided. Mathias-Boulay closed this as [completed]

[Felix14-v2]

What do you mean? PojavLauncher does not ban anyone. I about 1.19.1 reporting system and 2 bugs in reports system. If you got banned you can't play Multiplayer and Rearms in 1.6(or 1.16...)-1.19.1

But how does this apply to PojavLauncher? In your previous message, you blame the Pojav team for this...?

[Fl414r]

By the way, about TLauncher... At the beginning of TLauncher (after being stolen from the original creator) it was have part with virus that changed the hosts file. And in general, they have a dirty history, take at least a moment where they can remove servers that did not pay them from the list of servers in the game...
But... it still alive.

[Felix14-v2]

By the way, about TLauncher... At the beginning of TLauncher (after being stolen from the original creator) it was have part with virus that changed the hosts file. And in general, they have a dirty history, take at least a moment where they can remove servers that did not pay them from the list of servers in the game... But... it still alive.

Okay, you say this to a person who personally communicates with the developer of the original TL Legacy and respects their position to provide a launcher for demonstration purposes with a call to buy the game in the future, and I am very well aware of its entire tragedy... but how does this relate to PojavLauncher and the topic?

[Fl414r]

but how does this relate to PojavLauncher and the topic?
this not relate...
Either way, I'm outraged by this.

[Felix14-v2]

Either way, I'm outraged by this.

Again,

Let me remind you that the decision to stop supporting offline accounts without a license is not the desire of the development team, but the requirement of the Minecraft EULA.

And yeah, offline accounts still work:

[khanhduytran0]

This game cannot be damaged by pirates

@Fl414r This game isn’t “victim”, but we are.

One of our devs who live in US got this email. What would you do in this case?

This Subscriber should understand clearly that there are serious consequences for infringement.
The Copyright Act in the United States provides for statutory damages of up to $30,000 per work infringed, and up to $150,000 per work for willful infringement.
17 U.S.C. section 504(c).

[khanhduytran0]

Another thing to remind you: GitHub has now been owned by Microsoft, which means they can takedown this project anytime, if offline mode is kept. Since TLauncher devs do not come from US and its source code is closed, they are not affected.

[khanhduytran0]

If you want to avoid the use of 1.19.1+ chat reporting, use local account.