Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimal verification rules (through eslint) for things prettier doesn't cover #47

Open
RafaelVidaurre opened this issue Sep 28, 2018 · 1 comment
Labels
enhancement New feature or request Github For Asana integration use only

Comments

@RafaelVidaurre
Copy link
Contributor

RafaelVidaurre commented Sep 28, 2018

Pre-commit checker for eslint is still a good idea for specific rules like:

  • Missing imports
  • Using deprecated APIs
@RafaelVidaurre RafaelVidaurre added the Github For Asana integration use only label Sep 28, 2018
@Grsmto
Copy link
Contributor

Grsmto commented Sep 28, 2018

CRA Webpack build script will break on CI if there is any Eslint warnings in the code as well.

@RafaelVidaurre RafaelVidaurre added the enhancement New feature or request label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Github For Asana integration use only
Projects
None yet
Development

No branches or pull requests

2 participants