Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential logic Error within apply.cigar(). Insertions attribute length does not vary #10

Open
ConnorChato opened this issue Feb 16, 2021 · 1 comment

Comments

@ConnorChato
Copy link
Collaborator

sup/src/parse-sam.R

Lines 71 to 74 in bba7bed

insertions[[length(new.seq)+1]] <- c(
substr(seq, left, left+len-1),
substr(qual, left, left+len-1)
)

Given that new.seq is a single string which grows through a series of paste0() calls, is the use of length(new.seq) supposed to be nchar(new.seq)? Currently it looks like the Insertions attribute always generates a NULL element followed by a single pair of insertions.

@ConnorChato
Copy link
Collaborator Author

Currently updated to use nchar in the con branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant