Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Upgrade to Bootstrap 4.0.0 stable #78

Open
emmastone9 opened this issue Jan 28, 2018 · 5 comments
Open

Upgrade to Bootstrap 4.0.0 stable #78

emmastone9 opened this issue Jan 28, 2018 · 5 comments
Labels

Comments

@emmastone9
Copy link

Summary

gulp build throws error

Steps to Reproduce

Trying to install Postleaf on my mac,
git clone https://github.com/Postleaf/postleaf.git
git clone https://github.com/Postleaf/empower-theme.git themes/empower-theme

Copied .env.example to .env and added localhost

npm install
sudo npm install -g gulp-cli

gulp build
returns:
[14:59:55] Finished 'build' after 118 μs
node_modules/bootstrap/scss/_variables.scss
Error: no mixin named -assert-ascending

   Backtrace:
   	node_modules/bootstrap/scss/_variables.scss:175
    on line 175 of node_modules/bootstrap/scss/_variables.scss

@include _assert-ascending($grid-breakpoints, "$grid-breakpoints");
---------^

Additional info

  • Postleaf version: latest
  • Node version: 7.9.0
  • Affected browsers: n/a
  • Operating system: mac

Note: This issue tracker is ONLY for bug reports and feature requests. If this is a personal support issue, please visit postleaf.org/support.

@claviska claviska added the Bug label Jan 29, 2018
@claviska
Copy link
Member

I belive this is happening because Bootstrap is now stable. There were a few API changes from BS4 alpha to stable, so updates need to be made. Until then, try locking in 4.0.0-alpha.6 in your package.json.

@claviska claviska changed the title Error: no mixin named -assert-ascending Upgrade to Bootstrap 4.0.0 stable Jan 29, 2018
@emmastone9
Copy link
Author

@claviska
locking in == commenting out?

I have the following line in package.json
"bootstrap": "^4.0.0-alpha.6",
However,
gulp build still returns the same error.

@claviska
Copy link
Member

claviska commented Jan 29, 2018 via email

@emmastone9
Copy link
Author

Thanks. That fixed the issue.. There's one more problem:
When running on port other than 80, default 3000
http://localhost/assets/css/lib.css returns 404

All other CSS/JS includes return 200.

@claviska
Copy link
Member

claviska commented Jan 29, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants