Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving window length for fwd. temperature approximation can exceed snapshot length #1288

Open
amos-schledorn opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels

Comments

@amos-schledorn
Copy link
Contributor

Problem

When approximating central heating forward temperatures, ambient temperature is smoothed by a moving average of, per default, rolling_window_ambient_temperature=72[h].
If the snapshot length is lower than 72 hours, xarray runs into an error when calculating the moving average.
(reported by @bobbyxng )

Hot fix

Modify rolling window length in config.

Long-term fix

  • If this happens, throw a warning
  • Clip the rolling window length to the snapshot length
  • A warning rather than an error should be fine since we expect no user to make runs with snapshot length below rolling window length in production but rather for testing (@fneum)
@amos-schledorn amos-schledorn self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant