Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split whitespace before romanize the text #922

Closed
wannaphong opened this issue Aug 2, 2024 · 2 comments
Closed

Split whitespace before romanize the text #922

wannaphong opened this issue Aug 2, 2024 · 2 comments
Labels
Hacktoberfest for Hacktoberfest event
Milestone
5.1

Comments

@wannaphong
Copy link
Member

From PyThaiNLP/pythainlp-corpus#26, I think pythainlp.transliterate.romanize should split whitespace before romanize the text. It can improve romanize funtion.
@pavaris-pm
Copy link
Contributor

From PyThaiNLP/pythainlp-corpus#26, I think pythainlp.transliterate.romanize should split whitespace before romanize the text. It can improve romanize funtion.

@wannaphong I can help figure out on this krub.

@pavaris-pm pavaris-pm mentioned this issue Oct 6, 2024
Merged
2 tasks
@wannaphong wannaphong added the Hacktoberfest for Hacktoberfest event label Oct 7, 2024
@wannaphong
Copy link
Member Author

Done #924

@wannaphong wannaphong added this to the 5.1 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest for Hacktoberfest event
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
2 participants
@wannaphong @pavaris-pm