Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage]: Request for Trace ID Logging in Inference Engine #717

Open
BaiMoHan opened this issue Sep 12, 2024 · 3 comments
Open

[Usage]: Request for Trace ID Logging in Inference Engine #717

BaiMoHan opened this issue Sep 12, 2024 · 3 comments

Comments

@BaiMoHan
Copy link

BaiMoHan commented Sep 12, 2024

I've noticed that the logs currently record information regarding sample parameters besides the prompt. What I really need is the ability to log a trace_id for each request. My use case involves scenarios where network issues or other factors might disrupt communication, and I'm not certain if the request has truly reached my inference engine node. To address this, I would like to pass a trace_id along with each request.

Currently, I'm considering adding a middleware to the api_server to achieve this. Do you have any better suggestions or recommendations on how to implement this feature more effectively?

@AlpinDale
Copy link
Member

That sounds useful, I will look into it soon. I can try and implement it on our side if possible, otherwise middleware should work fine for now.

@BaiMoHan
Copy link
Author

That sounds useful, I will look into it soon. I can try and implement it on our side if possible, otherwise middleware should work fine for now.

I’m glad to hear that you are considering this. I will first try modifying the source code using the middleware approach to support my needs. If you have any other new ideas, please let me know. I look forward to hearing from you.

@BaiMoHan
Copy link
Author

BaiMoHan commented Sep 12, 2024

Maybe the user field parameter should be logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants