Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding code samples on the home page not working #353

Open
krysros opened this issue Jan 15, 2023 · 2 comments · May be fixed by #386
Open

Expanding code samples on the home page not working #353

krysros opened this issue Jan 15, 2023 · 2 comments · May be fixed by #386

Comments

@krysros
Copy link
Contributor

krysros commented Jan 15, 2023

The code samples on the home page are expanded by default and expanding/shrinking doesn't work when you click the arrow.
@slinkp
Copy link

slinkp commented Sep 15, 2023

Confirmed in both Firefox 117.0.1 (MacOS) and Chrome 116.0.5845.187 (MacOS).
Also, you can't visually distinguish where one sample ends and one begins.
Screenshot 2023-09-15 at 9 11 19 AM

@slav0nic
Copy link
Contributor

slav0nic commented Jan 30, 2024 •
edited
Loading

This is why
https://github.com/highlightjs/highlight.js/wiki/security
highlightjs/highlight.js#2889

highlight.js > 11 stipes html inside code block, so all spans .code-top, .code-bottom not present

@slav0nic slav0nic linked a pull request Sep 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mergeHTMLPlugin plugin for hljs slav0nic/trypyramid.com
3 participants
@slinkp @slav0nic @krysros