You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently DCMQI is not able to load nonconformant DCM Seg e.g. from TCIA dataset "qiba_ct_1c" as those DCM Segs have not algorithm type set.
That leads to an exception in Dicom2ItkConvert.cpp line 485ff.
Looking at the standard DCMQI is correct, as SAT has to be defined. Nevertheless it seems over pendantic, as there is no option to e.g. explicitly allow to load such a data and only bring a worning and replase the value e.g. with manual or a user defined choice. This ultimatly means to dismiss the data, even so the missing meta information is not relevant for all use cases (it would something different, e.g. with geometric information).
I would like to clarify if the current implementation should be the only behavior and if not, how to best adapt it.
Thanks,
Ralf
The text was updated successfully, but these errors were encountered:
Ralf, that's a fair point. I agree this is overly pedantic. I think it would be fine to set algorithmType to empty string in this situation. Would you like to make a PR? This way you could test it against your data, and see if there are any other similar issues in other places.
I have to warn you though that "qiba_ct_1c" is ancient, and I am not sure it was encoded correctly. There may be other issues. Here are OHIF v2 links from Imaging Data Commons for 6 studies from that collection that contain SEG. I tried to open one of those, and failed.
Thanks for the warning. 😄
It is not important, that qiba_ct_1c will work out in the end. But an bug ticket for MITK triggered the investigation, and at least for the raised point, I thought it would do no harm to be less pedantic or at least offer the option to be less pedantic.
Currently DCMQI is not able to load nonconformant DCM Seg e.g. from TCIA dataset "qiba_ct_1c" as those DCM Segs have not algorithm type set.
That leads to an exception in Dicom2ItkConvert.cpp line 485ff.
Looking at the standard DCMQI is correct, as SAT has to be defined. Nevertheless it seems over pendantic, as there is no option to e.g. explicitly allow to load such a data and only bring a worning and replase the value e.g. with manual or a user defined choice. This ultimatly means to dismiss the data, even so the missing meta information is not relevant for all use cases (it would something different, e.g. with geometric information).
I would like to clarify if the current implementation should be the only behavior and if not, how to best adapt it.
Thanks,
Ralf
The text was updated successfully, but these errors were encountered: