Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label to issue and PR during submission wf and improve output #480

Closed
mickahell opened this issue Aug 3, 2023 · 2 comments · Fixed by #481
Closed

Add label to issue and PR during submission wf and improve output #480

mickahell opened this issue Aug 3, 2023 · 2 comments · Fixed by #481
Assignees
@mickahell
Labels
enhancement New feature or request

Comments

@mickahell
Copy link
Collaborator

mickahell commented Aug 3, 2023 •
edited
Loading

What is the expected enhancement?

Add labels :

  • submission label to every submission issue and PR
  • on hold label to every submission issue and PR who doesn't pass the standard check
  • ready label to every submission issue and PR who passed the standard check

Improve output message.
@mickahell mickahell self-assigned this Aug 3, 2023
@mickahell mickahell added the enhancement New feature or request label Aug 3, 2023
@mickahell
Copy link
Collaborator Author

@frankharkins could you create the label ready for submission ready to be merged (or something similar) please :)

@frankharkins frankharkins added ready and removed ready labels Aug 4, 2023
@frankharkins
Copy link
Member

Done :)

@mickahell mickahell mentioned this issue Aug 6, 2023
Merged
10 tasks
@mickahell mickahell changed the title Add label to issue and PR during submission wf Add label to issue and PR during submission wf and improve output Aug 6, 2023
frankharkins added a commit that referenced this issue Aug 17, 2023
@mickahell @frankharkins @github-actions
CI: Add labels to issue and PR and improve output from submission wf (#…
fb86c84 
…481)

<!--
⚠️ If you do not respect this template, your pull request will be
closed.
⚠️ Your pull request title should be short detailed and understandable
for all.
⚠️ Also, please add a release note file using reno if the change needs
to be
  documented in the release notes.
⚠️ If your pull request fixes an open issue, please link to the issue.

- [ ] I have added the tests to cover my changes.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
-->

### Summary
Add labels to issue and PR from submission wf.
Improve the wf output.

### Details and comments
- [x] `submission` label to every submission issue and PR
- [x] `on hold` label to every submission issue and PR who doesn't pass
the standard check
- [x]  remove `on hold` label if the submission passed
- [x] `ready` label to every submission issue and PR who passed the
standard check
- [x] remove `ready` label if the submission doesn't passed anymore
- [x] Add a wf summary
- [x] Make the comment in the issue more clean
- [x] Make the comment in the PR more clean
- [x] Tests run
- [x] Clean

---
Closes #480

---------

Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: frankharkins <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mickahell mickahell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Add labels to issue and PR and improve output from submission wf mickahell/ecosystem
2 participants
@mickahell @frankharkins