Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure sizes need to be reduced #34

Open
jstac opened this issue Apr 13, 2020 · 6 comments
Open

figure sizes need to be reduced #34

jstac opened this issue Apr 13, 2020 · 6 comments

Comments

@jstac
Copy link
Contributor

jstac commented Apr 13, 2020

Apart from the first one, all the figures on this page are too big: https://python-programming.quantecon.org/about_py.html.

@shlff @Harveyt47 @najuzilu we talked about how to fix this for a long time -- maybe too long, so nothing got done :-)

I suggest we just reduce the size of them using the :scale: argument to the figure directive. Would someone be able to help with this?

@Harveyt47
Copy link
Member

Hey @jstac is this also to do with the figure size of figures generated by code across the lectures. Or just PNGs, because I remember something similar in #767. I'm uncertain if this overlaps.

@jstac
Copy link
Contributor Author

jstac commented Apr 13, 2020

This is separate because it just pertains to PNG files, or whatever kinds of files we're loading into the page via .. figure::

@DrDrij at one point said something about how we should use an image manipulation program to change the size of the figures but I think this is unworkable for us. I suggest we just alter the size via :scale:.

@shlff
Copy link
Member

shlff commented Apr 14, 2020

Thanks, @jstac . Hi mates, we also need to update the second figure (pandas vs matlab) of that lecture (https://python-programming.quantecon.org/about_py.html) to 2020 version.

@najuzilu
Copy link
Contributor

I have utilized :scale: in quantecon-example (see book/docs/). I think it would be easy to copy-paste + minor edits into the actual rST files if @jstac thinks the size dimensions in the book example are what we're aiming.

@jstac
Copy link
Contributor Author

jstac commented Apr 14, 2020

Yes, that sounds great to me @najuzilu, thanks. We just need to use :scale: and that version of the same material has the right scale numbers.

@shlff yes please!

@najuzilu
Copy link
Contributor

It looks like copy-pasting the scale parameter doesn't necessarily scale them to the same size as in the quantecon-example. I just rendered them locally and played around with the scale parameter until the figures looked right. Posting this here in case it's useful to other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants