Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect promotion rule #9

Open
Roger-luo opened this issue Jul 4, 2019 · 1 comment
Open

Incorrect promotion rule #9

Roger-luo opened this issue Jul 4, 2019 · 1 comment
Assignees
@Roger-luo

Comments

@Roger-luo
Copy link
Member

CuYao.jl/src/CUDApatch.jl

Line 80 in ac4d158

res = CuArrays.zeros(promote_type(T1,T2), (size(A).*size(B))...)

Should use LinearAlgebra.promote_op for consistency with Base
@Roger-luo Roger-luo self-assigned this Jul 4, 2019
@GiggleLiu
Copy link
Member

So, what is the difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roger-luo Roger-luo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiggleLiu @Roger-luo