From 448f264492c4c85d08b615ffe32a469dc52064be Mon Sep 17 00:00:00 2001 From: Quinn Klassen Date: Thu, 15 Aug 2024 16:56:19 -0700 Subject: [PATCH] Fix workflow start delay docs to say signal does not interrupt delay (#2190) Fix start delay docs --- .../src/main/java/io/temporal/client/WorkflowOptions.java | 6 ++---- .../io/temporal/internal/worker/WorkflowWorkerTest.java | 5 ----- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java b/temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java index 4e786e56f..0f468f667 100644 --- a/temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java +++ b/temporal-sdk/src/main/java/io/temporal/client/WorkflowOptions.java @@ -374,10 +374,8 @@ public Builder setDisableEagerExecution(boolean disableEagerExecution) { } /** - * Time to wait before dispatching the first workflow task. If the workflow gets a signal before - * the delay, a workflow task will be dispatched and the rest of the delay will be ignored. A - * signal from signal with start will not trigger a workflow task. Cannot be set the same time - * as a CronSchedule. + * Time to wait before dispatching the first workflow task. A signal from signal with start will + * not trigger a workflow task. Cannot be set the same time as a CronSchedule. */ public Builder setStartDelay(Duration startDelay) { this.startDelay = startDelay; diff --git a/temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowWorkerTest.java b/temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowWorkerTest.java index 9da6741f5..94fb6571d 100644 --- a/temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowWorkerTest.java +++ b/temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowWorkerTest.java @@ -182,11 +182,6 @@ public void concurrentPollRequestLockTest() throws Exception { }); assertTrue(worker.start()); - // All slots should be available - reporter.assertGauge( - MetricsType.WORKER_TASK_SLOTS_AVAILABLE, - ImmutableMap.of("worker_type", "WorkflowWorker"), - 100.0); // Unblock the first poll blockFirstPollLatch.countDown(); // Wait until we have got all the polls