-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting pagedTableTemplate incorrectly reports page number as 1 #2054
Comments
the correct behaviour is to reset the page |
i just changed sort order and saw the page reset to 1... I'm not sure what you're describing? |
The bug is that the table says it's on page 1, when in reality it's on page n. It's easier to see in the api filter request when you sort the page. You'll see that the sorting filter updates correctly, but the You'll also be able to see the bug through the steps below:
e.g. The table says page 1, but the filter request was for page 221 Additionally, there are only 13 recordings on the "first page" (because we are still on the last page) |
Okay good spot. It looks like we intend to reset the page but it's not being passed through to the request - that should make it easy to track doown. |
I reckon we should upgrade this page to use |
Describe the bug
When sorting a
pagedTableTemplate
(e.g. Audio recordings list page, my bookmarks, my projects, etc...) the page number is reset to one, when the filter applied still emits page n that the user was on before filtering.To Reproduce
Steps to reproduce the behavior:
Expected behavior
This behavior is not seen in the batch download page as it does not use the
pagedTableTemplate
.Therefore, we should either:
pagedTableTemplate
pageNumber
to be dependent on the filterDesktop (please complete the following information):
Additional context
The batch download page does not have this bug as it doesn't use the
pagedTableTemplate
:The text was updated successfully, but these errors were encountered: