-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: match_name
gains additional company legal structure abbreviation alias
#157
Comments
Thanks. Can you explain what this table shows and how you think we could use it in the package? |
@maurolepore so to clarify... This is something Freddy and I discussed last week that for some companies, the standardized business structure names like "grupo" can create false positives simply because the legal structure components of the name are very similar. It would be nice if there could be a parameter in Obviously not urgent, but more a wish list item ;)
|
This actually already exists:
# get default structures
default_ownership <- r2dii.match:::get_ownership_type()
# append your additions
additions <- c("aa","bb")
custom_ownership_added <- append(default_ownership, additions)
to_alias(data,
ownership = custom_ownership_added,
remove_ownership = TRUE) |
@maurolepore this function is documented, but not exported. I think it could be useful to export |
@jdhoffa awesome! One step ahead of me ;) |
I just discussed with @jdhoffa and plan to consider this for either a release after the first one, or to extract to some other package. We'll keep this open while we polish what we already have for an upcoming release. |
Note to self: Consider carefully the maintenance burden of exporting a new function... |
match_name
gains additional company legal structure abbreviation alias
AB#10176
The text was updated successfully, but these errors were encountered: