Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: match_name gains additional company legal structure abbreviation alias #157

Open
FrederickFa opened this issue Feb 28, 2020 · 7 comments
Labels
ADO Add issue to ADO feature a feature request or enhancement

Comments

@FrederickFa
Copy link

FrederickFa commented Feb 28, 2020

image

image
image

AB#10176

@FrederickFa FrederickFa changed the title AG - Aktiengesellschaft Company Legal Structure Feb 28, 2020
@FrederickFa FrederickFa changed the title Company Legal Structure Company Legal Structure Abbreviation Alias Feb 28, 2020
@maurolepore
Copy link
Contributor

Thanks. Can you explain what this table shows and how you think we could use it in the package?

@vintented
Copy link

@maurolepore so to clarify... This is something Freddy and I discussed last week that for some companies, the standardized business structure names like "grupo" can create false positives simply because the legal structure components of the name are very similar. It would be nice if there could be a parameter in add_alias to remove the corporate structure abbreviation.

Obviously not urgent, but more a wish list item ;)

add_alias(remove_legal_structure = TRUE)

@jdhoffa
Copy link
Member

jdhoffa commented Mar 2, 2020

This actually already exists:

  1. Call r2dii.match:::to_alias(...,remove_ownership = TRUE) (the default is false)
  2. The default ownership structures that are removed can be seen by calling r2dii.match:::get_ownership_type()
  3. If you want to add an ownership type to this list of defaults:
# get default structures
default_ownership <- r2dii.match:::get_ownership_type()

# append your additions
additions <- c("aa","bb")
custom_ownership_added <- append(default_ownership, additions)

to_alias(data, 
         ownership = custom_ownership_added, 
         remove_ownership = TRUE)

@jdhoffa
Copy link
Member

jdhoffa commented Mar 2, 2020

@maurolepore this function is documented, but not exported. I think it could be useful to export to_alias

@vintented
Copy link

@jdhoffa awesome! One step ahead of me ;)

@maurolepore
Copy link
Contributor

I just discussed with @jdhoffa and plan to consider this for either a release after the first one, or to extract to some other package. We'll keep this open while we polish what we already have for an upcoming release.

@jdhoffa jdhoffa added feature a feature request or enhancement and removed enhancement labels Apr 14, 2023
@jdhoffa jdhoffa self-assigned this Feb 6, 2024
@jdhoffa jdhoffa added the ADO Add issue to ADO label Feb 6, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Feb 6, 2024

Note to self: Consider carefully the maintenance burden of exporting a new function...

@jdhoffa jdhoffa changed the title Company Legal Structure Abbreviation Alias feat: match_name gains additional company legal structure abbreviation alias Mar 6, 2024
@jdhoffa jdhoffa added ADO Add issue to ADO and removed ADO Add issue to ADO labels Mar 6, 2024
@jdhoffa jdhoffa removed their assignment Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Add issue to ADO feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants