Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep: don't depend on r2dii.data for unit tests #392

Open
jdhoffa opened this issue Mar 7, 2022 · 0 comments
Open

upkeep: don't depend on r2dii.data for unit tests #392

jdhoffa opened this issue Mar 7, 2022 · 0 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Mar 7, 2022 •
edited by azure-boards bot
Loading

Context: I am exploring the effects of ADO #4226 "Changing all mentions of ald to abcd". One crucial change there is that the dataset r2dii.data::ald_demo will be renamed to r2dii.data::abcd_demo.

In this exploration phase, I am trying a "brute force" approach on a safe branch, just to see what happens"if i remove all ald references. One result is that many tests in r2dii.match fail. This is because many tests depend directly on r2dii.data datasets.

r2dii.data - contains demonstration datasets that can be used to demo tools and teach users how to run PACTA using r2dii
r2dii.match - currently has many test files that import r2dii.data directly, and are brittle if changes are made to the r2dii.data package.

Compare for example to r2dii.analysis where we removed this dependency directly, making all tests self-contained.

I think we should try to do something similar with r2dii.match, making use instead of the fake_*() helper functions.

AB#10182
@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label May 19, 2023
@jdhoffa jdhoffa added the ADO Add issue to ADO label Feb 6, 2024
@jdhoffa jdhoffa self-assigned this Feb 6, 2024
@jdhoffa jdhoffa removed the ADO Add issue to ADO label Mar 6, 2024
@jdhoffa jdhoffa changed the title Don't depend on r2dii.data for tests upkeep: don't depend on r2dii.data for tests Mar 6, 2024
@jdhoffa jdhoffa added ADO Add issue to ADO and removed ADO Add issue to ADO labels Mar 6, 2024
@jdhoffa jdhoffa changed the title upkeep: don't depend on r2dii.data for tests upkeep: don't depend on r2dii.data for unit tests Mar 14, 2024
@jdhoffa jdhoffa mentioned this issue Mar 14, 2024
Open
This was referenced Mar 22, 2024
Closed
Merged
@jdhoffa jdhoffa removed their assignment Apr 10, 2024
jdhoffa added a commit that referenced this issue Apr 25, 2024
@jdhoffa
upkeep: bump r2dii version in helper-skip_if_r2dii_data_outdated.R
e8af8cd 
The (brittle) snapshot tests are currently failing when run against the CRAN published `r2dii.data v0.5.0`. They only pass against the dev version of the package.

This PR bumps the function that skips snapshot tests with old `r2dii.data`. 

Another indication that we should prioritize working on #392

Relates to RMI-PACTA/r2dii.data#374
Relates to #473
@jdhoffa jdhoffa mentioned this issue Apr 25, 2024
Merged
@jdhoffa jdhoffa mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdhoffa