Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine docker build trigger workflow files #261

Closed
AlexAxthelm opened this issue Mar 6, 2024 · 0 comments · Fixed by #265
Closed

Combine docker build trigger workflow files #261

AlexAxthelm opened this issue Mar 6, 2024 · 0 comments · Fixed by #265
Labels
docker gh action

Comments

@AlexAxthelm
Copy link
Collaborator

We currently maintain 3 workflow files that trigger docker builds:

  • build-Docker-image-nightly.yml
  • build-Docker-image-on-push-to-main.yml
  • build-Docker-image-on-push-to-pr.yml

Which call the same docker build and push workflow. The differences between these files are minimal, and would be a good candidate to be merged to a single file with multiple trigger.
@cjyetman cjyetman mentioned this issue Mar 7, 2024
Closed
@AlexAxthelm AlexAxthelm linked a pull request Mar 7, 2024 that will close this issue
Ci/261 merge actions #265
Merged
@cjyetman cjyetman mentioned this issue Mar 7, 2024
Merged
AlexAxthelm added a commit that referenced this issue Mar 7, 2024
@AlexAxthelm
Ci/261 merge actions (#265)
8176ac4 
closes #261 
closes #262


Merge workflows into a single file with multiple event triggers. Reduce
maintenance burden from multiple similar files, and ensure workflows are
run consistently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker gh action
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ci/261 merge actions RMI-PACTA/workflow.transition.monitor
2 participants
@cjyetman @AlexAxthelm