Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive complete PACTA data input directory during CI/CD #348

Closed
cjyetman opened this issue Jul 18, 2024 · 4 comments · Fixed by #351
Closed

archive complete PACTA data input directory during CI/CD #348

cjyetman opened this issue Jul 18, 2024 · 4 comments · Fixed by #351
Assignees

Comments

@cjyetman
Copy link
Member

It would be advantageous for whatever constructed version of PACTA data inputs is created in CI/CD for workflow.transition.monitor Docker images was also archived somewhere on Azure for reference/easy access, otherwise one has to reconstruct it manually, which is tedious and error prone.

@AlexAxthelm
Copy link
Collaborator

I believe that workflow.data.preparation already does this (and drops an archive in the same location as the outputs archive), unless I'm missing something

https://github.com/RMI-PACTA/workflow.data.preparation/blob/6001fa51451c0312bf70d3387d1b17dd29236139/run_pacta_data_preparation.R#L905-L917

@cjyetman
Copy link
Member Author

but the CI/CD here adds benchmarks and possibly peer files to it before adding to the Docker image... so to inspect the same thing locally one has to reconstruct it manually based on what they think happened during the CI/CD

@AlexAxthelm
Copy link
Collaborator

Ah. noted. Would you prefer an actual zip to download, or if It's just a tidy collection of links/pointers to the Azure Storage would that be enough?

@cjyetman
Copy link
Member Author

I only ever access Azure through the webGUI, which unfortunately does not support downloading multiple files. There's also something satisfying to me about having a single zip file that has everything in it rather than a directory full of files which could hypothetically much more easily get modified.

AlexAxthelm added a commit that referenced this issue Jul 19, 2024
Pack the `pacta-data` and `templates.transition.monitor` directories
that were used to build the image, and upload archive to Azure Blob
container.

Closes #348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants