Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsure of behaviour when package is installed directly from source control #1

Open
steven-murray opened this issue Sep 10, 2019 · 2 comments
Assignees

Comments

@steven-murray
Copy link
Collaborator

In the README it has the line:

Package installed directly from hosted source control via ``pip install git+git:...``: unsure?

This behavior should be verified. @bhazelton do you have any idea how it should work in this case?

As a bonus, any ideas for other cases that need to be covered?

@steven-murray steven-murray self-assigned this Sep 10, 2019
@bhazelton
Copy link
Member

I agree it should be verified. I'm not sure I agree that the behavior you list with pip install -e . is what happens (and I'm pretty sure it's not what we want to happen). I think when you install that way you want to get the git hash of the currently running code NOT the hash that existed when you ran pip install -e .. I believe that is what happens because the code first tries to get the hash from git before it reads the GIT_INFO file.

@steven-murray
Copy link
Collaborator Author

This has been fixed, and now works as intended, though I cannot prove it with tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants