Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big changes in 2nd gen reference sims using diffuse maps #423

Open
jpober opened this issue Feb 27, 2023 · 2 comments
Open

Big changes in 2nd gen reference sims using diffuse maps #423

jpober opened this issue Feb 27, 2023 · 2 comments

Comments

@jpober
Copy link
Member

jpober commented Feb 27, 2023

In 2.3_airy_flat_PS: ~Two of magnitude of difference in visibility amplitudes. (New runs are smaller.) Phases are different too; visibilities are not scaled copies of each other.

Change seems to appear between v1.2.1 and v1.2.2. (Although it may not account for all the difference.)

In 2.3_airy_GSM: Very strange change. Antennas seem to have three tiers of maximum autocorrelation amplitude in the new sims (as opposed to basically uniform autocorrelation amplitude).

See: https://www.overleaf.com/9613713963jthpjznmmyvx

@mkolopanis
Copy link
Member

I remember in 7a3a127 we fixed a bug when nsky_parts > 1 had missing data. Have we re-run sims to compare since then?

@jpober
Copy link
Member Author

jpober commented Mar 21, 2024

Daniya did this testing and confirmed things were much better with EoR sky models. I think she also checked the reference simulations, but we are re-checking that now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants