Updated build script to create Release assemblies as output #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoryDungan
approved these changes
Feb 27, 2019
|
Hi @RoryDungan, what do you think about this change? 👍 |
|
Yeah I think it looks good but I don't work at RSG any more. @kalvinpearce or @Borningstar can you merge? |
|
Actually on second thought this might not be best. It won't actually fix #84 because Nuget packages never came from Travis, they're built manually. Changing the Travis config won't necessarily affect that but we may want to keep using the debug version for running unit tests on Travis for better stack traces in the case a test fails. On the other hand maybe it's best to test the assembly that most closely resembles what should be on Nuget so maybe release is better. I don't think it makes a huge difference in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #84.
The build script is updated to create release assemblies as CI output. If I'm correct this should result in release assemblies pushed to NuGet package. Hopefully this will fix the issue linked above.