Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright Usage and Reference Hunting #270

Closed
Starkium opened this issue Oct 8, 2024 · 13 comments
Closed

Copyright Usage and Reference Hunting #270

Starkium opened this issue Oct 8, 2024 · 13 comments
Labels
help wanted rebranding issues and pr's related to engine rebranding

Comments

@Starkium
Copy link
Contributor

Starkium commented Oct 8, 2024

Tested versions

N/A

System information

N/A

Issue description

We're in the process of renaming portions of the Godot code base to Redot. We have to be very careful about not changing copyright. Some stuff has been done by hand while other stuff we've tried to iterate a bit faster over. There is potential for some hiccups.

We're pinning this topic here so that anyone can report any places that seem be incorrectly changed. You may also report here places that haven't been changed yet that need to be changed.

Steps to reproduce

N/A

Minimal reproduction project (MRP)

N/A

@Starkium Starkium self-assigned this Oct 8, 2024
@Starkium Starkium pinned this issue Oct 8, 2024
@MrDraxs
Copy link

MrDraxs commented Oct 8, 2024

README.md and logo_outline.svg needs to be changed ASAP
image

@SkogiB
Copy link
Contributor

SkogiB commented Oct 8, 2024

When importing old version projects, the version warning dialogue lists the prior version as Redot 3.x/4.x instead of the fact that it was actually a Godot project. It's a minor issue compared to others, and will require some extra work to detect Godot vs Redot projects, but it may be important in the future when Redot is more different and users will need to be warned clearly that moving a project from Godot to Redot might have unique concerns by then.

image

@decryptedchaos
Copy link
Member

When importing old version projects, the version warning dialogue lists the prior version as Redot 3.x/4.x instead of the fact that it was actually a Godot project.

There isn't really a way to differentiate between a Godot/Redot project at the present time, you get this message simply because your project was last edited in 4.0 version of the engine (branding notwithstanding)

Its always advisable to make a copy of your project when you are trying to convert it to a new version, as it will make changes to your project.

@obiwor
Copy link

obiwor commented Oct 8, 2024

the logo was changed in the Bioblaze branch "redot-merge" commit :

@SkogiB
Copy link
Contributor

SkogiB commented Oct 8, 2024

Issue Bug Report page needs to be rebranded

image

@Starkium
Copy link
Contributor Author

Starkium commented Oct 8, 2024

README.md and logo_outline.svg needs to be changed ASAP image

We're planning to change it substantially instead of just rebrand. Perhaps an intermediate step is ok.

@apofex
Copy link

apofex commented Oct 9, 2024

README.md and logo_outline.svg needs to be changed ASAP image

We're planning to change it substantially instead of just rebrand. Perhaps an intermediate step is ok.

#164 Will it be good?

@kabachuha
Copy link

The most important thing for any fork is to update the LICENSE.md file and add the new copyright on top of the existing ones

Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md).
Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur.
Permission is hereby granted, free of charge, to any person obtaining a copy

This way the original project will not own the new changes, including all the branding changes and will have to include the reverse mention if they'll need to grab the forked code parts

@tokengamedev
Copy link
Contributor

Version.py needs to be updated, specifically line 351 and line 1387. It is causing improper visual studio project.

There are other properties being set, it can be changed later

@SkogiB
Copy link
Contributor

SkogiB commented Oct 10, 2024

Version.py needs to be updated, specifically line 351 and line 1387. It is causing improper visual studio project.

There are other properties being set, it can be changed later

We have a PR aimed at master that can go in once we've decided on a better branch organization here, I took a look at it earlier while reviewing all the PRs stacked up on readme changes that are outdated now

#63

@tokengamedev
Copy link
Contributor

tokengamedev commented Oct 11, 2024

methods version.py needs to be updated, specifically line 351 and line 1387. It is causing improper visual studio project.

will be fixed by the PR #664

@Norrox Norrox unpinned this issue Oct 11, 2024
@Spartan322 Spartan322 added the rebranding issues and pr's related to engine rebranding label Oct 14, 2024
@Spartan322
Copy link
Contributor

Is this still relevant?

@RadenTheFolf
Copy link
Contributor

This issue is now a subset of #692 and #705. Please defer all comments on changes for rebranding and copyrights to the version of the engine they apply to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted rebranding issues and pr's related to engine rebranding
Projects
None yet
Development

No branches or pull requests