Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basemaps Collision with QRiS #80

Open
joewheaton opened this issue Oct 10, 2022 · 2 comments
Open

Basemaps Collision with QRiS #80

joewheaton opened this issue Oct 10, 2022 · 2 comments
Assignees
Labels
🐛 bug Something isn't working 🌐 Viewer QGIS

Comments

@joewheaton
Copy link

Please see Riverscapes/QRiS#120 for full issue. There are aspects to be fixed in both QRAVE and QRiS

@joewheaton joewheaton added the 🐛 bug Something isn't working label Oct 10, 2022
@MattReimer
Copy link
Member

Issue makes total sense. Basemaps started as a very simple feature and now we need to

QRAVE tree traversal in general is a problem we know about. This is not the same issue as #66 but it's related. In order to traverse the tree correctly we are going to need to rework how QRave finds layers, especially in cases where the user is moving folders around in unpredictable ways.

It would be fairly easy to put a guid or some other unique identifier in the tree lead data and then use that but we need to make sure we don't break the ability to save projects. A quick experiment should prove this one way or the other.

How QRave interacts with QRiS is maybe a bigger question we haven't really thought about. Maybe that's too big for this ticket but as we throw more plugins out into the we are going to have situations where they interact. Always good to keep in mind.

@philipbaileynar
Copy link
Contributor

  1. We should rewrite the way QRAVE adds layers to the map. It currently uses string matching with names, which has caused problems on many occasions. QRiS uses a much leaner method of attaching data to each layer, making layers easier to find without string matching.
  2. We have always thought of QRiS and QRAVE in isolation. Each tool has its own group of basemaps at the bottom of it's top level project tree map ToC group node. This will always obscure layers in the tool that gets added to the map first. Perhaps we should consider a new, separate "Riverscapes Basemaps" top level map ToC group? I really don't like this suggestion because it might be confusing to users, but it overcomes the competing basemap issue.

Current situation:

- My QRiS Project
    - My Data Capture Event
        - My vector layer
        - My event Basemap
- My QRAVE Project
    -  My vector layer
    - My QRAVE basemap

Proposed Solution

- My QRiS Project
    - My Data Capture Event
        - My vector layer
- My QRAVE Project
    -  My vector layer
- Riverscapes Basemaps
      - My event Basemap
      - My QRAVE basemap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌐 Viewer QGIS
Projects
None yet
Development

No branches or pull requests

3 participants