Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLA bot seems to be running against issue comments #10

Open
MagiMaster opened this issue Jul 17, 2020 · 1 comment · May be fixed by #14
Open

CLA bot seems to be running against issue comments #10

MagiMaster opened this issue Jul 17, 2020 · 1 comment · May be fixed by #14
Labels
bug Something isn't working

Comments

@MagiMaster
Copy link

Describe the bug
After making a comment on an issue on a repo with the CLA bot, it sent me an email that it had failed.
https://github.com/Roblox/testez/actions/runs/172094273

This did not stop me from commenting BTW.

Expected behavior
The CLA bot probably shouldn't run at all for issues and issue comments.
@MagiMaster MagiMaster added the bug Something isn't working label Jul 17, 2020
@Gudahtt Gudahtt mentioned this issue Aug 25, 2020
Merged
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
9e2fe67 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
29781e0 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
c7a266f 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
@Gudahtt Gudahtt linked a pull request Aug 26, 2020 that will close this issue
Open
Gudahtt added a commit to MetaMask/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
db7e5b1 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
e230267 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to MetaMask/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
641368b 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
463c844 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to MetaMask/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
6595ecd 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
@Gudahtt
Skip comments on issues
c1c987f 
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
@robert-virkus
Copy link

I believe you need to remove the [issue_comment] section in the script:

on:
  issue_comment:
    types: [created]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip comments on issues Gudahtt/cla-signature-bot
2 participants
@robert-virkus @MagiMaster