Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not Support for HTML5 #2

Open
developer100rbh opened this issue Oct 9, 2018 · 5 comments
Open

Does not Support for HTML5 #2

developer100rbh opened this issue Oct 9, 2018 · 5 comments

Comments

@developer100rbh
Copy link

Hello, I need to implement this Library in one of my Android Project, but this is too heavy for WebView and does not work on HTML5. I Need HTML5 support with this. Thanks!
@jkjustjoshing
Copy link

What would "HTML5" support look like to you?

@RodionGork
Copy link
Owner

@jkjustjoshing perhaps it is about words "no HTML5" in index.html page. I'm afraid I've created this little thing some years ago and don't remember what precisely it meant. Probably not that it won't work with HTML5 :)

I'll try to check.

@jkjustjoshing
Copy link

Yeah, to me that means "it works on older browsers", not "it won't work in newer browsers".

@RodionGork
Copy link
Owner

@developer100rbh & @jkjustjoshing - thanks for bringing attention to it. I see now that at least in some cases adding <!doctype html> really breaks it. I'll try to take care for it :)

RodionGork added a commit that referenced this issue Oct 9, 2018
@RodionGork
Merge pull request #1 from tdbts/quirks_mode_bug
e8c67f5 
Sorry for missing this. Probably it is what we want to fix HTML5 (#2) compatibility...

Let's try!
@RodionGork
Copy link
Owner

It appeared @tdbts have solved this 4 years ago and proposed PR. I'm very sorry for not merging it in time. For now it is merged (though I think I created some mess with branches off-shooting gh-pages beforehand). But live demo page is now at github pages (see readme) - and it is in HTML5 style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkjustjoshing @RodionGork @developer100rbh