Added missing azure-tenant-id secret to databricks #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/6260489355 (with refid (in response to this comment from @damoodamoo) |
jjgriff93
approved these changes
Sep 21, 2023
jjgriff93
requested review from
stefpiatek
and removed request for
tanya-borisova
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/6273489000 (with refid (in response to this comment from @jjgriff93) |
|
Couldn’t we just add the secret through the config, same way as cognitive services key is added in? |
tanya-borisova
requested changes
Sep 23, 2023
stefpiatek
reviewed
Sep 25, 2023
stefpiatek
approved these changes
Sep 25, 2023
tanya-borisova
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
@damoodamoo convinced me that this secret better lives upstream so I'm approving this :)
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/UCLH-Foundry/FlowEHR/actions/runs/6417061708 (with refid (in response to this comment from @jjgriff93) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found
azure-tenant-idwas expected in pipeline code, but missing from databricks secrets. This adds it in.