Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionFromParams may ignore errors #32

Open
FinaLone opened this issue Sep 25, 2021 · 1 comment
Open

ConnectionFromParams may ignore errors #32

FinaLone opened this issue Sep 25, 2021 · 1 comment
Labels
bug

Comments

@FinaLone
Copy link

image

In function ConnectionFromParams, the fillString may error in first loop, and success in last loop, in this case, the error will be ignored.
@auhlig
Copy link
Contributor

auhlig commented Sep 30, 2022

Thanks for spotting this. Would you like to contribute a fix for this @FinaLone ?

@auhlig auhlig added the bug label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FinaLone @auhlig