Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema generation - features - open questions #150

Open
larshp opened this issue Aug 4, 2021 · 4 comments
Open

Schema generation - features - open questions #150

larshp opened this issue Aug 4, 2021 · 4 comments

Comments

@larshp
Copy link
Collaborator

larshp commented Aug 4, 2021

B: "Extreme Values", is this feature needed? I expect the schema generation to be based on the ABAP types
C: "Length Specification", is this feature needed? I expect the schema generation to be based on the ABAP types

@schneidermic0
Copy link
Contributor

schneidermic0 commented Aug 4, 2021

One can argue whether the minimum or maximum fields are needed at all. But isn't it helpful to see the min/max values for external consumers. Same is valid I think for the length of a text field.

In general the fields length as well as minimum or maximum are derived from the ABAP type. The additional annotations $maximum are only needed if you want to have different maximum value then the value of the ABAP type. E.g., a field specifying some percentage shall have a range between 0 and 100%.

@schneidermic0
Copy link
Contributor

I hope my answer above answers your question.
Feel free to reopen the issue if we need to discuss further details.

@larshp
Copy link
Collaborator Author

larshp commented Aug 16, 2021

reopening

@larshp larshp reopened this Aug 16, 2021
@schneidermic0
Copy link
Contributor

Which questions are open for you? Where do you need more details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants