Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMA feedback #533

Open
larshp opened this issue May 11, 2023 · 4 comments
Open

DOMA feedback #533

larshp opened this issue May 11, 2023 · 4 comments

Comments

@larshp
Copy link
Collaborator

larshp commented May 11, 2023

https://github.com/SAP/abap-file-formats/blob/main/file-formats/doma/type/zif_aff_doma_v1.intf.abap

TYPES ty_data_type TYPE c LENGTH 4.
this is the internal data type(after conversion exit), ie. not what developers see in SE11?

there is also fixed value appends, which as far as I remember are related to domains?

@schneidermic0
Copy link
Contributor

The data type represents the predefined type of the domain.

This is the first value the user has to enter in the editor (see screen shot of ADT and SE11):
image

image

@schneidermic0
Copy link
Contributor

I guess you are right. The aspect of value appends seems not to be covered, yet

@larshp
Copy link
Collaborator Author

larshp commented May 16, 2023

yea, so as a developer I enter "DF16_DEC", what goes into the field of length 4,

TYPES ty_data_type TYPE c LENGTH 4.

?
image

@schneidermic0
Copy link
Contributor

schneidermic0 commented May 16, 2023

OK. Now, I get your point. Yes, I agree. The length of 4 characters does not make sense in the file format.
Even if the actual field value on DB is only 4 characters, the ABAP file format should use either (a) values used by the enduser in the tools (ADT/SE11) or have (b) proper enum values. I think I would prefer option a (these can be still also the enum/constant values)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants