Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON file format, define how serialization should work #61

Open
larshp opened this issue Apr 12, 2021 · 5 comments
Open

JSON file format, define how serialization should work #61

larshp opened this issue Apr 12, 2021 · 5 comments

Comments

@larshp
Copy link
Collaborator

larshp commented Apr 12, 2021

suggest:

  • add comment regarding the schema version
  • add comment regarding use of lowerCamelCase(?) for naming of JSON fields
@larshp
Copy link
Collaborator Author

larshp commented Apr 13, 2021

max field name length = 30 characters, upper case characters counting as 2 characters

update: not relevant anymore due to the ABAP approach

@larshp
Copy link
Collaborator Author

larshp commented May 11, 2021

plus compression/initial value handling

@schneidermic0
Copy link
Contributor

plus compression/initial value handling

I am not sure, whether this make sense in all places. Consider such a boolean value for instance to specify whether a BAdI can be implemented by multiple BAdI implementations or only by one:

@larshp
Copy link
Collaborator Author

larshp commented May 12, 2021

having one convention/rule makes it transparent, no special cases

if initial values are skipped in the json, then it might have impact on the type design, so instead of

TYPES multiple_use type abap_bool.

then

TYPES: BEGIN OF ENUM use,
  single   VALUE 'single',
  multiple VALUE 'multiple',
END OF ENUM use

is an option to always have the value in the json, note how this makes it part of the type design, and not a special case in json handling

@larshp larshp changed the title JSON file format JSON file format, define how serialization should work Jul 8, 2021
@schneidermic0
Copy link
Contributor

Initial values are not rendered (only if the field is explicitly annotated by $required or $showAlways) see following sections in the specification document:

When #173 is merged, I think only the schema version question is open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants