From 07c3c461e0a9c6a2d8e89cd3df106bf3e208c6de Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 5 Jan 2023 16:13:42 +0100 Subject: [PATCH 01/40] React to abaplint --- file-formats/sush/sush/README.md | 5 + file-formats/sush/sush/sush-v1.json | 228 ++++++++++++++++++ .../sush/sush/type/zif_aff_sush_v1.intf.abap | 106 ++++++++ .../sush/sush/type/zif_aff_sush_v1.intf.json | 7 + 4 files changed, 346 insertions(+) create mode 100644 file-formats/sush/sush/README.md create mode 100644 file-formats/sush/sush/sush-v1.json create mode 100644 file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap create mode 100644 file-formats/sush/sush/type/zif_aff_sush_v1.intf.json diff --git a/file-formats/sush/sush/README.md b/file-formats/sush/sush/README.md new file mode 100644 index 000000000..2617ca19e --- /dev/null +++ b/file-formats/sush/sush/README.md @@ -0,0 +1,5 @@ +# SUSH File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.sush.json` | 1 | [`zif_aff_sush_v1.intf.abap`](./type/zif_aff_sush_v1.intf.abap) | [`sush-v1.json`](./sush-v1.json) | [`z_aff_example_sush.sush.json`](./examples/z_aff_example_sush.sush.json) diff --git a/file-formats/sush/sush/sush-v1.json b/file-formats/sush/sush/sush-v1.json new file mode 100644 index 000000000..2d402287d --- /dev/null +++ b/file-formats/sush/sush/sush-v1.json @@ -0,0 +1,228 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/sush/sush-v1.json", + "title": "SUSH Object Type", + "description": "Object type SUSH", + "type": "object", + "properties": { + "formatVersion": { + "title": "ABAP File Format Version", + "description": "The ABAP file format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2, + "maxLength": 2, + "pattern": "^[a-z]+$" + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "keyUser", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP for Key Users", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP for key user extensibility", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "general": { + "title": "General", + "description": "General", + "type": "object", + "properties": { + "name": { + "title": "Application Name", + "description": "Application Name of Authorization Default Value.", + "type": "string", + "maxLength": 30 + }, + "type": { + "title": "Type", + "description": "Type of Authorization Default Value.", + "type": "string", + "enum": [ + "transaction", + "?", + "rfcFunctionModule", + "hashValueForTadirObject", + "hashValueForExternalService", + "collisionHashValue" + ], + "enumDescriptions": [ + "Transaction", + "?", + "RFC Function Module", + "Hash Value for TADIR Object", + "Hash Value for External Service", + "Collision Hash Value" + ] + }, + "okflag": { + "title": "Maintenance Mode", + "description": "Maintenance Mode.", + "type": "string", + "enum": [ + "manualMaintenance", + "automaticMaintenance(allAuthorizationObjects)", + "automaticMaintenance(basisAuthorizationObjectsOnly)", + "applicationDoesNotRequireDefaultValues", + "applicationIsDeprecated", + "applicationIsObsolete" + ], + "enumDescriptions": [ + "Manual Maintenance", + "Automatic Maintenance (All Authorization Objects)", + "Automatic Maintenance (Basis Authorization Objects Only)", + "Application Does Not Require Default Values", + "Application is Deprecated", + "Application Is Obsolete" + ] + } + }, + "additionalProperties": false, + "required": [ + "name", + "type", + "okflag" + ] + }, + "authorizationObjects": { + "title": "Authorization objects", + "description": "Authorization objects", + "type": "array", + "items": { + "title": "Authorization Objects Details", + "description": "Authorization Objects Details", + "type": "object", + "properties": { + "object": { + "title": "Object", + "description": "Name of Authorization Object", + "type": "string", + "maxLength": 10 + }, + "ttext": { + "title": "Object Description", + "description": "Authorization Object Description", + "type": "string", + "maxLength": 60 + }, + "okflag": { + "title": "Maintenance Status", + "description": "Maintenance Status", + "type": "string", + "enum": [ + "noAuthorizationCheck", + "authorizationCheckTakesPlace", + "undefined", + "authorizationCheckTakesPlace;DefaultValuesInUsobt", + "undefined", + "authorizationCheckTakesPlace,NoDefaultValues", + "inactiveAuthorizationDefault" + ], + "enumDescriptions": [ + "No authorization check", + "Authorization check takes place", + "Undefined", + "Authorization check takes place; default values in USOBT", + "Undefined", + "Authorization check takes place, no default values", + "Inactive Authorization Default" + ] + }, + "fields": { + "title": "Fields", + "description": "Authorization Fields.", + "type": "array", + "items": { + "title": "Authorization Field Details", + "description": "Authorization Field Details", + "type": "object", + "properties": { + "field": { + "title": "Field", + "description": "Name of Authorization Field", + "type": "string", + "maxLength": 10 + }, + "values": { + "title": "Values", + "description": "Name of Authorization Field Value", + "type": "array", + "items": { + "title": "Default Authorization Values", + "description": "Default Authorization Values", + "type": "object", + "properties": { + "low": { + "title": "From", + "description": "From Value", + "type": "string", + "maxLength": 40 + }, + "high": { + "title": "To", + "description": "To Values", + "type": "string", + "maxLength": 40 + } + }, + "additionalProperties": false + } + } + }, + "additionalProperties": false, + "required": [ + "field" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "object" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header", + "general" + ] +} diff --git a/file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap b/file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap new file mode 100644 index 000000000..bb3ffa0a2 --- /dev/null +++ b/file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap @@ -0,0 +1,106 @@ +interface zif_aff_sush_v1 + public . + types: + "!

General

+ "! General + "! $required + begin of ty_general, + "!

Application Name

+ "! Application Name of Authorization Default Value. + "! $required + name type usobx-name, + "!

Type

+ "! Type of Authorization Default Value. + "! $required + type type usobx-type, + "!

Maintenance Mode

+ "! Maintenance Mode. + "! $required + okflag type usob_status_flag, + end of ty_general . + + types: + "!

Default Authorization Values

+ "! Default Authorization Values + begin of ty_value, + "!

From

+ "! From Value + "! $showAlways + low type usobt-low, + "!

To

+ "! To Values + "! $showAlways + high type usobt-high, + end of ty_value . + + types: + "!

Authorization Fields

+ "! Authorization Fields + ty_values type standard table of ty_value with default key. + + types: + "!

Authorization Field Details

+ "! Authorization Field Details + begin of ty_fldtablestruc, + "!

Field

+ "! Name of Authorization Field + "! $required + field type usobt-field, + "!

Values

+ "! Name of Authorization Field Value + values type ty_values, + end of ty_fldtablestruc . + + types: + "!

Authorization Fields

+ "! Authorization Fields + ty_authorization_fields type standard table of ty_fldtablestruc with default key. + + types: + "!

Authorization Objects Details

+ "! Authorization Objects Details + begin of ty_objtablestruc, + "!

Object

+ "! Name of Authorization Object + "! $required + object type usobx-object, + "!

Object Description

+ "! Authorization Object Description + "! $showAlways + ttext type tobjt-ttext, + "!

Maintenance Status

+ "! Maintenance Status + "! $showAlways + okflag type usobx-okflag, + "!

Fields

+ "! Authorization Fields. + "! $showAlways + fields type ty_authorization_fields, + + end of ty_objtablestruc . + + types: + "!

Authorization Objects

+ "! Authorization Objects + ty_authorization_objects type standard table of ty_objtablestruc with default key. + + types: + "!

SUSH Object Type

+ "! Object type SUSH + begin of ty_main, + "! $required + format_version type zif_aff_types_v1=>ty_format_version, + "!

Header

+ "! Header + "! $required + header type zif_aff_types_v1=>ty_header_60_src, + "!

General

+ "! General + "! $required + general type ty_general, + "!

Authorization objects

+ "! Authorization objects + authorization_objects type ty_authorization_objects, + end of ty_main . + +endinterface. diff --git a/file-formats/sush/sush/type/zif_aff_sush_v1.intf.json b/file-formats/sush/sush/type/zif_aff_sush_v1.intf.json new file mode 100644 index 000000000..920811c45 --- /dev/null +++ b/file-formats/sush/sush/type/zif_aff_sush_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "Authentication Default Values AFF", + "originalLanguage": "en" + } +} From 7f18e677a76c334ca0faf2031ead9b372b6ec03f Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 25 Apr 2023 14:36:20 +0200 Subject: [PATCH 02/40] Add files for SUSI --- file-formats/susi/README.md | 5 + file-formats/susi/susi-v1.json | 216 ++++++++++++++++++ .../susi/type/zif_aff_susi_v1.intf.abap | 175 ++++++++++++++ .../susi/type/zif_aff_susi_v1.intf.json | 7 + 4 files changed, 403 insertions(+) create mode 100644 file-formats/susi/README.md create mode 100644 file-formats/susi/susi-v1.json create mode 100644 file-formats/susi/type/zif_aff_susi_v1.intf.abap create mode 100644 file-formats/susi/type/zif_aff_susi_v1.intf.json diff --git a/file-formats/susi/README.md b/file-formats/susi/README.md new file mode 100644 index 000000000..b2ff60673 --- /dev/null +++ b/file-formats/susi/README.md @@ -0,0 +1,5 @@ +# SUSI File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`zaff_example_susi.susi.json`](./examples/zaff_example_susi.susi.json) diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json new file mode 100644 index 000000000..3895ca56e --- /dev/null +++ b/file-formats/susi/susi-v1.json @@ -0,0 +1,216 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/susi/susi-v1.json", + "title": "SUSH Object Type", + "description": "Object type SUSH", + "type": "object", + "properties": { + "formatVersion": { + "title": "ABAP File Format Version", + "description": "The ABAP file format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2, + "maxLength": 2, + "pattern": "^[a-z]+$" + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "keyUser", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP for Key Users", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP for key user extensibility", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "general": { + "title": "General", + "description": "General", + "type": "object", + "properties": { + "applName": { + "title": "Application Name", + "description": "Application Name of Authorization Default Value.", + "type": "string", + "maxLength": 132 + }, + "type": { + "title": "Application Type", + "description": "Type of Authorization Default Value.", + "type": "string", + "maxLength": 80 + }, + "hashName": { + "title": "Technical Name (Hash Code)", + "description": "Technical Name (Hash Code).", + "type": "string", + "maxLength": 32 + }, + "maintenanceMode": { + "title": "Maintenance Mode", + "description": "Maintenance Mode.", + "type": "string", + "enum": [ + "manual", + "aFlag", + "bFlag", + "iFlag", + "dFlag", + "oFlag" + ], + "enumTitles": [ + "Manual Maintenance", + "Autom. Maintenance (All Objects)", + "Automatic Maintenance (Basis Authorization Objects Only)", + "Application Does Not Require Default Values", + "Application is Deprecated", + "Application Is Obsolete" + ], + "enumDescriptions": [ + "Manual Maintenance", + "Autom. Maintenance (All Objects)", + "Automatic Maintenance (Basis Authorization Objects Only)", + "Application Does Not Require Default Values", + "Application is Deprecated", + "Application Is Obsolete" + ] + } + }, + "additionalProperties": false, + "required": [ + "applName", + "type", + "hashName", + "maintenanceMode" + ] + }, + "authorizationObjects": { + "title": "Authorization objects", + "description": "Authorization objects", + "type": "array", + "items": { + "title": "Authorization Objects Details", + "description": "Authorization Objects Details", + "type": "object", + "properties": { + "object": { + "title": "Object", + "description": "Name of Authorization Object", + "type": "string", + "maxLength": 10 + }, + "maintenanceStatus": { + "title": "Maintenance Status", + "description": "Maintenance Status", + "type": "string", + "enum": [ + "xFlag", + "yFlag", + "vFlag", + "iFlag", + "uFlag", + "nFlag" + ], + "enumTitles": [ + "No Default", + "Default With Field Values", + "Default Without Field Values", + "Default Inactive", + "Unmaintained Object Status", + "Authorization Check Inactive" + ], + "enumDescriptions": [ + "No Default", + "Default With Field Values", + "Default Without Field Values", + "Default Inactive", + "Unmaintained Object Status", + "Authorization Check Inactive" + ], + "default": "yFlag" + }, + "fields": { + "title": "Fields", + "description": "Authorization Fields.", + "type": "array", + "items": { + "title": "Authorization Field Details", + "description": "Authorization Field Details", + "type": "object", + "properties": { + "field": { + "title": "Field", + "description": "Name of Authorization Field", + "type": "string", + "maxLength": 10 + }, + "low": { + "title": "From", + "description": "From Value", + "type": "string", + "maxLength": 40 + }, + "high": { + "title": "To", + "description": "To Values", + "type": "string", + "maxLength": 40 + } + }, + "additionalProperties": false, + "required": [ + "field" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "object" + ] + } + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header", + "general" + ] +} diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap new file mode 100644 index 000000000..02805c233 --- /dev/null +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -0,0 +1,175 @@ +INTERFACE zif_aff_susi_v1 + PUBLIC . + + TYPES: + "!

Maintenance Mode

+ "! Maintenance Mode + "! $values {@link if_aff_sush_v1.data:co_maintenance_mode} + ty_maintenance_mode TYPE c LENGTH 1, + "!

Maintenance Status

+ "! Maintenance Status + "! $values {@link if_aff_sush_v1.data:co_maintenance_status} + "! $default {@link if_aff_sush_v1.data:co_maintenance_status.y_flag} + ty_maintenance_status TYPE c LENGTH 1. + + CONSTANTS: + "!

Maintenance Mode

+ "! Maintenance Mode + BEGIN OF co_maintenance_mode, + "!

Manual Maintenance

+ "! Manual Maintenance + manual TYPE ty_maintenance_mode VALUE space, + "!

Autom. Maintenance (All Objects)

+ "! Autom. Maintenance (All Objects) + a_flag TYPE ty_maintenance_mode VALUE 'A', + "!

Automatic Maintenance (Basis Authorization Objects Only)

+ "! Automatic Maintenance (Basis Authorization Objects Only) + b_flag TYPE ty_maintenance_mode VALUE 'B', + "!

Application Does Not Require Default Values

+ "! Application Does Not Require Default Values + i_flag TYPE ty_maintenance_mode VALUE 'I', + "!

Application is Deprecated

+ "! Application is Deprecated + d_flag TYPE ty_maintenance_mode VALUE 'D', + "!

Application Is Obsolete

+ "! Application Is Obsolete + o_flag TYPE ty_maintenance_mode VALUE 'O', + END OF co_maintenance_mode, + + "!

Maintenance Status

+ "! Maintenance Status + BEGIN OF co_maintenance_status, + "!

No Default

+ "! No Default + x_flag TYPE ty_maintenance_status VALUE 'X', + "!

Default With Field Values

+ "! Default With Field Values + y_flag TYPE ty_maintenance_status VALUE 'Y', + "!

Default Without Field Values

+ "! Default Without Field Values + v_flag TYPE ty_maintenance_status VALUE 'V', + "!

Default Inactive

+ "! Default Inactive + i_flag TYPE ty_maintenance_status VALUE 'I', + "!

Unmaintained Object Status

+ "! Unmaintained Object Status + u_flag TYPE ty_maintenance_status VALUE 'U', + "!

Authorization Check Inactive

+ "! Authorization Check Inactive + n_flag TYPE ty_maintenance_status VALUE 'N', + END OF co_maintenance_status. + + TYPES: + "!

Application Name

+ "! Name of Application + ty_appl_name TYPE c LENGTH 132, + "!

Hash value

+ "! Hash Values for an Application's Auth. Default Values + ty_hash_name TYPE c LENGTH 32, + "!

Application Type

+ "! Type of Application + ty_type TYPE c LENGTH 80. + + TYPES: + "!

General

+ "! General + "! $required + BEGIN OF ty_general, + "!

Application Name

+ "! Application Name of Authorization Default Value. + "! $required + appl_name TYPE ty_appl_name, + "!

Application Type

+ "! Type of Authorization Default Value. + "! $required + type TYPE ty_type, + "!

Technical Name (Hash Code)

+ "! Technical Name (Hash Code). + "! $required + hash_name TYPE ty_hash_name, + "!

Maintenance Mode

+ "! Maintenance Mode. + "! $values {@link if_aff_sush_v1.data:co_maintenance_mode} + "! $required + maintenance_mode TYPE ty_maintenance_mode, + END OF ty_general . + + TYPES: + "!

Authorization Value

+ "! Authorization Value + ty_val TYPE c LENGTH 40. + + TYPES: + "!

Authorization Field

+ "! Authorization Field + ty_field TYPE c LENGTH 10. + + TYPES: + "!

Authorization Field Details

+ "! Authorization Field Details + BEGIN OF ty_authorization_field, + "!

Field

+ "! Name of Authorization Field + "! $required + field TYPE ty_field, + "!

From

+ "! From Value + "! $showAlways + low TYPE ty_val, + "!

To

+ "! To Values + "! $showAlways + high TYPE ty_val, + END OF ty_authorization_field . + + TYPES: + "!

Authorization Fields

+ "! Authorization Fields + ty_authorization_fields TYPE STANDARD TABLE OF ty_authorization_field WITH DEFAULT KEY. + + TYPES: + "!

Authorization Objects Details

+ "! Authorization Objects Details + BEGIN OF ty_authorization_object, + "!

Object

+ "! Name of Authorization Object + "! $required + object TYPE c LENGTH 10, + "!

Maintenance Status

+ "! Maintenance Status + "! $values {@link if_aff_sush_v1.data:co_maintenance_status} + "! $default {@link if_aff_sush_v1.data:co_maintenance_status.y_flag} + "! $showAlways + maintenance_status TYPE ty_maintenance_status, + "!

Fields

+ "! Authorization Fields. + "! $showAlways + fields TYPE ty_authorization_fields, + + END OF ty_authorization_object . + + TYPES: + "!

Authorization Objects

+ "! Authorization Objects + ty_authorization_objects TYPE STANDARD TABLE OF ty_authorization_object WITH DEFAULT KEY. + + TYPES: + "!

SUSH Object Type

+ "! Object type SUSH + BEGIN OF ty_main, + "! $required + format_version TYPE zif_aff_types_v1=>ty_format_version, + "!

Header

+ "! Header + "! $required + header TYPE zif_aff_types_v1=>ty_header_60_src, + "!

General

+ "! General + "! $required + general TYPE ty_general, + "!

Authorization objects

+ "! Authorization objects + authorization_objects TYPE ty_authorization_objects, + END OF ty_main . + +ENDINTERFACE. diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.json b/file-formats/susi/type/zif_aff_susi_v1.intf.json new file mode 100644 index 000000000..920811c45 --- /dev/null +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "Authentication Default Values AFF", + "originalLanguage": "en" + } +} From d85ca27e5727cd8fe2e427c044b03b9d533608b0 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 25 Apr 2023 15:52:44 +0200 Subject: [PATCH 03/40] remove SUSH files --- file-formats/sush/sush/README.md | 5 - file-formats/sush/sush/sush-v1.json | 228 ------------------ .../sush/sush/type/zif_aff_sush_v1.intf.abap | 106 -------- .../sush/sush/type/zif_aff_sush_v1.intf.json | 7 - 4 files changed, 346 deletions(-) delete mode 100644 file-formats/sush/sush/README.md delete mode 100644 file-formats/sush/sush/sush-v1.json delete mode 100644 file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap delete mode 100644 file-formats/sush/sush/type/zif_aff_sush_v1.intf.json diff --git a/file-formats/sush/sush/README.md b/file-formats/sush/sush/README.md deleted file mode 100644 index 2617ca19e..000000000 --- a/file-formats/sush/sush/README.md +++ /dev/null @@ -1,5 +0,0 @@ -# SUSH File Format - -File | Cardinality | Definition | Schema | Example -:--- | :--- | :--- | :--- | :--- -`.sush.json` | 1 | [`zif_aff_sush_v1.intf.abap`](./type/zif_aff_sush_v1.intf.abap) | [`sush-v1.json`](./sush-v1.json) | [`z_aff_example_sush.sush.json`](./examples/z_aff_example_sush.sush.json) diff --git a/file-formats/sush/sush/sush-v1.json b/file-formats/sush/sush/sush-v1.json deleted file mode 100644 index 2d402287d..000000000 --- a/file-formats/sush/sush/sush-v1.json +++ /dev/null @@ -1,228 +0,0 @@ -{ - "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", - "$schema": "https://json-schema.org/draft/2020-12/schema", - "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/sush/sush-v1.json", - "title": "SUSH Object Type", - "description": "Object type SUSH", - "type": "object", - "properties": { - "formatVersion": { - "title": "ABAP File Format Version", - "description": "The ABAP file format version", - "type": "string", - "const": "1" - }, - "header": { - "title": "Header", - "description": "Header", - "type": "object", - "properties": { - "description": { - "title": "Description", - "description": "Description of the ABAP object", - "type": "string", - "maxLength": 60 - }, - "originalLanguage": { - "title": "Original Language", - "description": "Original language of the ABAP object", - "type": "string", - "minLength": 2, - "maxLength": 2, - "pattern": "^[a-z]+$" - }, - "abapLanguageVersion": { - "title": "ABAP Language Version", - "description": "ABAP language version", - "type": "string", - "enum": [ - "standard", - "keyUser", - "cloudDevelopment" - ], - "enumTitles": [ - "Standard", - "ABAP for Key Users", - "ABAP Cloud Development" - ], - "enumDescriptions": [ - "Standard", - "ABAP for key user extensibility", - "ABAP cloud development" - ], - "default": "standard" - } - }, - "additionalProperties": false, - "required": [ - "description", - "originalLanguage" - ] - }, - "general": { - "title": "General", - "description": "General", - "type": "object", - "properties": { - "name": { - "title": "Application Name", - "description": "Application Name of Authorization Default Value.", - "type": "string", - "maxLength": 30 - }, - "type": { - "title": "Type", - "description": "Type of Authorization Default Value.", - "type": "string", - "enum": [ - "transaction", - "?", - "rfcFunctionModule", - "hashValueForTadirObject", - "hashValueForExternalService", - "collisionHashValue" - ], - "enumDescriptions": [ - "Transaction", - "?", - "RFC Function Module", - "Hash Value for TADIR Object", - "Hash Value for External Service", - "Collision Hash Value" - ] - }, - "okflag": { - "title": "Maintenance Mode", - "description": "Maintenance Mode.", - "type": "string", - "enum": [ - "manualMaintenance", - "automaticMaintenance(allAuthorizationObjects)", - "automaticMaintenance(basisAuthorizationObjectsOnly)", - "applicationDoesNotRequireDefaultValues", - "applicationIsDeprecated", - "applicationIsObsolete" - ], - "enumDescriptions": [ - "Manual Maintenance", - "Automatic Maintenance (All Authorization Objects)", - "Automatic Maintenance (Basis Authorization Objects Only)", - "Application Does Not Require Default Values", - "Application is Deprecated", - "Application Is Obsolete" - ] - } - }, - "additionalProperties": false, - "required": [ - "name", - "type", - "okflag" - ] - }, - "authorizationObjects": { - "title": "Authorization objects", - "description": "Authorization objects", - "type": "array", - "items": { - "title": "Authorization Objects Details", - "description": "Authorization Objects Details", - "type": "object", - "properties": { - "object": { - "title": "Object", - "description": "Name of Authorization Object", - "type": "string", - "maxLength": 10 - }, - "ttext": { - "title": "Object Description", - "description": "Authorization Object Description", - "type": "string", - "maxLength": 60 - }, - "okflag": { - "title": "Maintenance Status", - "description": "Maintenance Status", - "type": "string", - "enum": [ - "noAuthorizationCheck", - "authorizationCheckTakesPlace", - "undefined", - "authorizationCheckTakesPlace;DefaultValuesInUsobt", - "undefined", - "authorizationCheckTakesPlace,NoDefaultValues", - "inactiveAuthorizationDefault" - ], - "enumDescriptions": [ - "No authorization check", - "Authorization check takes place", - "Undefined", - "Authorization check takes place; default values in USOBT", - "Undefined", - "Authorization check takes place, no default values", - "Inactive Authorization Default" - ] - }, - "fields": { - "title": "Fields", - "description": "Authorization Fields.", - "type": "array", - "items": { - "title": "Authorization Field Details", - "description": "Authorization Field Details", - "type": "object", - "properties": { - "field": { - "title": "Field", - "description": "Name of Authorization Field", - "type": "string", - "maxLength": 10 - }, - "values": { - "title": "Values", - "description": "Name of Authorization Field Value", - "type": "array", - "items": { - "title": "Default Authorization Values", - "description": "Default Authorization Values", - "type": "object", - "properties": { - "low": { - "title": "From", - "description": "From Value", - "type": "string", - "maxLength": 40 - }, - "high": { - "title": "To", - "description": "To Values", - "type": "string", - "maxLength": 40 - } - }, - "additionalProperties": false - } - } - }, - "additionalProperties": false, - "required": [ - "field" - ] - } - } - }, - "additionalProperties": false, - "required": [ - "object" - ] - } - } - }, - "additionalProperties": false, - "required": [ - "formatVersion", - "header", - "general" - ] -} diff --git a/file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap b/file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap deleted file mode 100644 index bb3ffa0a2..000000000 --- a/file-formats/sush/sush/type/zif_aff_sush_v1.intf.abap +++ /dev/null @@ -1,106 +0,0 @@ -interface zif_aff_sush_v1 - public . - types: - "!

General

- "! General - "! $required - begin of ty_general, - "!

Application Name

- "! Application Name of Authorization Default Value. - "! $required - name type usobx-name, - "!

Type

- "! Type of Authorization Default Value. - "! $required - type type usobx-type, - "!

Maintenance Mode

- "! Maintenance Mode. - "! $required - okflag type usob_status_flag, - end of ty_general . - - types: - "!

Default Authorization Values

- "! Default Authorization Values - begin of ty_value, - "!

From

- "! From Value - "! $showAlways - low type usobt-low, - "!

To

- "! To Values - "! $showAlways - high type usobt-high, - end of ty_value . - - types: - "!

Authorization Fields

- "! Authorization Fields - ty_values type standard table of ty_value with default key. - - types: - "!

Authorization Field Details

- "! Authorization Field Details - begin of ty_fldtablestruc, - "!

Field

- "! Name of Authorization Field - "! $required - field type usobt-field, - "!

Values

- "! Name of Authorization Field Value - values type ty_values, - end of ty_fldtablestruc . - - types: - "!

Authorization Fields

- "! Authorization Fields - ty_authorization_fields type standard table of ty_fldtablestruc with default key. - - types: - "!

Authorization Objects Details

- "! Authorization Objects Details - begin of ty_objtablestruc, - "!

Object

- "! Name of Authorization Object - "! $required - object type usobx-object, - "!

Object Description

- "! Authorization Object Description - "! $showAlways - ttext type tobjt-ttext, - "!

Maintenance Status

- "! Maintenance Status - "! $showAlways - okflag type usobx-okflag, - "!

Fields

- "! Authorization Fields. - "! $showAlways - fields type ty_authorization_fields, - - end of ty_objtablestruc . - - types: - "!

Authorization Objects

- "! Authorization Objects - ty_authorization_objects type standard table of ty_objtablestruc with default key. - - types: - "!

SUSH Object Type

- "! Object type SUSH - begin of ty_main, - "! $required - format_version type zif_aff_types_v1=>ty_format_version, - "!

Header

- "! Header - "! $required - header type zif_aff_types_v1=>ty_header_60_src, - "!

General

- "! General - "! $required - general type ty_general, - "!

Authorization objects

- "! Authorization objects - authorization_objects type ty_authorization_objects, - end of ty_main . - -endinterface. diff --git a/file-formats/sush/sush/type/zif_aff_sush_v1.intf.json b/file-formats/sush/sush/type/zif_aff_sush_v1.intf.json deleted file mode 100644 index 920811c45..000000000 --- a/file-formats/sush/sush/type/zif_aff_sush_v1.intf.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "formatVersion": "1", - "header": { - "description": "Authentication Default Values AFF", - "originalLanguage": "en" - } -} From 5868dbb4663899e9521b38eb9231a470ac208d02 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 25 Apr 2023 16:05:16 +0200 Subject: [PATCH 04/40] Add example SUSI --- .../susi/examples/zaff_example_susi.susi.json | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 file-formats/susi/examples/zaff_example_susi.susi.json diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json new file mode 100644 index 000000000..ec6679992 --- /dev/null +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -0,0 +1,44 @@ +{ + "formatVersion": "1", + "header": { + "description": "Example SUSI object", + "originalLanguage": "en", + "abapLanguageVersion": "standard" + }, + "general": { + "applName": "Z_FEM3/Z_FEM3_GET_INFO", + "type": "WebService", + "name": "D2FF3796C3963799AE24F0224FCD96HS", + "maintenanceMode": "manual" + }, + "authorizationObjects": [ + { + "object": "S_USER_AGR", + "maintenanceStatus": "yFlag", + "fields": [ + { + "field": "ACTVT", + "low": "02" + }, + { + "field": "ACTVT", + "low": "03" + } + ] + }, + { + "object": "S_USER_GRP", + "maintenanceStatus": "yFlag", + "fields": [ + { + "field": "ACTVT", + "low": "03" + }, + { + "field": "CLASS", + "low": "TEST" + } + ] + } + ] +} From f4ac142e22a290a9a9155706f6e5a1593059b957 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 25 Apr 2023 16:16:27 +0200 Subject: [PATCH 05/40] Correct SUSI --- file-formats/susi/susi-v1.json | 4 +-- .../susi/type/zif_aff_susi_v1.intf.abap | 26 +++++++++---------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index 3895ca56e..db31e3257 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -2,8 +2,8 @@ "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", "$schema": "https://json-schema.org/draft/2020-12/schema", "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/susi/susi-v1.json", - "title": "SUSH Object Type", - "description": "Object type SUSH", + "title": "SUSI Object Type", + "description": "Object type SUSI", "type": "object", "properties": { "formatVersion": { diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index 02805c233..b62c793c7 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -1,15 +1,15 @@ INTERFACE zif_aff_susi_v1 - PUBLIC . + PUBLIC. TYPES: "!

Maintenance Mode

"! Maintenance Mode - "! $values {@link if_aff_sush_v1.data:co_maintenance_mode} + "! $values {@link if_aff_susi_v1.data:co_maintenance_mode} ty_maintenance_mode TYPE c LENGTH 1, "!

Maintenance Status

"! Maintenance Status - "! $values {@link if_aff_sush_v1.data:co_maintenance_status} - "! $default {@link if_aff_sush_v1.data:co_maintenance_status.y_flag} + "! $values {@link if_aff_susi_v1.data:co_maintenance_status} + "! $default {@link if_aff_susi_v1.data:co_maintenance_status.y_flag} ty_maintenance_status TYPE c LENGTH 1. CONSTANTS: @@ -89,10 +89,10 @@ INTERFACE zif_aff_susi_v1 hash_name TYPE ty_hash_name, "!

Maintenance Mode

"! Maintenance Mode. - "! $values {@link if_aff_sush_v1.data:co_maintenance_mode} + "! $values {@link if_aff_susi_v1.data:co_maintenance_mode} "! $required maintenance_mode TYPE ty_maintenance_mode, - END OF ty_general . + END OF ty_general. TYPES: "!

Authorization Value

@@ -120,7 +120,7 @@ INTERFACE zif_aff_susi_v1 "! To Values "! $showAlways high TYPE ty_val, - END OF ty_authorization_field . + END OF ty_authorization_field. TYPES: "!

Authorization Fields

@@ -137,8 +137,8 @@ INTERFACE zif_aff_susi_v1 object TYPE c LENGTH 10, "!

Maintenance Status

"! Maintenance Status - "! $values {@link if_aff_sush_v1.data:co_maintenance_status} - "! $default {@link if_aff_sush_v1.data:co_maintenance_status.y_flag} + "! $values {@link if_aff_susi_v1.data:co_maintenance_status} + "! $default {@link if_aff_susi_v1.data:co_maintenance_status.y_flag} "! $showAlways maintenance_status TYPE ty_maintenance_status, "!

Fields

@@ -146,7 +146,7 @@ INTERFACE zif_aff_susi_v1 "! $showAlways fields TYPE ty_authorization_fields, - END OF ty_authorization_object . + END OF ty_authorization_object. TYPES: "!

Authorization Objects

@@ -154,8 +154,8 @@ INTERFACE zif_aff_susi_v1 ty_authorization_objects TYPE STANDARD TABLE OF ty_authorization_object WITH DEFAULT KEY. TYPES: - "!

SUSH Object Type

- "! Object type SUSH + "!

SUSI Object Type

+ "! Object type SUSI BEGIN OF ty_main, "! $required format_version TYPE zif_aff_types_v1=>ty_format_version, @@ -170,6 +170,6 @@ INTERFACE zif_aff_susi_v1 "!

Authorization objects

"! Authorization objects authorization_objects TYPE ty_authorization_objects, - END OF ty_main . + END OF ty_main. ENDINTERFACE. From 3267b48601f19fee4edef4ffaaa24c184b79d23a Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 08:56:03 +0200 Subject: [PATCH 06/40] Correct exaple --- file-formats/susi/examples/zaff_example_susi.susi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index ec6679992..fb862dae5 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -8,7 +8,7 @@ "general": { "applName": "Z_FEM3/Z_FEM3_GET_INFO", "type": "WebService", - "name": "D2FF3796C3963799AE24F0224FCD96HS", + "hash_name": "D2FF3796C3963799AE24F0224FCD96HS", "maintenanceMode": "manual" }, "authorizationObjects": [ From be2d2463aa36e3e23b927cdd6bc7a5179bc816bf Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 09:15:56 +0200 Subject: [PATCH 07/40] correct example --- .../susi/examples/zaff_example_susi.susi.json | 26 +++---------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index fb862dae5..ae42240dd 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -8,37 +8,17 @@ "general": { "applName": "Z_FEM3/Z_FEM3_GET_INFO", "type": "WebService", - "hash_name": "D2FF3796C3963799AE24F0224FCD96HS", + "hashName": "D2FF3796C3963799AE24F0224FCD96HS", "maintenanceMode": "manual" }, "authorizationObjects": [ { "object": "S_USER_AGR", - "maintenanceStatus": "yFlag", - "fields": [ - { - "field": "ACTVT", - "low": "02" - }, - { - "field": "ACTVT", - "low": "03" - } - ] + "maintenanceStatus": "yFlag" }, { "object": "S_USER_GRP", - "maintenanceStatus": "yFlag", - "fields": [ - { - "field": "ACTVT", - "low": "03" - }, - { - "field": "CLASS", - "low": "TEST" - } - ] + "maintenanceStatus": "xFlag" } ] } From 9bdf29674018526f6abf87ff2be163e927a9a5cd Mon Sep 17 00:00:00 2001 From: Katharina Wurz Date: Wed, 26 Apr 2023 10:14:56 +0200 Subject: [PATCH 08/40] Change line ending --- .../susi/examples/zaff_example_susi.susi.json | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index ae42240dd..f7ddf0cce 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -1,24 +1,24 @@ -{ - "formatVersion": "1", - "header": { - "description": "Example SUSI object", - "originalLanguage": "en", - "abapLanguageVersion": "standard" - }, - "general": { - "applName": "Z_FEM3/Z_FEM3_GET_INFO", - "type": "WebService", - "hashName": "D2FF3796C3963799AE24F0224FCD96HS", - "maintenanceMode": "manual" - }, - "authorizationObjects": [ - { - "object": "S_USER_AGR", - "maintenanceStatus": "yFlag" - }, - { - "object": "S_USER_GRP", - "maintenanceStatus": "xFlag" - } - ] -} +{ + "formatVersion": "1", + "header": { + "description": "Example SUSI object", + "originalLanguage": "en", + "abapLanguageVersion": "standard" + }, + "general": { + "applName": "Z_FEM3/Z_FEM3_GET_INFO", + "type": "WebService", + "hashName": "D2FF3796C3963799AE24F0224FCD96HS", + "maintenanceMode": "manual" + }, + "authorizationObjects": [ + { + "object": "S_USER_AGR", + "maintenanceStatus": "yFlag" + }, + { + "object": "S_USER_GRP", + "maintenanceStatus": "xFlag" + } + ] +} From 5d442d62bd51c8323ad9a6f160f145cd486d02f1 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 16:20:19 +0200 Subject: [PATCH 09/40] Update file-formats/susi/type/zif_aff_susi_v1.intf.abap Co-authored-by: Katharina Wurz --- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index b62c793c7..b3e5ab988 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -4,7 +4,7 @@ INTERFACE zif_aff_susi_v1 TYPES: "!

Maintenance Mode

"! Maintenance Mode - "! $values {@link if_aff_susi_v1.data:co_maintenance_mode} + "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} ty_maintenance_mode TYPE c LENGTH 1, "!

Maintenance Status

"! Maintenance Status From 4576220b59fdb15dab81aea39bc5bd328225c461 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 16:20:26 +0200 Subject: [PATCH 10/40] Update file-formats/susi/type/zif_aff_susi_v1.intf.abap Co-authored-by: Katharina Wurz --- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index b3e5ab988..1c12df885 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -8,7 +8,7 @@ INTERFACE zif_aff_susi_v1 ty_maintenance_mode TYPE c LENGTH 1, "!

Maintenance Status

"! Maintenance Status - "! $values {@link if_aff_susi_v1.data:co_maintenance_status} + "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} "! $default {@link if_aff_susi_v1.data:co_maintenance_status.y_flag} ty_maintenance_status TYPE c LENGTH 1. From 9b9abd10a0a6483d2e048f4af99244db7fb0099f Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 16:20:36 +0200 Subject: [PATCH 11/40] Update file-formats/susi/type/zif_aff_susi_v1.intf.abap Co-authored-by: Katharina Wurz --- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index 1c12df885..cce3b037d 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -9,7 +9,7 @@ INTERFACE zif_aff_susi_v1 "!

Maintenance Status

"! Maintenance Status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} - "! $default {@link if_aff_susi_v1.data:co_maintenance_status.y_flag} + "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.y_flag} ty_maintenance_status TYPE c LENGTH 1. CONSTANTS: From 01db33139a87af484b2bb348900678c675b728a2 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 16:20:43 +0200 Subject: [PATCH 12/40] Update file-formats/susi/type/zif_aff_susi_v1.intf.abap Co-authored-by: Katharina Wurz --- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index cce3b037d..607e5b263 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -137,7 +137,7 @@ INTERFACE zif_aff_susi_v1 object TYPE c LENGTH 10, "!

Maintenance Status

"! Maintenance Status - "! $values {@link if_aff_susi_v1.data:co_maintenance_status} + "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} "! $default {@link if_aff_susi_v1.data:co_maintenance_status.y_flag} "! $showAlways maintenance_status TYPE ty_maintenance_status, From 9036dfe2ab5346e35cc9e2e12f88e9b92f8db494 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Apr 2023 16:20:51 +0200 Subject: [PATCH 13/40] Update file-formats/susi/type/zif_aff_susi_v1.intf.abap Co-authored-by: Katharina Wurz --- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index 607e5b263..d75b0eccd 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -138,7 +138,7 @@ INTERFACE zif_aff_susi_v1 "!

Maintenance Status

"! Maintenance Status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} - "! $default {@link if_aff_susi_v1.data:co_maintenance_status.y_flag} + "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.y_flag} "! $showAlways maintenance_status TYPE ty_maintenance_status, "!

Fields

From 57b3247a0c0e249e818a5ff283ed7c80ccd5334d Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 27 Apr 2023 08:46:17 +0200 Subject: [PATCH 14/40] Update file-formats/susi/examples/zaff_example_susi.susi.json Co-authored-by: Michael Schneider --- file-formats/susi/examples/zaff_example_susi.susi.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index f7ddf0cce..38ab8d899 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -2,8 +2,7 @@ "formatVersion": "1", "header": { "description": "Example SUSI object", - "originalLanguage": "en", - "abapLanguageVersion": "standard" + "originalLanguage": "en" }, "general": { "applName": "Z_FEM3/Z_FEM3_GET_INFO", From 5388f3790730a98dee5ddfa6ebddd286b9a73b07 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 27 Apr 2023 08:46:31 +0200 Subject: [PATCH 15/40] Update file-formats/susi/examples/zaff_example_susi.susi.json Co-authored-by: Michael Schneider --- file-formats/susi/examples/zaff_example_susi.susi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index 38ab8d899..88e4b0a6e 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -4,7 +4,7 @@ "description": "Example SUSI object", "originalLanguage": "en" }, - "general": { + "generalInformation": { "applName": "Z_FEM3/Z_FEM3_GET_INFO", "type": "WebService", "hashName": "D2FF3796C3963799AE24F0224FCD96HS", From 46da6bf4cfbed238558e6bf3409aa4d34628c658 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Mon, 8 May 2023 11:16:12 +0200 Subject: [PATCH 16/40] set maintenance Status for example --- file-formats/susi/examples/zaff_example_susi.susi.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index 88e4b0a6e..daa8b233c 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -13,11 +13,11 @@ "authorizationObjects": [ { "object": "S_USER_AGR", - "maintenanceStatus": "yFlag" + "maintenanceStatus": "defaultWithValues" }, { "object": "S_USER_GRP", - "maintenanceStatus": "xFlag" + "maintenanceStatus": "noDefault" } ] } From 6d00ed876036f225638f4337bbd3de475736e1ed Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 9 May 2023 11:42:37 +0200 Subject: [PATCH 17/40] AFF and example correction --- .../susi/examples/zaff_example_susi.susi.json | 34 ++++++++++++++---- file-formats/susi/susi-v1.json | 36 +++++++++---------- .../susi/type/zif_aff_susi_v1.intf.abap | 34 +++++++++--------- 3 files changed, 62 insertions(+), 42 deletions(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index daa8b233c..7427c3df6 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -1,23 +1,43 @@ { "formatVersion": "1", "header": { - "description": "Example SUSI object", + "description": "SUSI Testobject", "originalLanguage": "en" }, - "generalInformation": { - "applName": "Z_FEM3/Z_FEM3_GET_INFO", - "type": "WebService", - "hashName": "D2FF3796C3963799AE24F0224FCD96HS", + "general": { + "applicationName": "Z_FEM3/Z_FEM3_GET_INFO", + "applicationType": "WebService", + "hashCode": "D2FF3796C3963799AE24F0224FCD96HS", "maintenanceMode": "manual" }, "authorizationObjects": [ { "object": "S_USER_AGR", - "maintenanceStatus": "defaultWithValues" + "maintenanceStatus": "defaultWithValues", + "fields": [ + { + "field": "ACTVT", + "low": "02" + }, + { + "field": "ACTVT", + "low": "03" + } + ] }, { "object": "S_USER_GRP", - "maintenanceStatus": "noDefault" + "maintenanceStatus": "noDefault", + "fields": [ + { + "field": "ACTVT", + "low": "03" + }, + { + "field": "CLASS", + "low": "TEST" + } + ] } ] } diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index db31e3257..7504eafe7 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -64,19 +64,19 @@ "description": "General", "type": "object", "properties": { - "applName": { + "applicationName": { "title": "Application Name", "description": "Application Name of Authorization Default Value.", "type": "string", "maxLength": 132 }, - "type": { + "applicationType": { "title": "Application Type", "description": "Type of Authorization Default Value.", "type": "string", "maxLength": 80 }, - "hashName": { + "hashCode": { "title": "Technical Name (Hash Code)", "description": "Technical Name (Hash Code).", "type": "string", @@ -88,11 +88,11 @@ "type": "string", "enum": [ "manual", - "aFlag", - "bFlag", - "iFlag", - "dFlag", - "oFlag" + "allObject", + "basicObject", + "noDefaultValues", + "deprecated", + "obsolete" ], "enumTitles": [ "Manual Maintenance", @@ -114,9 +114,9 @@ }, "additionalProperties": false, "required": [ - "applName", - "type", - "hashName", + "applicationName", + "applicationType", + "hashCode", "maintenanceMode" ] }, @@ -140,12 +140,12 @@ "description": "Maintenance Status", "type": "string", "enum": [ - "xFlag", - "yFlag", - "vFlag", - "iFlag", - "uFlag", - "nFlag" + "noDefault", + "defaultWithValues", + "defaultWithoutValues", + "inactiveValues", + "unmaintainedValues", + "authorizaitonChechInactive" ], "enumTitles": [ "No Default", @@ -163,7 +163,7 @@ "Unmaintained Object Status", "Authorization Check Inactive" ], - "default": "yFlag" + "default": "defaultWithValues" }, "fields": { "title": "Fields", diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index d75b0eccd..765926fc2 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -9,7 +9,7 @@ INTERFACE zif_aff_susi_v1 "!

Maintenance Status

"! Maintenance Status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} - "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.y_flag} + "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.default_with_values} ty_maintenance_status TYPE c LENGTH 1. CONSTANTS: @@ -21,19 +21,19 @@ INTERFACE zif_aff_susi_v1 manual TYPE ty_maintenance_mode VALUE space, "!

Autom. Maintenance (All Objects)

"! Autom. Maintenance (All Objects) - a_flag TYPE ty_maintenance_mode VALUE 'A', + all_object TYPE ty_maintenance_mode VALUE 'A', "!

Automatic Maintenance (Basis Authorization Objects Only)

"! Automatic Maintenance (Basis Authorization Objects Only) - b_flag TYPE ty_maintenance_mode VALUE 'B', + basic_object TYPE ty_maintenance_mode VALUE 'B', "!

Application Does Not Require Default Values

"! Application Does Not Require Default Values - i_flag TYPE ty_maintenance_mode VALUE 'I', + no_default_values TYPE ty_maintenance_mode VALUE 'I', "!

Application is Deprecated

"! Application is Deprecated - d_flag TYPE ty_maintenance_mode VALUE 'D', + deprecated TYPE ty_maintenance_mode VALUE 'D', "!

Application Is Obsolete

"! Application Is Obsolete - o_flag TYPE ty_maintenance_mode VALUE 'O', + obsolete TYPE ty_maintenance_mode VALUE 'O', END OF co_maintenance_mode, "!

Maintenance Status

@@ -41,22 +41,22 @@ INTERFACE zif_aff_susi_v1 BEGIN OF co_maintenance_status, "!

No Default

"! No Default - x_flag TYPE ty_maintenance_status VALUE 'X', + no_default TYPE ty_maintenance_status VALUE 'X', "!

Default With Field Values

"! Default With Field Values - y_flag TYPE ty_maintenance_status VALUE 'Y', + default_with_values TYPE ty_maintenance_status VALUE 'Y', "!

Default Without Field Values

"! Default Without Field Values - v_flag TYPE ty_maintenance_status VALUE 'V', + default_without_values TYPE ty_maintenance_status VALUE 'V', "!

Default Inactive

"! Default Inactive - i_flag TYPE ty_maintenance_status VALUE 'I', + inactive_values TYPE ty_maintenance_status VALUE 'I', "!

Unmaintained Object Status

"! Unmaintained Object Status - u_flag TYPE ty_maintenance_status VALUE 'U', + unmaintained_values TYPE ty_maintenance_status VALUE 'U', "!

Authorization Check Inactive

"! Authorization Check Inactive - n_flag TYPE ty_maintenance_status VALUE 'N', + Authorizaiton_chech_inactive TYPE ty_maintenance_status VALUE 'N', END OF co_maintenance_status. TYPES: @@ -78,18 +78,18 @@ INTERFACE zif_aff_susi_v1 "!

Application Name

"! Application Name of Authorization Default Value. "! $required - appl_name TYPE ty_appl_name, + application_name TYPE ty_appl_name, "!

Application Type

"! Type of Authorization Default Value. "! $required - type TYPE ty_type, + application_type TYPE ty_type, "!

Technical Name (Hash Code)

"! Technical Name (Hash Code). "! $required - hash_name TYPE ty_hash_name, + hash_code TYPE ty_hash_name, "!

Maintenance Mode

"! Maintenance Mode. - "! $values {@link if_aff_susi_v1.data:co_maintenance_mode} + "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} "! $required maintenance_mode TYPE ty_maintenance_mode, END OF ty_general. @@ -138,7 +138,7 @@ INTERFACE zif_aff_susi_v1 "!

Maintenance Status

"! Maintenance Status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} - "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.y_flag} + "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.default_with_values} "! $showAlways maintenance_status TYPE ty_maintenance_status, "!

Fields

From 9ce675dc24ea80d248d4717c99b8dec3b29c01f0 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 9 May 2023 15:20:57 +0200 Subject: [PATCH 18/40] React to abaplint --- file-formats/susi/susi-v1.json | 2 +- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index 7504eafe7..fc71d4dd8 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -145,7 +145,7 @@ "defaultWithoutValues", "inactiveValues", "unmaintainedValues", - "authorizaitonChechInactive" + "authorizationCheckInactive" ], "enumTitles": [ "No Default", diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index 765926fc2..c4a0faadd 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -56,7 +56,7 @@ INTERFACE zif_aff_susi_v1 unmaintained_values TYPE ty_maintenance_status VALUE 'U', "!

Authorization Check Inactive

"! Authorization Check Inactive - Authorizaiton_chech_inactive TYPE ty_maintenance_status VALUE 'N', + authorization_check_inactive TYPE ty_maintenance_status VALUE 'N', END OF co_maintenance_status. TYPES: From 91e5f473e93a1550ecbd7cc969d1c6b4e5a4cce0 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 9 May 2023 15:34:26 +0200 Subject: [PATCH 19/40] React to review --- file-formats/susi/susi-v1.json | 8 ++-- .../susi/type/zif_aff_susi_v1.intf.abap | 38 +++++++++---------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index fc71d4dd8..53bd69681 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -59,9 +59,9 @@ "originalLanguage" ] }, - "general": { - "title": "General", - "description": "General", + "generalInformation": { + "title": "General Information", + "description": "General information", "type": "object", "properties": { "applicationName": { @@ -211,6 +211,6 @@ "required": [ "formatVersion", "header", - "general" + "generalInformation" ] } diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index c4a0faadd..78bf74506 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -18,22 +18,22 @@ INTERFACE zif_aff_susi_v1 BEGIN OF co_maintenance_mode, "!

Manual Maintenance

"! Manual Maintenance - manual TYPE ty_maintenance_mode VALUE space, + manual TYPE ty_maintenance_mode VALUE space, "!

Autom. Maintenance (All Objects)

"! Autom. Maintenance (All Objects) - all_object TYPE ty_maintenance_mode VALUE 'A', + all_object TYPE ty_maintenance_mode VALUE 'A', "!

Automatic Maintenance (Basis Authorization Objects Only)

"! Automatic Maintenance (Basis Authorization Objects Only) - basic_object TYPE ty_maintenance_mode VALUE 'B', + basic_object TYPE ty_maintenance_mode VALUE 'B', "!

Application Does Not Require Default Values

"! Application Does Not Require Default Values no_default_values TYPE ty_maintenance_mode VALUE 'I', "!

Application is Deprecated

"! Application is Deprecated - deprecated TYPE ty_maintenance_mode VALUE 'D', + deprecated TYPE ty_maintenance_mode VALUE 'D', "!

Application Is Obsolete

"! Application Is Obsolete - obsolete TYPE ty_maintenance_mode VALUE 'O', + obsolete TYPE ty_maintenance_mode VALUE 'O', END OF co_maintenance_mode, "!

Maintenance Status

@@ -41,19 +41,19 @@ INTERFACE zif_aff_susi_v1 BEGIN OF co_maintenance_status, "!

No Default

"! No Default - no_default TYPE ty_maintenance_status VALUE 'X', + no_default TYPE ty_maintenance_status VALUE 'X', "!

Default With Field Values

"! Default With Field Values - default_with_values TYPE ty_maintenance_status VALUE 'Y', + default_with_values TYPE ty_maintenance_status VALUE 'Y', "!

Default Without Field Values

"! Default Without Field Values - default_without_values TYPE ty_maintenance_status VALUE 'V', + default_without_values TYPE ty_maintenance_status VALUE 'V', "!

Default Inactive

"! Default Inactive - inactive_values TYPE ty_maintenance_status VALUE 'I', + inactive_values TYPE ty_maintenance_status VALUE 'I', "!

Unmaintained Object Status

"! Unmaintained Object Status - unmaintained_values TYPE ty_maintenance_status VALUE 'U', + unmaintained_values TYPE ty_maintenance_status VALUE 'U', "!

Authorization Check Inactive

"! Authorization Check Inactive authorization_check_inactive TYPE ty_maintenance_status VALUE 'N', @@ -71,18 +71,18 @@ INTERFACE zif_aff_susi_v1 ty_type TYPE c LENGTH 80. TYPES: - "!

General

- "! General + "!

General Information

+ "! General information "! $required - BEGIN OF ty_general, + BEGIN OF ty_general_information, "!

Application Name

"! Application Name of Authorization Default Value. "! $required - application_name TYPE ty_appl_name, + application_name TYPE ty_appl_name, "!

Application Type

"! Type of Authorization Default Value. "! $required - application_type TYPE ty_type, + application_type TYPE ty_type, "!

Technical Name (Hash Code)

"! Technical Name (Hash Code). "! $required @@ -92,7 +92,7 @@ INTERFACE zif_aff_susi_v1 "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} "! $required maintenance_mode TYPE ty_maintenance_mode, - END OF ty_general. + END OF ty_general_information. TYPES: "!

Authorization Value

@@ -163,10 +163,10 @@ INTERFACE zif_aff_susi_v1 "! Header "! $required header TYPE zif_aff_types_v1=>ty_header_60_src, - "!

General

- "! General + "!

General Information

+ "! General information "! $required - general TYPE ty_general, + general_information TYPE ty_general_information, "!

Authorization objects

"! Authorization objects authorization_objects TYPE ty_authorization_objects, From 56eef5da51cd85e00ff6d435a58f333665e8f943 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 9 May 2023 17:14:12 +0200 Subject: [PATCH 20/40] Validate JSON examples From c632b2e5e967ee2cb4e61d1ebcb05347a69fcc4e Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Tue, 9 May 2023 17:16:43 +0200 Subject: [PATCH 21/40] Validate JSON examples --- file-formats/susi/examples/zaff_example_susi.susi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/zaff_example_susi.susi.json index 7427c3df6..b0b79cc09 100644 --- a/file-formats/susi/examples/zaff_example_susi.susi.json +++ b/file-formats/susi/examples/zaff_example_susi.susi.json @@ -4,7 +4,7 @@ "description": "SUSI Testobject", "originalLanguage": "en" }, - "general": { + "generalInformation": { "applicationName": "Z_FEM3/Z_FEM3_GET_INFO", "applicationType": "WebService", "hashCode": "D2FF3796C3963799AE24F0224FCD96HS", From 33cb90257ce9fc4aa59f67e4f152fc8742626d74 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 11 May 2023 12:22:51 +0200 Subject: [PATCH 22/40] React of review --- ... => D2FF3796C3963799AE24F0224FCD96HS.json} | 0 file-formats/susi/susi-v1.json | 63 ++++++------- .../susi/type/zif_aff_susi_v1.intf.abap | 92 +++++++++---------- 3 files changed, 68 insertions(+), 87 deletions(-) rename file-formats/susi/examples/{zaff_example_susi.susi.json => D2FF3796C3963799AE24F0224FCD96HS.json} (100%) diff --git a/file-formats/susi/examples/zaff_example_susi.susi.json b/file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json similarity index 100% rename from file-formats/susi/examples/zaff_example_susi.susi.json rename to file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index 53bd69681..e2ebb8790 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -37,17 +37,14 @@ "type": "string", "enum": [ "standard", - "keyUser", "cloudDevelopment" ], "enumTitles": [ "Standard", - "ABAP for Key Users", "ABAP Cloud Development" ], "enumDescriptions": [ "Standard", - "ABAP for key user extensibility", "ABAP cloud development" ], "default": "standard" @@ -66,30 +63,24 @@ "properties": { "applicationName": { "title": "Application Name", - "description": "Application Name of Authorization Default Value.", + "description": "Application name of authorization default value", "type": "string", "maxLength": 132 }, "applicationType": { "title": "Application Type", - "description": "Type of Authorization Default Value.", + "description": "Type of authorization default value.", "type": "string", "maxLength": 80 }, - "hashCode": { - "title": "Technical Name (Hash Code)", - "description": "Technical Name (Hash Code).", - "type": "string", - "maxLength": 32 - }, "maintenanceMode": { "title": "Maintenance Mode", - "description": "Maintenance Mode.", + "description": "Maintenance mode.", "type": "string", "enum": [ "manual", - "allObject", - "basicObject", + "automatic", + "automaticBasisObjects", "noDefaultValues", "deprecated", "obsolete" @@ -103,12 +94,12 @@ "Application Is Obsolete" ], "enumDescriptions": [ - "Manual Maintenance", - "Autom. Maintenance (All Objects)", - "Automatic Maintenance (Basis Authorization Objects Only)", - "Application Does Not Require Default Values", - "Application is Deprecated", - "Application Is Obsolete" + "Manual maintenance", + "Automatic maintenance (all objects)", + "Automatic maintenance (basis authorization objects only)", + "Application does not require default values", + "Application is deprecated", + "Application is obsolete" ] } }, @@ -116,7 +107,6 @@ "required": [ "applicationName", "applicationType", - "hashCode", "maintenanceMode" ] }, @@ -126,18 +116,18 @@ "type": "array", "items": { "title": "Authorization Objects Details", - "description": "Authorization Objects Details", + "description": "Authorization objects details", "type": "object", "properties": { "object": { "title": "Object", - "description": "Name of Authorization Object", + "description": "Name of authorization object", "type": "string", "maxLength": 10 }, "maintenanceStatus": { "title": "Maintenance Status", - "description": "Maintenance Status", + "description": "Maintenance status", "type": "string", "enum": [ "noDefault", @@ -156,39 +146,39 @@ "Authorization Check Inactive" ], "enumDescriptions": [ - "No Default", - "Default With Field Values", - "Default Without Field Values", - "Default Inactive", - "Unmaintained Object Status", - "Authorization Check Inactive" + "No default", + "Default with field values", + "Default without field values", + "Default inactive", + "Unmaintained object status", + "Authorization check inactive" ], "default": "defaultWithValues" }, "fields": { "title": "Fields", - "description": "Authorization Fields.", + "description": "Authorization fields.", "type": "array", "items": { "title": "Authorization Field Details", - "description": "Authorization Field Details", + "description": "Authorization field details", "type": "object", "properties": { "field": { "title": "Field", - "description": "Name of Authorization Field", + "description": "Name of authorization field", "type": "string", "maxLength": 10 }, "low": { "title": "From", - "description": "From Value", + "description": "From value", "type": "string", "maxLength": 40 }, "high": { "title": "To", - "description": "To Values", + "description": "To values", "type": "string", "maxLength": 40 } @@ -202,7 +192,8 @@ }, "additionalProperties": false, "required": [ - "object" + "object", + "maintenanceStatus" ] } } diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index 78bf74506..4c986cf12 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -3,71 +3,68 @@ INTERFACE zif_aff_susi_v1 TYPES: "!

Maintenance Mode

- "! Maintenance Mode + "! Maintenance mode "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} ty_maintenance_mode TYPE c LENGTH 1, "!

Maintenance Status

- "! Maintenance Status + "! Maintenance status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.default_with_values} ty_maintenance_status TYPE c LENGTH 1. CONSTANTS: "!

Maintenance Mode

- "! Maintenance Mode + "! Maintenance mode BEGIN OF co_maintenance_mode, "!

Manual Maintenance

- "! Manual Maintenance - manual TYPE ty_maintenance_mode VALUE space, + "! Manual maintenance + manual TYPE ty_maintenance_mode VALUE space, "!

Autom. Maintenance (All Objects)

- "! Autom. Maintenance (All Objects) - all_object TYPE ty_maintenance_mode VALUE 'A', + "! Automatic maintenance (all objects) + automatic TYPE ty_maintenance_mode VALUE 'A', "!

Automatic Maintenance (Basis Authorization Objects Only)

- "! Automatic Maintenance (Basis Authorization Objects Only) - basic_object TYPE ty_maintenance_mode VALUE 'B', + "! Automatic maintenance (basis authorization objects only) + automatic_basis_objects TYPE ty_maintenance_mode VALUE 'B', "!

Application Does Not Require Default Values

- "! Application Does Not Require Default Values - no_default_values TYPE ty_maintenance_mode VALUE 'I', + "! Application does not require default values + no_default_values TYPE ty_maintenance_mode VALUE 'I', "!

Application is Deprecated

- "! Application is Deprecated - deprecated TYPE ty_maintenance_mode VALUE 'D', + "! Application is deprecated + deprecated TYPE ty_maintenance_mode VALUE 'D', "!

Application Is Obsolete

- "! Application Is Obsolete - obsolete TYPE ty_maintenance_mode VALUE 'O', + "! Application is obsolete + obsolete TYPE ty_maintenance_mode VALUE 'O', END OF co_maintenance_mode, "!

Maintenance Status

- "! Maintenance Status + "! Maintenance status BEGIN OF co_maintenance_status, "!

No Default

- "! No Default + "! No default no_default TYPE ty_maintenance_status VALUE 'X', "!

Default With Field Values

- "! Default With Field Values + "! Default with field values default_with_values TYPE ty_maintenance_status VALUE 'Y', "!

Default Without Field Values

- "! Default Without Field Values + "! Default without field values default_without_values TYPE ty_maintenance_status VALUE 'V', "!

Default Inactive

- "! Default Inactive + "! Default inactive inactive_values TYPE ty_maintenance_status VALUE 'I', "!

Unmaintained Object Status

- "! Unmaintained Object Status + "! Unmaintained object status unmaintained_values TYPE ty_maintenance_status VALUE 'U', "!

Authorization Check Inactive

- "! Authorization Check Inactive + "! Authorization check inactive authorization_check_inactive TYPE ty_maintenance_status VALUE 'N', END OF co_maintenance_status. TYPES: "!

Application Name

- "! Name of Application + "! Name of application ty_appl_name TYPE c LENGTH 132, - "!

Hash value

- "! Hash Values for an Application's Auth. Default Values - ty_hash_name TYPE c LENGTH 32, "!

Application Type

- "! Type of Application + "! Type of application ty_type TYPE c LENGTH 80. TYPES: @@ -76,19 +73,15 @@ INTERFACE zif_aff_susi_v1 "! $required BEGIN OF ty_general_information, "!

Application Name

- "! Application Name of Authorization Default Value. + "! Application name of authorization default value "! $required application_name TYPE ty_appl_name, "!

Application Type

- "! Type of Authorization Default Value. + "! Type of authorization default value. "! $required application_type TYPE ty_type, - "!

Technical Name (Hash Code)

- "! Technical Name (Hash Code). - "! $required - hash_code TYPE ty_hash_name, "!

Maintenance Mode

- "! Maintenance Mode. + "! Maintenance mode. "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} "! $required maintenance_mode TYPE ty_maintenance_mode, @@ -96,61 +89,58 @@ INTERFACE zif_aff_susi_v1 TYPES: "!

Authorization Value

- "! Authorization Value + "! Authorization value ty_val TYPE c LENGTH 40. TYPES: "!

Authorization Field

- "! Authorization Field + "! Authorization field ty_field TYPE c LENGTH 10. TYPES: "!

Authorization Field Details

- "! Authorization Field Details + "! Authorization field details BEGIN OF ty_authorization_field, "!

Field

- "! Name of Authorization Field + "! Name of authorization field "! $required field TYPE ty_field, "!

From

- "! From Value + "! From value "! $showAlways low TYPE ty_val, "!

To

- "! To Values - "! $showAlways + "! To values high TYPE ty_val, END OF ty_authorization_field. TYPES: "!

Authorization Fields

- "! Authorization Fields + "! Authorization fields ty_authorization_fields TYPE STANDARD TABLE OF ty_authorization_field WITH DEFAULT KEY. TYPES: "!

Authorization Objects Details

- "! Authorization Objects Details + "! Authorization objects details BEGIN OF ty_authorization_object, "!

Object

- "! Name of Authorization Object + "! Name of authorization object "! $required object TYPE c LENGTH 10, "!

Maintenance Status

- "! Maintenance Status + "! Maintenance status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.default_with_values} - "! $showAlways + "! $required maintenance_status TYPE ty_maintenance_status, "!

Fields

- "! Authorization Fields. - "! $showAlways + "! Authorization fields. fields TYPE ty_authorization_fields, - END OF ty_authorization_object. TYPES: "!

Authorization Objects

- "! Authorization Objects + "! Authorization objects ty_authorization_objects TYPE STANDARD TABLE OF ty_authorization_object WITH DEFAULT KEY. TYPES: @@ -162,7 +152,7 @@ INTERFACE zif_aff_susi_v1 "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_60_src, + header TYPE zif_aff_types_v1=>ty_header_60_cloud, "!

General Information

"! General information "! $required From b460996cf3202c682206474ce4e59e0fb81c48bd Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 11 May 2023 12:29:30 +0200 Subject: [PATCH 23/40] React of validate JSON examples check --- file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json | 1 - 1 file changed, 1 deletion(-) diff --git a/file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json b/file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json index b0b79cc09..61abc4561 100644 --- a/file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json +++ b/file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json @@ -7,7 +7,6 @@ "generalInformation": { "applicationName": "Z_FEM3/Z_FEM3_GET_INFO", "applicationType": "WebService", - "hashCode": "D2FF3796C3963799AE24F0224FCD96HS", "maintenanceMode": "manual" }, "authorizationObjects": [ From 0a3cd66caf9a84a97dcc375e8df42e511fe20aa6 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 11 May 2023 12:52:48 +0200 Subject: [PATCH 24/40] React to review --- file-formats/susi/susi-v1.json | 2 +- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index e2ebb8790..a97f4b23a 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -87,7 +87,7 @@ ], "enumTitles": [ "Manual Maintenance", - "Autom. Maintenance (All Objects)", + "Automatic Maintenance (All Objects)", "Automatic Maintenance (Basis Authorization Objects Only)", "Application Does Not Require Default Values", "Application is Deprecated", diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index 4c986cf12..ee0646f0f 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -19,7 +19,7 @@ INTERFACE zif_aff_susi_v1 "!

Manual Maintenance

"! Manual maintenance manual TYPE ty_maintenance_mode VALUE space, - "!

Autom. Maintenance (All Objects)

+ "!

Automatic Maintenance (All Objects)

"! Automatic maintenance (all objects) automatic TYPE ty_maintenance_mode VALUE 'A', "!

Automatic Maintenance (Basis Authorization Objects Only)

From ae3068ed891434f9f8659b980899138159726a38 Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Mon, 15 May 2023 11:42:39 +0200 Subject: [PATCH 25/40] Rename example file --- ...224FCD96HS.json => d2ff3796c3963799ae24f0224fcd96hs.susi.json} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename file-formats/susi/examples/{D2FF3796C3963799AE24F0224FCD96HS.json => d2ff3796c3963799ae24f0224fcd96hs.susi.json} (100%) diff --git a/file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json b/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json similarity index 100% rename from file-formats/susi/examples/D2FF3796C3963799AE24F0224FCD96HS.json rename to file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json From eaeb32fae1d2c72ef0820aa8a32cae84e871d724 Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Mon, 15 May 2023 11:48:08 +0200 Subject: [PATCH 26/40] Update indentation --- ...d2ff3796c3963799ae24f0224fcd96hs.susi.json | 70 +++++++++---------- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json b/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json index 61abc4561..9122ec22e 100644 --- a/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json +++ b/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json @@ -1,42 +1,42 @@ { - "formatVersion": "1", - "header": { - "description": "SUSI Testobject", - "originalLanguage": "en" - }, - "generalInformation": { - "applicationName": "Z_FEM3/Z_FEM3_GET_INFO", - "applicationType": "WebService", - "maintenanceMode": "manual" + "formatVersion": "1", + "header": { + "description": "SUSI Testobject", + "originalLanguage": "en" + }, + "generalInformation": { + "applicationName": "Z_FEM3/Z_FEM3_GET_INFO", + "applicationType": "WebService", + "maintenanceMode": "manual" + }, + "authorizationObjects": [ + { + "object": "S_USER_AGR", + "maintenanceStatus": "defaultWithValues", + "fields": [ + { + "field": "ACTVT", + "low": "02" + }, + { + "field": "ACTVT", + "low": "03" + } + ] }, - "authorizationObjects": [ + { + "object": "S_USER_GRP", + "maintenanceStatus": "noDefault", + "fields": [ { - "object": "S_USER_AGR", - "maintenanceStatus": "defaultWithValues", - "fields": [ - { - "field": "ACTVT", - "low": "02" - }, - { - "field": "ACTVT", - "low": "03" - } - ] + "field": "ACTVT", + "low": "03" }, { - "object": "S_USER_GRP", - "maintenanceStatus": "noDefault", - "fields": [ - { - "field": "ACTVT", - "low": "03" - }, - { - "field": "CLASS", - "low": "TEST" - } - ] + "field": "CLASS", + "low": "TEST" } - ] + ] + } + ] } From 4e0484802e9fe811be4be0b0980246db17e45217 Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Mon, 15 May 2023 11:49:29 +0200 Subject: [PATCH 27/40] Fix link in readme --- file-formats/susi/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/README.md b/file-formats/susi/README.md index b2ff60673..327deae87 100644 --- a/file-formats/susi/README.md +++ b/file-formats/susi/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`zaff_example_susi.susi.json`](./examples/zaff_example_susi.susi.json) +`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`d2ff3796c3963799ae24f0224fcd96hs.susi.json`](./examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json) From 9dde176312c0a7315b0c36ead70148aa292db68f Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 6 Jul 2023 08:50:31 +0200 Subject: [PATCH 28/40] new SUSI example --- ...5fae0107acd2ee619d9f869c651edhs.susi.json} | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) rename file-formats/susi/examples/{d2ff3796c3963799ae24f0224fcd96hs.susi.json => 55fae0107acd2ee619d9f869c651edhs.susi.json} (56%) diff --git a/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json similarity index 56% rename from file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json rename to file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index 9122ec22e..19a65dff0 100644 --- a/file-formats/susi/examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -5,38 +5,42 @@ "originalLanguage": "en" }, "generalInformation": { - "applicationName": "Z_FEM3/Z_FEM3_GET_INFO", + "applicationName": "WS SRT_TEST_WEBI/REQUEST_RESPONSE", "applicationType": "WebService", "maintenanceMode": "manual" }, "authorizationObjects": [ { - "object": "S_USER_AGR", + "object": "S_SERVICE", + "maintenanceStatus": "noDefault" + }, + { + "object": "S_DATASET", "maintenanceStatus": "defaultWithValues", "fields": [ { "field": "ACTVT", - "low": "02" + "low": "33" }, { "field": "ACTVT", - "low": "03" - } + "low": "34" + }, + { + "field": "PROGRAM", + "low": "SAPLSTRF" + } ] - }, + }, { - "object": "S_USER_GRP", - "maintenanceStatus": "noDefault", + "object": "S_TABU_RFC", + "maintenanceStatus": "defaultWithValues", "fields": [ { "field": "ACTVT", "low": "03" - }, - { - "field": "CLASS", - "low": "TEST" - } + } ] - } + } ] } From e7c039a87513bee37b5e10e53672e6ea44bc3324 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 6 Jul 2023 09:09:58 +0200 Subject: [PATCH 29/40] Trailing whitespace --- .../55fae0107acd2ee619d9f869c651edhs.susi.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index 19a65dff0..415ed0801 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -12,7 +12,7 @@ "authorizationObjects": [ { "object": "S_SERVICE", - "maintenanceStatus": "noDefault" + "maintenanceStatus": "noDefault" }, { "object": "S_DATASET", @@ -29,9 +29,9 @@ { "field": "PROGRAM", "low": "SAPLSTRF" - } + } ] - }, + }, { "object": "S_TABU_RFC", "maintenanceStatus": "defaultWithValues", @@ -39,8 +39,8 @@ { "field": "ACTVT", "low": "03" - } + } ] - } + } ] } From fc4ce1d196e53fe228efcfae65ed3964f4f08629 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 6 Jul 2023 09:40:56 +0200 Subject: [PATCH 30/40] update README with new example --- file-formats/susi/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/README.md b/file-formats/susi/README.md index 327deae87..2355e6312 100644 --- a/file-formats/susi/README.md +++ b/file-formats/susi/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`d2ff3796c3963799ae24f0224fcd96hs.susi.json`](./examples/d2ff3796c3963799ae24f0224fcd96hs.susi.json) +`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`55fae0107acd2ee619d9f869c651edhs.susi.json`](./examples/55fae0107acd2ee619d9f869c651edhs.susi.json) From 65c737079550a288b77d1befda901d9c86040be1 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 6 Jul 2023 10:37:37 +0200 Subject: [PATCH 31/40] Example content --- .../susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index 415ed0801..d6e6f9a90 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -1,11 +1,11 @@ { "formatVersion": "1", "header": { - "description": "SUSI Testobject", + "description": "WS SRT_TEST_WEBI/REQUEST_RESPONSE", "originalLanguage": "en" }, "generalInformation": { - "applicationName": "WS SRT_TEST_WEBI/REQUEST_RESPONSE", + "applicationName": "SRT_TEST_WEBI/REQUEST_RESPONSE", "applicationType": "WebService", "maintenanceMode": "manual" }, From f0bf77c41d2b371f725100a2e5b8fd121a7e2643 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Jul 2023 14:42:30 +0200 Subject: [PATCH 32/40] Correction of example --- .../susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index d6e6f9a90..571a6e563 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -29,7 +29,10 @@ { "field": "PROGRAM", "low": "SAPLSTRF" - } + }, + { + "field": "FILENAME" + } ] }, { From 91b2df94b8bcde004487e71fcc2e4541bfc69b06 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Jul 2023 17:47:47 +0200 Subject: [PATCH 33/40] New AFF model for SUSI --- file-formats/susi/README.md | 2 +- file-formats/susi/susi-v1.json | 66 +++++++------- .../susi/type/zif_aff_susi_v1.intf.abap | 86 ++++++++++--------- .../susi/type/zif_aff_susi_v1.intf.json | 2 +- 4 files changed, 79 insertions(+), 77 deletions(-) diff --git a/file-formats/susi/README.md b/file-formats/susi/README.md index 2355e6312..09c2cc510 100644 --- a/file-formats/susi/README.md +++ b/file-formats/susi/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`55fae0107acd2ee619d9f869c651edhs.susi.json`](./examples/55fae0107acd2ee619d9f869c651edhs.susi.json) +`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`test.susi.json`](./examples/test.susi.json) diff --git a/file-formats/susi/susi-v1.json b/file-formats/susi/susi-v1.json index a97f4b23a..26d536a4a 100644 --- a/file-formats/susi/susi-v1.json +++ b/file-formats/susi/susi-v1.json @@ -63,19 +63,19 @@ "properties": { "applicationName": { "title": "Application Name", - "description": "Application name of authorization default value", + "description": "Application name of authorization defaults", "type": "string", "maxLength": 132 }, "applicationType": { "title": "Application Type", - "description": "Type of authorization default value.", + "description": "Type of authorization defaults", "type": "string", "maxLength": 80 }, "maintenanceMode": { "title": "Maintenance Mode", - "description": "Maintenance mode.", + "description": "Maintenance mode", "type": "string", "enum": [ "manual", @@ -90,7 +90,7 @@ "Automatic Maintenance (All Objects)", "Automatic Maintenance (Basis Authorization Objects Only)", "Application Does Not Require Default Values", - "Application is Deprecated", + "Application Is Deprecated", "Application Is Obsolete" ], "enumDescriptions": [ @@ -100,73 +100,77 @@ "Application does not require default values", "Application is deprecated", "Application is obsolete" - ] + ], + "default": "manual" + }, + "description": { + "title": "Description", + "description": "Description of authorization default values", + "type": "string" } }, "additionalProperties": false, "required": [ "applicationName", - "applicationType", - "maintenanceMode" + "applicationType" ] }, "authorizationObjects": { - "title": "Authorization objects", + "title": "Authorization Objects", "description": "Authorization objects", "type": "array", "items": { - "title": "Authorization Objects Details", - "description": "Authorization objects details", + "title": "Authorization Object Details", + "description": "Details of Authorization object", "type": "object", "properties": { "object": { "title": "Object", - "description": "Name of authorization object", + "description": "Name of Authorization Object", "type": "string", "maxLength": 10 }, "maintenanceStatus": { "title": "Maintenance Status", - "description": "Maintenance status", + "description": "Maintenance Status", "type": "string", "enum": [ "noDefault", "defaultWithValues", "defaultWithoutValues", - "inactiveValues", - "unmaintainedValues", - "authorizationCheckInactive" + "inactiveValues" ], "enumTitles": [ "No Default", "Default With Field Values", "Default Without Field Values", - "Default Inactive", - "Unmaintained Object Status", - "Authorization Check Inactive" + "Default Inactive" ], "enumDescriptions": [ "No default", "Default with field values", "Default without field values", - "Default inactive", - "Unmaintained object status", - "Authorization check inactive" + "Default inactive" ], "default": "defaultWithValues" }, + "description": { + "title": "Description", + "description": "Description of authorization defaults of object", + "type": "string" + }, "fields": { - "title": "Fields", - "description": "Authorization fields.", + "title": "Authorization Field Values", + "description": "Authorization field values", "type": "array", "items": { - "title": "Authorization Field Details", - "description": "Authorization field details", + "title": "Authorization Field Values", + "description": "Authorization field values", "type": "object", "properties": { "field": { - "title": "Field", - "description": "Name of authorization field", + "title": "Authorization Field", + "description": "Authorization field", "type": "string", "maxLength": 10 }, @@ -183,17 +187,13 @@ "maxLength": 40 } }, - "additionalProperties": false, - "required": [ - "field" - ] + "additionalProperties": false } } }, "additionalProperties": false, "required": [ - "object", - "maintenanceStatus" + "object" ] } } diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index ee0646f0f..feaacd208 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -1,10 +1,11 @@ INTERFACE zif_aff_susi_v1 - PUBLIC. + PUBLIC . TYPES: "!

Maintenance Mode

"! Maintenance mode "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} + "! $default {@link zif_aff_susi_v1.data:co_maintenance_mode.manual} ty_maintenance_mode TYPE c LENGTH 1, "!

Maintenance Status

"! Maintenance status @@ -28,7 +29,7 @@ INTERFACE zif_aff_susi_v1 "!

Application Does Not Require Default Values

"! Application does not require default values no_default_values TYPE ty_maintenance_mode VALUE 'I', - "!

Application is Deprecated

+ "!

Application Is Deprecated

"! Application is deprecated deprecated TYPE ty_maintenance_mode VALUE 'D', "!

Application Is Obsolete

@@ -41,31 +42,28 @@ INTERFACE zif_aff_susi_v1 BEGIN OF co_maintenance_status, "!

No Default

"! No default - no_default TYPE ty_maintenance_status VALUE 'X', + no_default TYPE ty_maintenance_status VALUE 'X', "!

Default With Field Values

"! Default with field values - default_with_values TYPE ty_maintenance_status VALUE 'Y', + default_with_values TYPE ty_maintenance_status VALUE 'Y', "!

Default Without Field Values

"! Default without field values - default_without_values TYPE ty_maintenance_status VALUE 'V', + default_without_values TYPE ty_maintenance_status VALUE 'V', "!

Default Inactive

"! Default inactive - inactive_values TYPE ty_maintenance_status VALUE 'I', - "!

Unmaintained Object Status

- "! Unmaintained object status - unmaintained_values TYPE ty_maintenance_status VALUE 'U', - "!

Authorization Check Inactive

- "! Authorization check inactive - authorization_check_inactive TYPE ty_maintenance_status VALUE 'N', + inactive_values TYPE ty_maintenance_status VALUE 'I', END OF co_maintenance_status. TYPES: "!

Application Name

"! Name of application - ty_appl_name TYPE c LENGTH 132, + ty_appl_name TYPE c LENGTH 132, "!

Application Type

"! Type of application - ty_type TYPE c LENGTH 80. + ty_type TYPE c LENGTH 80, + "!

Object description

+ "! Object description + ty_description TYPE c LENGTH 60. TYPES: "!

General Information

@@ -73,70 +71,74 @@ INTERFACE zif_aff_susi_v1 "! $required BEGIN OF ty_general_information, "!

Application Name

- "! Application name of authorization default value + "! Application name of authorization defaults "! $required application_name TYPE ty_appl_name, "!

Application Type

- "! Type of authorization default value. + "! Type of authorization defaults "! $required application_type TYPE ty_type, "!

Maintenance Mode

- "! Maintenance mode. + "! Maintenance mode "! $values {@link zif_aff_susi_v1.data:co_maintenance_mode} - "! $required + "! $default {@link zif_aff_susi_v1.data:co_maintenance_mode.manual} + "! $showAlways maintenance_mode TYPE ty_maintenance_mode, + "!

Description

+ "! Description of authorization default values + description TYPE string, END OF ty_general_information. TYPES: "!

Authorization Value

- "! Authorization value - ty_val TYPE c LENGTH 40. - - TYPES: + "! Authorization Value + ty_val TYPE c LENGTH 40, "!

Authorization Field

- "! Authorization field + "! Authorization Field ty_field TYPE c LENGTH 10. TYPES: - "!

Authorization Field Details

- "! Authorization field details + "!

Authorization Field Values

+ "! Authorization field values BEGIN OF ty_authorization_field, - "!

Field

- "! Name of authorization field - "! $required + "!

Authorization Field

+ "! Authorization field field TYPE ty_field, "!

From

"! From value "! $showAlways - low TYPE ty_val, + low TYPE ty_val, "!

To

"! To values - high TYPE ty_val, - END OF ty_authorization_field. + high TYPE ty_val, + END OF ty_authorization_field . TYPES: "!

Authorization Fields

"! Authorization fields - ty_authorization_fields TYPE STANDARD TABLE OF ty_authorization_field WITH DEFAULT KEY. + ty_authorization_fields TYPE STANDARD TABLE OF ty_authorization_field WITH DEFAULT KEY. TYPES: - "!

Authorization Objects Details

- "! Authorization objects details + "!

Authorization Object Details

+ "! Details of Authorization object BEGIN OF ty_authorization_object, "!

Object

- "! Name of authorization object + "! Name of Authorization Object "! $required object TYPE c LENGTH 10, "!

Maintenance Status

- "! Maintenance status + "! Maintenance Status "! $values {@link zif_aff_susi_v1.data:co_maintenance_status} "! $default {@link zif_aff_susi_v1.data:co_maintenance_status.default_with_values} - "! $required + "! $showAlways maintenance_status TYPE ty_maintenance_status, - "!

Fields

- "! Authorization fields. + "!

Description

+ "! Description of authorization defaults of object + description TYPE string, + "!

Authorization Field Values

+ "! Authorization field values fields TYPE ty_authorization_fields, - END OF ty_authorization_object. + END OF ty_authorization_object . TYPES: "!

Authorization Objects

@@ -157,9 +159,9 @@ INTERFACE zif_aff_susi_v1 "! General information "! $required general_information TYPE ty_general_information, - "!

Authorization objects

+ "!

Authorization Objects

"! Authorization objects authorization_objects TYPE ty_authorization_objects, - END OF ty_main. + END OF ty_main . ENDINTERFACE. diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.json b/file-formats/susi/type/zif_aff_susi_v1.intf.json index 920811c45..1c5c77a26 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.json +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.json @@ -1,7 +1,7 @@ { "formatVersion": "1", "header": { - "description": "Authentication Default Values AFF", + "description": "Authentication Defaults AFF", "originalLanguage": "en" } } From a45d43c473971b276a4f24843fe1336f14451e73 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Jul 2023 18:07:50 +0200 Subject: [PATCH 34/40] Trailing whitespace in example --- .../susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index 571a6e563..e740e845f 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -32,7 +32,7 @@ }, { "field": "FILENAME" - } + } ] }, { From 7a22a59f1595399e07e94f6d1e3a4c0889cbc933 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Jul 2023 18:12:20 +0200 Subject: [PATCH 35/40] AFF for SUSI --- file-formats/susi/type/zif_aff_susi_v1.intf.abap | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/file-formats/susi/type/zif_aff_susi_v1.intf.abap b/file-formats/susi/type/zif_aff_susi_v1.intf.abap index feaacd208..11bbf28ce 100644 --- a/file-formats/susi/type/zif_aff_susi_v1.intf.abap +++ b/file-formats/susi/type/zif_aff_susi_v1.intf.abap @@ -1,5 +1,5 @@ INTERFACE zif_aff_susi_v1 - PUBLIC . + PUBLIC. TYPES: "!

Maintenance Mode

@@ -60,10 +60,7 @@ INTERFACE zif_aff_susi_v1 ty_appl_name TYPE c LENGTH 132, "!

Application Type

"! Type of application - ty_type TYPE c LENGTH 80, - "!

Object description

- "! Object description - ty_description TYPE c LENGTH 60. + ty_type TYPE c LENGTH 80. TYPES: "!

General Information

@@ -111,7 +108,7 @@ INTERFACE zif_aff_susi_v1 "!

To

"! To values high TYPE ty_val, - END OF ty_authorization_field . + END OF ty_authorization_field. TYPES: "!

Authorization Fields

@@ -138,7 +135,7 @@ INTERFACE zif_aff_susi_v1 "!

Authorization Field Values

"! Authorization field values fields TYPE ty_authorization_fields, - END OF ty_authorization_object . + END OF ty_authorization_object. TYPES: "!

Authorization Objects

@@ -162,6 +159,6 @@ INTERFACE zif_aff_susi_v1 "!

Authorization Objects

"! Authorization objects authorization_objects TYPE ty_authorization_objects, - END OF ty_main . + END OF ty_main. ENDINTERFACE. From d8205df68033863c9b6b7263a45f915e7350821f Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Wed, 26 Jul 2023 18:14:58 +0200 Subject: [PATCH 36/40] Trailing whitespace in example --- .../susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index e740e845f..90642e5cb 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -32,7 +32,7 @@ }, { "field": "FILENAME" - } + } ] }, { From 277b44d72f01095a83676705c6f9744d54c6c556 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Thu, 27 Jul 2023 09:30:38 +0200 Subject: [PATCH 37/40] Readme example file --- file-formats/susi/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/README.md b/file-formats/susi/README.md index 09c2cc510..2355e6312 100644 --- a/file-formats/susi/README.md +++ b/file-formats/susi/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`test.susi.json`](./examples/test.susi.json) +`.susi.json` | 1 | [`zif_aff_susi_v1.intf.abap`](./type/zif_aff_susi_v1.intf.abap) | [`susi-v1.json`](./susi-v1.json) | [`55fae0107acd2ee619d9f869c651edhs.susi.json`](./examples/55fae0107acd2ee619d9f869c651edhs.susi.json) From a9890075e89f4c035f78f7737b5185afd6298358 Mon Sep 17 00:00:00 2001 From: WDFYvonne <50316404+WDFYvonne@users.noreply.github.com> Date: Fri, 28 Jul 2023 09:37:07 +0200 Subject: [PATCH 38/40] formatVersion: read-only From a6b1c1a25f82d86dda039102a422a1dc6802b08d Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Fri, 28 Jul 2023 10:17:34 +0200 Subject: [PATCH 39/40] Fix showAlways value in example --- .../susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index 90642e5cb..ab308d6ff 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -31,7 +31,8 @@ "low": "SAPLSTRF" }, { - "field": "FILENAME" + "field": "FILENAME", + "low": "" } ] }, From f62df1e35645696a369d9e97b6881dbde9771ebe Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Fri, 28 Jul 2023 10:23:42 +0200 Subject: [PATCH 40/40] Fix editor config issue --- .../susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json index ab308d6ff..e2b0576eb 100644 --- a/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json +++ b/file-formats/susi/examples/55fae0107acd2ee619d9f869c651edhs.susi.json @@ -32,7 +32,7 @@ }, { "field": "FILENAME", - "low": "" + "low": "" } ] },