From 1daa7e346f86d7ddb916245c26c8a83f5685ffc0 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Wed, 8 Nov 2023 15:07:39 +0100 Subject: [PATCH 01/30] Add AFF Type SFPF Add AFF Type SFPF --- file-formats/sfpf/README.md | 5 + .../examples/z_aff_example_sfpf.sfpf.json | 13 ++ file-formats/sfpf/sfpf-v1.json | 115 ++++++++++++++++++ .../sfpf/type/zif_aff_sfpf_v1.intf.abap | 34 ++++++ .../sfpf/type/zif_aff_sfpf_v1.intf.json | 7 ++ 5 files changed, 174 insertions(+) create mode 100644 file-formats/sfpf/README.md create mode 100644 file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json create mode 100644 file-formats/sfpf/sfpf-v1.json create mode 100644 file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap create mode 100644 file-formats/sfpf/type/zif_aff_sfpf_v1.intf.json diff --git a/file-formats/sfpf/README.md b/file-formats/sfpf/README.md new file mode 100644 index 000000000..1387b6001 --- /dev/null +++ b/file-formats/sfpf/README.md @@ -0,0 +1,5 @@ +# SFPF File Format + +File | Cardinality | Definition | Schema | Example +:--- | :--- | :--- | :--- | :--- +`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json new file mode 100644 index 000000000..b2f1b67e5 --- /dev/null +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -0,0 +1,13 @@ +{ + "formatVersion": "1", + "header": { + "description": "Example SFPF for ABAP file formats", + "originalLanguage": "en", + "abapLanguageVersion": "cloudDevelopment" + }, + "name": "TEMPLATE_NAME", + "description": "Description", + "dataprovider": "Example_SRV_DEF", + "embed": "doNotEmbedFonts", + "mirroring": "mirroringInRtlLanguages" +} diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json new file mode 100644 index 000000000..190fd1fd7 --- /dev/null +++ b/file-formats/sfpf/sfpf-v1.json @@ -0,0 +1,115 @@ +{ + "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.", + "$schema": "https://json-schema.org/draft/2020-12/schema", + "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/sfpf/sfpf-v1.json", + "title": "Object Type SFPF", + "description": "Object type SFPF", + "type": "object", + "properties": { + "formatVersion": { + "title": "Format Version", + "description": "Format version", + "type": "string", + "const": "1" + }, + "header": { + "title": "Header", + "description": "Header", + "type": "object", + "properties": { + "description": { + "title": "Description", + "description": "Description of the ABAP object", + "type": "string", + "maxLength": 60 + }, + "originalLanguage": { + "title": "Original Language", + "description": "Original language of the ABAP object", + "type": "string", + "minLength": 2, + "maxLength": 2, + "pattern": "^[a-z]+$" + }, + "abapLanguageVersion": { + "title": "ABAP Language Version", + "description": "ABAP language version", + "type": "string", + "enum": [ + "standard", + "keyUser", + "cloudDevelopment" + ], + "enumTitles": [ + "Standard", + "ABAP for Key Users", + "ABAP Cloud Development" + ], + "enumDescriptions": [ + "Standard", + "ABAP for key user extensibility", + "ABAP cloud development" + ], + "default": "standard" + } + }, + "additionalProperties": false, + "required": [ + "description", + "originalLanguage" + ] + }, + "name": { + "title": "Name", + "description": "Name", + "type": "string", + "maxLength": 30 + }, + "description": { + "title": "Description", + "description": "Description", + "type": "string", + "maxLength": 60 + }, + "dataprovider": { + "title": "Dataprovider", + "description": "Dataprovider", + "type": "string", + "maxLength": 40 + }, + "embed": { + "title": "Font Embed", + "description": "Font Embed", + "type": "string", + "enum": [ + "doNotEmbedFonts", + "embedFonts" + ], + "enumDescriptions": [ + "Do not embed fonts", + "Embed fonts" + ] + }, + "mirroring": { + "title": "Mirror in RTL", + "description": "Mirror in RTL", + "type": "string", + "enum": [ + "noMirroringInRtlLanguages", + "mirroringInRtlLanguages" + ], + "enumDescriptions": [ + "No mirroring in RTL languages", + "Mirroring in RTL languages" + ] + } + }, + "additionalProperties": false, + "required": [ + "formatVersion", + "header", + "name", + "description", + "dataprovider" + ] +} diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap new file mode 100644 index 000000000..dd0c8ecbf --- /dev/null +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -0,0 +1,34 @@ +INTERFACE zif_aff_sfpf_v1 + PUBLIC . + TYPES: + "!

Object Type SFPF

+ "! Object type SFPF + BEGIN OF ty_main, + "!

Format Version

+ "! Format version + "! $required + format_version TYPE zif_aff_types_v1=>ty_format_version, + "!

Header

+ "! Header + "! $required + header TYPE zif_aff_types_v1=>ty_header_60, + "!

Name

+ "! Name + "! $required + name TYPE fpname, + "!

Description

+ "! Description + "! $required + description TYPE fptext, + "!

Dataprovider

+ "! Dataprovider + "! $required + dataprovider TYPE fpdpname, + "!

Font Embed

+ "! Font Embed + embed TYPE fpfntemb, + "!

Mirror in RTL

+ "! Mirror in RTL + mirroring TYPE fpmirroring, + END OF ty_main. +ENDINTERFACE. diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.json b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.json new file mode 100644 index 000000000..737a35715 --- /dev/null +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.json @@ -0,0 +1,7 @@ +{ + "formatVersion": "1", + "header": { + "description": "AFF type for SFPF object", + "originalLanguage": "en" + } +} From a5bbff89b6b009a27595e2e48d8db59420fd14b5 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Thu, 9 Nov 2023 08:54:18 +0100 Subject: [PATCH 02/30] [SFPF] Data Type fix [SFPF] Change domain specific data type to generic ones --- file-formats/sfpf/sfpf-v1.json | 20 ++----------------- .../sfpf/type/zif_aff_sfpf_v1.intf.abap | 10 +++++----- 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index 190fd1fd7..bff7c86bd 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -80,28 +80,12 @@ "embed": { "title": "Font Embed", "description": "Font Embed", - "type": "string", - "enum": [ - "doNotEmbedFonts", - "embedFonts" - ], - "enumDescriptions": [ - "Do not embed fonts", - "Embed fonts" - ] + "type": "boolean" }, "mirroring": { "title": "Mirror in RTL", "description": "Mirror in RTL", - "type": "string", - "enum": [ - "noMirroringInRtlLanguages", - "mirroringInRtlLanguages" - ], - "enumDescriptions": [ - "No mirroring in RTL languages", - "Mirroring in RTL languages" - ] + "type": "boolean" } }, "additionalProperties": false, diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index dd0c8ecbf..eb6c4a87f 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -15,20 +15,20 @@ INTERFACE zif_aff_sfpf_v1 "!

Name

"! Name "! $required - name TYPE fpname, + name TYPE c LENGTH 30, "!

Description

"! Description "! $required - description TYPE fptext, + description TYPE c LENGTH 60, "!

Dataprovider

"! Dataprovider "! $required - dataprovider TYPE fpdpname, + dataprovider TYPE c LENGTH 40, "!

Font Embed

"! Font Embed - embed TYPE fpfntemb, + embed TYPE abap_boolean, "!

Mirror in RTL

"! Mirror in RTL - mirroring TYPE fpmirroring, + mirroring TYPE abap_boolean, END OF ty_main. ENDINTERFACE. From ebf9e262bf7534537992ce8d41d2ff2646feef48 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Thu, 9 Nov 2023 08:58:36 +0100 Subject: [PATCH 03/30] Update zif_aff_sfpf_v1.intf.abap --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index eb6c4a87f..dc2fb3568 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -1,5 +1,5 @@ INTERFACE zif_aff_sfpf_v1 - PUBLIC . + PUBLIC. TYPES: "!

Object Type SFPF

"! Object type SFPF @@ -26,9 +26,9 @@ INTERFACE zif_aff_sfpf_v1 dataprovider TYPE c LENGTH 40, "!

Font Embed

"! Font Embed - embed TYPE abap_boolean, + embed TYPE ABAP_BOOL, "!

Mirror in RTL

"! Mirror in RTL - mirroring TYPE abap_boolean, + mirroring TYPE ABAP_BOOL, END OF ty_main. ENDINTERFACE. From 29cbb05dbded6d4b2c5f9d106a12a743226a41d8 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Thu, 9 Nov 2023 08:59:27 +0100 Subject: [PATCH 04/30] Update zif_aff_sfpf_v1.intf.abap --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index dc2fb3568..a85192132 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -26,9 +26,9 @@ INTERFACE zif_aff_sfpf_v1 dataprovider TYPE c LENGTH 40, "!

Font Embed

"! Font Embed - embed TYPE ABAP_BOOL, + embed TYPE abap_bool, "!

Mirror in RTL

"! Mirror in RTL - mirroring TYPE ABAP_BOOL, + mirroring TYPE abap_bool, END OF ty_main. ENDINTERFACE. From e90d7969a3deaa9249fed3bcda000c4a9c25b75b Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Thu, 9 Nov 2023 09:03:38 +0100 Subject: [PATCH 05/30] Fix example --- file-formats/sfpf/README.md | 2 +- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/file-formats/sfpf/README.md b/file-formats/sfpf/README.md index 1387b6001..11c6b094f 100644 --- a/file-formats/sfpf/README.md +++ b/file-formats/sfpf/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf) +`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf.json) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index b2f1b67e5..efeed045c 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -8,6 +8,6 @@ "name": "TEMPLATE_NAME", "description": "Description", "dataprovider": "Example_SRV_DEF", - "embed": "doNotEmbedFonts", - "mirroring": "mirroringInRtlLanguages" + "embed": "", + "mirroring": "" } From d29b78f2be5d08a0750b91ce8217a2092752a1b3 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Thu, 9 Nov 2023 09:05:06 +0100 Subject: [PATCH 06/30] Update z_aff_example_sfpf.sfpf.json --- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index efeed045c..9c17cab5d 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -8,6 +8,6 @@ "name": "TEMPLATE_NAME", "description": "Description", "dataprovider": "Example_SRV_DEF", - "embed": "", - "mirroring": "" + "embed": "false", + "mirroring": "false" } From 614108adc5dc184666f185a29c27d40607b89e96 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Thu, 9 Nov 2023 09:07:04 +0100 Subject: [PATCH 07/30] Update z_aff_example_sfpf.sfpf.json --- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index 9c17cab5d..ea0bf959b 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -8,6 +8,6 @@ "name": "TEMPLATE_NAME", "description": "Description", "dataprovider": "Example_SRV_DEF", - "embed": "false", - "mirroring": "false" + "embed": false, + "mirroring": false } From 88cde1418716789f6f1ba1b030f6364cb833be4d Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:04:04 +0100 Subject: [PATCH 08/30] Add files via upload --- .../sfpf/type/zif_aff_sfpf_v1.intf.abap | 57 ++++++++++++------- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index a85192132..dafaf21a0 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -1,5 +1,38 @@ INTERFACE zif_aff_sfpf_v1 - PUBLIC. + PUBLIC . + TYPES: + "!

Header for SFPF Objects

+ BEGIN OF ty_header, + "!

Description

+ "! Description of the Form Template + description TYPE c LENGTH 60, + "!

Original language

+ "! $required + original_language TYPE zif_aff_types_v1=>ty_original_language, + "! $values {@link zif_aff_types_v1.data:co_abap_language_version_cloud} + "! $default {@link zif_aff_types_v1.data:co_abap_language_version_cloud.cloud_development} + abap_language_version TYPE zif_aff_types_v1=>ty_abap_language_version, + END OF ty_header, + + BEGIN OF ty_properties, + "!

Name

+ "! Name of the Form Template + "! $required + name TYPE c LENGTH 30, + "!

Dataprovider

+ "! RAP Service Definition that implements the business context for this form template + dataprovider TYPE c LENGTH 40, + "!

Font Embed

+ "! Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, for asian fonts or to include your own branding. + embed TYPE abap_boolean, + "!

Mirror in RTL

+ "! When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output? + mirroring TYPE abap_boolean, + "!

FDP Data Optimization

+ "! When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output? + optimize TYPE abap_boolean, + END OF ty_properties. + TYPES: "!

Object Type SFPF

"! Object type SFPF @@ -11,24 +44,10 @@ INTERFACE zif_aff_sfpf_v1 "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_60, - "!

Name

- "! Name + header TYPE ty_header, + "!

Properties

+ "! Form Template Properties "! $required - name TYPE c LENGTH 30, - "!

Description

- "! Description - "! $required - description TYPE c LENGTH 60, - "!

Dataprovider

- "! Dataprovider - "! $required - dataprovider TYPE c LENGTH 40, - "!

Font Embed

- "! Font Embed - embed TYPE abap_bool, - "!

Mirror in RTL

- "! Mirror in RTL - mirroring TYPE abap_bool, + properties TYPE ty_properties, END OF ty_main. ENDINTERFACE. From 06fa1d3ef6f94224d70484190ce883bed928bc06 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:06:09 +0100 Subject: [PATCH 09/30] Update z_aff_example_sfpf.sfpf.json --- .../sfpf/examples/z_aff_example_sfpf.sfpf.json | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index ea0bf959b..c84f02220 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -5,9 +5,11 @@ "originalLanguage": "en", "abapLanguageVersion": "cloudDevelopment" }, - "name": "TEMPLATE_NAME", - "description": "Description", - "dataprovider": "Example_SRV_DEF", - "embed": false, - "mirroring": false + "properties": { + "name": "TEMPLATE_NAME", + "dataprovider": "Example_SRV_DEF", + "embed": false, + "mirroring": false, + "optimize": false + } } From 91ea513dccd254da50d7213f2f2a99a4d6b179fa Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:07:20 +0100 Subject: [PATCH 10/30] Add files via upload --- file-formats/sfpf/sfpf-v1.json | 79 ++++++++++++++++++---------------- 1 file changed, 41 insertions(+), 38 deletions(-) diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index bff7c86bd..a0b04286f 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -19,13 +19,12 @@ "properties": { "description": { "title": "Description", - "description": "Description of the ABAP object", + "description": "Description of the Form Template", "type": "string", "maxLength": 60 }, "originalLanguage": { - "title": "Original Language", - "description": "Original language of the ABAP object", + "title": "Original language", "type": "string", "minLength": 2, "maxLength": 2, @@ -37,63 +36,67 @@ "type": "string", "enum": [ "standard", - "keyUser", "cloudDevelopment" ], "enumTitles": [ "Standard", - "ABAP for Key Users", "ABAP Cloud Development" ], "enumDescriptions": [ "Standard", - "ABAP for key user extensibility", "ABAP cloud development" ], - "default": "standard" + "default": "cloudDevelopment" } }, "additionalProperties": false, "required": [ - "description", "originalLanguage" ] }, - "name": { - "title": "Name", - "description": "Name", - "type": "string", - "maxLength": 30 - }, - "description": { - "title": "Description", - "description": "Description", - "type": "string", - "maxLength": 60 - }, - "dataprovider": { - "title": "Dataprovider", - "description": "Dataprovider", - "type": "string", - "maxLength": 40 - }, - "embed": { - "title": "Font Embed", - "description": "Font Embed", - "type": "boolean" - }, - "mirroring": { - "title": "Mirror in RTL", - "description": "Mirror in RTL", - "type": "boolean" + "properties": { + "title": "Properties", + "description": "Form Template Properties", + "type": "object", + "properties": { + "name": { + "title": "Name", + "description": "Name of the Form Template", + "type": "string", + "maxLength": 30 + }, + "dataprovider": { + "title": "Dataprovider", + "description": "RAP Service Definition that implements the business context for this form template", + "type": "string", + "maxLength": 40 + }, + "embed": { + "title": "Font Embed", + "description": "Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, for asian fonts or to include your own branding.", + "type": "boolean" + }, + "mirroring": { + "title": "Mirror in RTL", + "description": "When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output?", + "type": "boolean" + }, + "optimize": { + "title": "FDP Data Optimization", + "description": "When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output?", + "type": "boolean" + } + }, + "additionalProperties": false, + "required": [ + "name" + ] } }, "additionalProperties": false, "required": [ "formatVersion", "header", - "name", - "description", - "dataprovider" + "properties" ] } From 7b4c82ce5e4d0c4030df3326d9361ff41fdf3098 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:08:11 +0100 Subject: [PATCH 11/30] Update file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index dafaf21a0..c7a67c977 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -1,5 +1,5 @@ INTERFACE zif_aff_sfpf_v1 - PUBLIC . + PUBLIC. TYPES: "!

Header for SFPF Objects

BEGIN OF ty_header, From 23c734d46deb3f7633a5336d173e1153cdf51973 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:14:58 +0100 Subject: [PATCH 12/30] Update zif_aff_sfpf_v1.intf.abap --- .../sfpf/type/zif_aff_sfpf_v1.intf.abap | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index c7a67c977..e7efa5a6c 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -23,14 +23,17 @@ INTERFACE zif_aff_sfpf_v1 "! RAP Service Definition that implements the business context for this form template dataprovider TYPE c LENGTH 40, "!

Font Embed

- "! Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, for asian fonts or to include your own branding. - embed TYPE abap_boolean, + "! Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, + !" for asian fonts or to include your own branding. + embed TYPE abap_bool, "!

Mirror in RTL

- "! When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output? - mirroring TYPE abap_boolean, - "!

FDP Data Optimization

- "! When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output? - optimize TYPE abap_boolean, + "! When your form template is designed in an LTR language and your target output is an RTL language, + "! should fields be automatically be mirrord in the output? + mirroring TYPE abap_bool, + "!

Optimize

+ "! Automatically analyze the data binding of the template and only select + "! necessary fields from the business data input of the FDP + optimize TYPE abap_bool, END OF ty_properties. TYPES: From 8ba49420889833d73dc769f6b813c87a1c95f50a Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:15:23 +0100 Subject: [PATCH 13/30] Update file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index e7efa5a6c..4af1b13a6 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -23,7 +23,7 @@ INTERFACE zif_aff_sfpf_v1 "! RAP Service Definition that implements the business context for this form template dataprovider TYPE c LENGTH 40, "!

Font Embed

- "! Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, + "! Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, !" for asian fonts or to include your own branding. embed TYPE abap_bool, "!

Mirror in RTL

From 3e7bf5fe69229c79a09c08422699340bfced5a36 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:18:17 +0100 Subject: [PATCH 14/30] Update zif_aff_sfpf_v1.intf.abap --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index 4af1b13a6..54a4d5fc0 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -23,11 +23,12 @@ INTERFACE zif_aff_sfpf_v1 "! RAP Service Definition that implements the business context for this form template dataprovider TYPE c LENGTH 40, "!

Font Embed

- "! Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, - !" for asian fonts or to include your own branding. + "! Automatically embed font files into the output. + "! Useful if your output uses fonts that are not delivered by default, + "! for asian fonts or to include your own branding. embed TYPE abap_bool, - "!

Mirror in RTL

- "! When your form template is designed in an LTR language and your target output is an RTL language, + "!

Mirroring

+ "! When your form template is designed in an LTR language and your target output is an RTL language, "! should fields be automatically be mirrord in the output? mirroring TYPE abap_bool, "!

Optimize

From 4a843e350f6af8ee672acf0ee60dcb954578528b Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:22:13 +0100 Subject: [PATCH 15/30] Update zif_aff_sfpf_v1.intf.abap --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index 54a4d5fc0..9247bf54c 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -29,7 +29,7 @@ INTERFACE zif_aff_sfpf_v1 embed TYPE abap_bool, "!

Mirroring

"! When your form template is designed in an LTR language and your target output is an RTL language, - "! should fields be automatically be mirrord in the output? + "! should fields be automatically mirrord in the output? mirroring TYPE abap_bool, "!

Optimize

"! Automatically analyze the data binding of the template and only select From 72f9f26a3cb2bf60d7f94af36aefe8c8fb9ae795 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:27:17 +0100 Subject: [PATCH 16/30] Update z_aff_example_sfpf.sfpf.json --- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index c84f02220..3126d88fd 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -5,7 +5,7 @@ "originalLanguage": "en", "abapLanguageVersion": "cloudDevelopment" }, - "properties": { + "props": { "name": "TEMPLATE_NAME", "dataprovider": "Example_SRV_DEF", "embed": false, From 9ad7b9263947566b64088dc4bfd804e6af319afa Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:27:39 +0100 Subject: [PATCH 17/30] Update sfpf-v1.json --- file-formats/sfpf/sfpf-v1.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index a0b04286f..b6e4df47f 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -54,7 +54,7 @@ "originalLanguage" ] }, - "properties": { + "props": { "title": "Properties", "description": "Form Template Properties", "type": "object", @@ -97,6 +97,6 @@ "required": [ "formatVersion", "header", - "properties" + "props" ] } From 204318beda9529e9ecddcf9afb56752e91082ea7 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:27:54 +0100 Subject: [PATCH 18/30] Update zif_aff_sfpf_v1.intf.abap --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index 9247bf54c..9df5660c6 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -52,6 +52,6 @@ INTERFACE zif_aff_sfpf_v1 "!

Properties

"! Form Template Properties "! $required - properties TYPE ty_properties, + props TYPE ty_properties, END OF ty_main. ENDINTERFACE. From 1ca98be7dbbbcce825455cde24a8edfe54ce0c49 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Tue, 28 Nov 2023 16:37:34 +0100 Subject: [PATCH 19/30] Add files via upload --- .../sfpf/examples/z_aff_example_sfpf.sfpf.xdp | 89 +++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.xdp diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.xdp b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.xdp new file mode 100644 index 000000000..b077af286 --- /dev/null +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.xdp @@ -0,0 +1,89 @@ + + + + + + + + pdf + + + + + + + + pdf + + + + 0 + + 0 + 1.7 + 8 + + + * + + + + + + + + 2023-11-28T15:36:44Z + Adobe LiveCycle Designer 11.0 + 1 + Adobe LiveCycle Designer 11.0 + uuid:6bbc0415-1ddf-4e6d-8fb1-2d0d63b53cfa + + 11.0.9.20230302.1.6.0 + /template/subform[1] + + + + From cb1ffdd00babc9624015253d01d36c2690c85fed Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Fri, 1 Dec 2023 13:11:03 +0100 Subject: [PATCH 20/30] Add files via upload --- file-formats/sfpf/sfpf-v1.json | 41 ++++++++++++++-------------------- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index b6e4df47f..e48f8958f 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -19,12 +19,13 @@ "properties": { "description": { "title": "Description", - "description": "Description of the Form Template", + "description": "Description of the ABAP object", "type": "string", "maxLength": 60 }, "originalLanguage": { - "title": "Original language", + "title": "Original Language", + "description": "Original language of the ABAP object", "type": "string", "minLength": 2, "maxLength": 2, @@ -46,57 +47,49 @@ "Standard", "ABAP cloud development" ], - "default": "cloudDevelopment" + "default": "standard" } }, "additionalProperties": false, "required": [ + "description", "originalLanguage" ] }, - "props": { - "title": "Properties", - "description": "Form Template Properties", + "generalInformation": { + "title": "General Information", + "description": "General Information", "type": "object", "properties": { - "name": { - "title": "Name", - "description": "Name of the Form Template", - "type": "string", - "maxLength": 30 - }, "dataprovider": { "title": "Dataprovider", "description": "RAP Service Definition that implements the business context for this form template", "type": "string", "maxLength": 40 }, - "embed": { + "fontEmbed": { "title": "Font Embed", "description": "Automatically embed font files into the output. Useful if your output uses fonts that are not delivered by default, for asian fonts or to include your own branding.", "type": "boolean" }, - "mirroring": { - "title": "Mirror in RTL", - "description": "When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output?", + "layoutMirroring": { + "title": "Layout Mirroring", + "description": "When activated if your form template is designed in an LTR language and your target output is an RTL language, layout will be automatically mirrored in the output.", "type": "boolean" }, - "optimize": { - "title": "FDP Data Optimization", - "description": "When your form template is designed in an LTR language and your target output is an RTL language, should fields be automatically be mirrord in the output?", + "reduceDataVol": { + "title": "Reduce Data Volume", + "description": "Reduce data input volume based on the form design", "type": "boolean" } }, - "additionalProperties": false, - "required": [ - "name" - ] + "additionalProperties": false } }, "additionalProperties": false, "required": [ "formatVersion", "header", - "props" + "generalInformation" ] } From 89ef822a5f49a6b1a4dcf9457c1237dd4dec24ef Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Fri, 1 Dec 2023 13:11:35 +0100 Subject: [PATCH 21/30] Add files via upload --- .../sfpf/type/zif_aff_sfpf_v1.intf.abap | 47 ++++++------------- 1 file changed, 15 insertions(+), 32 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index 9df5660c6..898cacf5c 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -1,24 +1,7 @@ INTERFACE zif_aff_sfpf_v1 PUBLIC. TYPES: - "!

Header for SFPF Objects

- BEGIN OF ty_header, - "!

Description

- "! Description of the Form Template - description TYPE c LENGTH 60, - "!

Original language

- "! $required - original_language TYPE zif_aff_types_v1=>ty_original_language, - "! $values {@link zif_aff_types_v1.data:co_abap_language_version_cloud} - "! $default {@link zif_aff_types_v1.data:co_abap_language_version_cloud.cloud_development} - abap_language_version TYPE zif_aff_types_v1=>ty_abap_language_version, - END OF ty_header, - - BEGIN OF ty_properties, - "!

Name

- "! Name of the Form Template - "! $required - name TYPE c LENGTH 30, + BEGIN OF ty_general_information, "!

Dataprovider

"! RAP Service Definition that implements the business context for this form template dataprovider TYPE c LENGTH 40, @@ -26,16 +9,16 @@ INTERFACE zif_aff_sfpf_v1 "! Automatically embed font files into the output. "! Useful if your output uses fonts that are not delivered by default, "! for asian fonts or to include your own branding. - embed TYPE abap_bool, - "!

Mirroring

- "! When your form template is designed in an LTR language and your target output is an RTL language, - "! should fields be automatically mirrord in the output? - mirroring TYPE abap_bool, - "!

Optimize

- "! Automatically analyze the data binding of the template and only select - "! necessary fields from the business data input of the FDP - optimize TYPE abap_bool, - END OF ty_properties. + font_embed TYPE abap_bool, + "!

Layout Mirroring

+ "! When activated if your form template is designed in an LTR language + "! and your target output is an RTL language, + "! layout will be automatically mirrored in the output. + layout_mirroring TYPE abap_bool, + "!

Reduce Data Volume

+ "! Reduce data input volume based on the form design + reduce_data_vol TYPE abap_bool, + END OF ty_general_information. TYPES: "!

Object Type SFPF

@@ -48,10 +31,10 @@ INTERFACE zif_aff_sfpf_v1 "!

Header

"! Header "! $required - header TYPE ty_header, - "!

Properties

- "! Form Template Properties + header TYPE zif_aff_types_v1=>ty_header_60_cloud, + "!

General Information

+ "! General Information "! $required - props TYPE ty_properties, + general_information TYPE ty_general_information, END OF ty_main. ENDINTERFACE. From 860ccdfebcf32a9758dfbaee5c16cc2cd1fec492 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Fri, 1 Dec 2023 13:12:38 +0100 Subject: [PATCH 22/30] Update z_aff_example_sfpf.sfpf.json --- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index 3126d88fd..c0cf1feba 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -5,11 +5,10 @@ "originalLanguage": "en", "abapLanguageVersion": "cloudDevelopment" }, - "props": { - "name": "TEMPLATE_NAME", + "generalInformation": { "dataprovider": "Example_SRV_DEF", - "embed": false, - "mirroring": false, - "optimize": false + "fontEmbed": false, + "layoutMirroring": false, + "reduceDataVol": false } } From b3b9ff1d1976b9617cfde27772757e66882ca324 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Fri, 1 Dec 2023 13:21:17 +0100 Subject: [PATCH 23/30] Update README.md --- file-formats/sfpf/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/README.md b/file-formats/sfpf/README.md index 11c6b094f..f0073ed5c 100644 --- a/file-formats/sfpf/README.md +++ b/file-formats/sfpf/README.md @@ -2,4 +2,4 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf.json) +`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf.json) / [`z_aff_example_sfpf.sfpf.xdp`](./examples/z_aff_example_sfpf.sfpf.xdp) From 7f62c620d82d403e1de8e206f0e5cff517042afe Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Fri, 1 Dec 2023 16:45:23 +0100 Subject: [PATCH 24/30] Update README.md --- file-formats/sfpf/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/file-formats/sfpf/README.md b/file-formats/sfpf/README.md index f0073ed5c..1b838a356 100644 --- a/file-formats/sfpf/README.md +++ b/file-formats/sfpf/README.md @@ -2,4 +2,5 @@ File | Cardinality | Definition | Schema | Example :--- | :--- | :--- | :--- | :--- -`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf.json) / [`z_aff_example_sfpf.sfpf.xdp`](./examples/z_aff_example_sfpf.sfpf.xdp) +`.sfpf.json` | 1 | [`zif_aff_sfpf_v1.intf.abap`](./type/zif_aff_sfpf_v1.intf.abap) | [`sfpf-v1.json`](./sfpf-v1.json) | [`z_aff_example_sfpf.sfpf.json`](./examples/z_aff_example_sfpf.sfpf.json) +`.sfpf.xdp` | 1 | [`XFA-3_3`](https://www.pdfa.org/norm-refs/XFA-3_3.pdf) | - | [`z_aff_example_sfpf.sfpf.xdp`](./examples/z_aff_example_sfpf.sfpf.xdp) From 88735699e4abb5621afa7001916de5fc2c2f647b Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:36:51 +0100 Subject: [PATCH 25/30] Add files via upload --- file-formats/sfpf/sfpf-v1.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index e48f8958f..c1c4c4aff 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -77,7 +77,7 @@ "description": "When activated if your form template is designed in an LTR language and your target output is an RTL language, layout will be automatically mirrored in the output.", "type": "boolean" }, - "reduceDataVol": { + "reduceDataVolume": { "title": "Reduce Data Volume", "description": "Reduce data input volume based on the form design", "type": "boolean" From d3b92c5a6e6e4fe6e47456322f5dd1d2d136b372 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:37:14 +0100 Subject: [PATCH 26/30] Add files via upload --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index 898cacf5c..7ad7a5221 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -4,20 +4,20 @@ INTERFACE zif_aff_sfpf_v1 BEGIN OF ty_general_information, "!

Dataprovider

"! RAP Service Definition that implements the business context for this form template - dataprovider TYPE c LENGTH 40, + dataprovider TYPE c LENGTH 40, "!

Font Embed

"! Automatically embed font files into the output. "! Useful if your output uses fonts that are not delivered by default, "! for asian fonts or to include your own branding. - font_embed TYPE abap_bool, + font_embed TYPE abap_bool, "!

Layout Mirroring

"! When activated if your form template is designed in an LTR language "! and your target output is an RTL language, "! layout will be automatically mirrored in the output. - layout_mirroring TYPE abap_bool, + layout_mirroring TYPE abap_bool, "!

Reduce Data Volume

"! Reduce data input volume based on the form design - reduce_data_vol TYPE abap_bool, + reduce_data_volume TYPE abap_bool, END OF ty_general_information. TYPES: @@ -27,14 +27,14 @@ INTERFACE zif_aff_sfpf_v1 "!

Format Version

"! Format version "! $required - format_version TYPE zif_aff_types_v1=>ty_format_version, + format_version TYPE zif_aff_types_v1=>ty_format_version, "!

Header

"! Header "! $required - header TYPE zif_aff_types_v1=>ty_header_60_cloud, + header TYPE zif_aff_types_v1=>ty_header_60_cloud, "!

General Information

"! General Information "! $required - general_information TYPE ty_general_information, + general_information TYPE ty_general_information, END OF ty_main. ENDINTERFACE. From 41596f983b6a7005126289a5a0ecc9568bbb07b2 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Wed, 6 Dec 2023 17:37:37 +0100 Subject: [PATCH 27/30] Update z_aff_example_sfpf.sfpf.json --- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index c0cf1feba..cbd4b8cc6 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -9,6 +9,6 @@ "dataprovider": "Example_SRV_DEF", "fontEmbed": false, "layoutMirroring": false, - "reduceDataVol": false + "reduceDataVolume": false } } From 3bc02fcc1b462db091a9e4f919b8644b1b2a6e41 Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Wed, 10 Apr 2024 17:29:17 +0200 Subject: [PATCH 28/30] Fix schema due to changes in issue #582 --- file-formats/sfpf/sfpf-v1.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index c1c4c4aff..c6b5bb5b5 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -27,9 +27,7 @@ "title": "Original Language", "description": "Original language of the ABAP object", "type": "string", - "minLength": 2, - "maxLength": 2, - "pattern": "^[a-z]+$" + "minLength": 2 }, "abapLanguageVersion": { "title": "ABAP Language Version", From 3b4af15b72397beafacf6caf0b71f3a68a9d58e9 Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Mon, 27 May 2024 17:17:27 +0200 Subject: [PATCH 29/30] Update file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap Co-authored-by: Albert Mink --- file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap index 7ad7a5221..48e65e328 100644 --- a/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap +++ b/file-formats/sfpf/type/zif_aff_sfpf_v1.intf.abap @@ -2,9 +2,9 @@ INTERFACE zif_aff_sfpf_v1 PUBLIC. TYPES: BEGIN OF ty_general_information, - "!

Dataprovider

+ "!

Data Provider

"! RAP Service Definition that implements the business context for this form template - dataprovider TYPE c LENGTH 40, + data_provider TYPE c LENGTH 40, "!

Font Embed

"! Automatically embed font files into the output. "! Useful if your output uses fonts that are not delivered by default, From a8d14b487138c1aa683f7f8d9f0f6c05a40f586d Mon Sep 17 00:00:00 2001 From: Pascal Maximilian Bremer <8161919+Bomberus@users.noreply.github.com> Date: Mon, 27 May 2024 17:23:00 +0200 Subject: [PATCH 30/30] fix typo dataprovider --- file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json | 2 +- file-formats/sfpf/sfpf-v1.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json index cbd4b8cc6..d07cdbf89 100644 --- a/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json +++ b/file-formats/sfpf/examples/z_aff_example_sfpf.sfpf.json @@ -6,7 +6,7 @@ "abapLanguageVersion": "cloudDevelopment" }, "generalInformation": { - "dataprovider": "Example_SRV_DEF", + "dataProvider": "Example_SRV_DEF", "fontEmbed": false, "layoutMirroring": false, "reduceDataVolume": false diff --git a/file-formats/sfpf/sfpf-v1.json b/file-formats/sfpf/sfpf-v1.json index c6b5bb5b5..30a1a033d 100644 --- a/file-formats/sfpf/sfpf-v1.json +++ b/file-formats/sfpf/sfpf-v1.json @@ -59,8 +59,8 @@ "description": "General Information", "type": "object", "properties": { - "dataprovider": { - "title": "Dataprovider", + "dataProvider": { + "title": "Data Provider", "description": "RAP Service Definition that implements the business context for this form template", "type": "string", "maxLength": 40