From 0793f918952589c5c564a1651e8819689658985e Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Mon, 1 Jul 2024 13:46:18 +0530
Subject: [PATCH 01/26] Add files for EDCK and EDCR

---
 file-formats/edck/README.md                   |   5 +
 file-formats/edck/edck-v1.json                | 127 ++++++++++++++++++
 .../edck/type/zif_aff_edck_v1.intf.abap       |  73 ++++++++++
 .../edck/type/zif_aff_edck_v1.intf.json       |   7 +
 file-formats/edcr/.DS_Store                   | Bin 0 -> 6148 bytes
 file-formats/edcr/edcr-v1.json                |  63 +++++++++
 .../edcr/type/zif_aff_edcr_v1.intf.abap       |  14 ++
 .../edcr/type/zif_aff_edcr_v1.intf.json       |   7 +
 8 files changed, 296 insertions(+)
 create mode 100644 file-formats/edck/README.md
 create mode 100644 file-formats/edck/edck-v1.json
 create mode 100644 file-formats/edck/type/zif_aff_edck_v1.intf.abap
 create mode 100644 file-formats/edck/type/zif_aff_edck_v1.intf.json
 create mode 100644 file-formats/edcr/.DS_Store
 create mode 100644 file-formats/edcr/edcr-v1.json
 create mode 100644 file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
 create mode 100644 file-formats/edcr/type/zif_aff_edcr_v1.intf.json

diff --git a/file-formats/edck/README.md b/file-formats/edck/README.md
new file mode 100644
index 000000000..6f471a428
--- /dev/null
+++ b/file-formats/edck/README.md
@@ -0,0 +1,5 @@
+# EDCK File Format
+
+File | Cardinality | Definition | Schema | Example
+:--- | :--- | :--- | :--- | :---
+`<name>.edck.json` | 1 | [`zif_aff_edck_v1.intf.abap`](./type/zif_aff_edck_v1.intf.abap) | [`edck-v1.json`](./edck-v1.json) | [`z_aff_example_edck.edck.json`](./examples/z_aff_example_edck.edck.json)
diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
new file mode 100644
index 000000000..929cb3236
--- /dev/null
+++ b/file-formats/edck/edck-v1.json
@@ -0,0 +1,127 @@
+{
+  "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edck/edck-v1.json",
+  "title": "Consistency Check ID",
+  "description": "Check ID (EDCK) v1",
+  "type": "object",
+  "properties": {
+    "formatVersion": {
+      "title": "ABAP File Format Version",
+      "description": "The ABAP file format version",
+      "type": "string",
+      "const": "1"
+    },
+    "header": {
+      "title": "Header",
+      "description": "Header",
+      "type": "object",
+      "properties": {
+        "description": {
+          "title": "Description",
+          "description": "Description of the ABAP object",
+          "type": "string",
+          "maxLength": 60
+        },
+        "originalLanguage": {
+          "title": "Original Language",
+          "description": "Original language of the ABAP object",
+          "type": "string",
+          "minLength": 2
+        },
+        "abapLanguageVersion": {
+          "title": "ABAP Language Version",
+          "description": "ABAP language version",
+          "type": "string",
+          "enum": [
+            "standard",
+            "cloudDevelopment"
+          ],
+          "enumTitles": [
+            "Standard",
+            "ABAP Cloud Development"
+          ],
+          "enumDescriptions": [
+            "Standard",
+            "ABAP cloud development"
+          ],
+          "default": "standard"
+        }
+      },
+      "additionalProperties": false,
+      "required": [
+        "description",
+        "originalLanguage"
+      ]
+    },
+    "attributes": {
+      "title": "Check ID Definition",
+      "description": "Attributes of a Consistency Check",
+      "type": "object",
+      "properties": {
+        "checkcategory": {
+          "title": "Check Category",
+          "description": "Consistency Check Category",
+          "type": "string",
+          "enum": [
+            "exist",
+            "status",
+            "edochk",
+            "conmis"
+          ],
+          "enumTitles": [
+            "Existence Check",
+            "Status Check",
+            "Edocument Existence Check",
+            "Content Mismatch"
+          ],
+          "enumDescriptions": [
+            "Existence Check",
+            "Status Check",
+            "Edocument Existence Check",
+            "Content Mismatch"
+          ]
+        },
+        "checkidclassification": {
+          "title": "Check Classification",
+          "description": "Consistency Check ID Classification",
+          "type": "string",
+          "enum": [
+            "core",
+            "additional"
+          ],
+          "enumTitles": [
+            "Core delivered checks",
+            "Additionally (Extended) implemented checks"
+          ],
+          "enumDescriptions": [
+            "Core delivered checks",
+            "Additionally (Extended) implemented checks"
+          ]
+        },
+        "checkclass": {
+          "title": "Additional Check Class",
+          "description": "Consistency Check Class",
+          "type": "string",
+          "maxLength": 30
+        },
+        "resultderivationindicator": {
+          "title": "Result Derivation Indicator",
+          "description": "Result Process Derived by BAdI",
+          "type": "boolean"
+        }
+      },
+      "additionalProperties": false,
+      "required": [
+        "checkcategory",
+        "checkidclassification"
+      ]
+    }
+  },
+  "additionalProperties": false,
+  "required": [
+    "formatVersion",
+    "header",
+    "attributes"
+  ]
+}
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
new file mode 100644
index 000000000..5857688eb
--- /dev/null
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -0,0 +1,73 @@
+INTERFACE zif_aff_edck_v1
+  PUBLIC .
+  TYPES ty_check_classification TYPE c LENGTH 1.
+  TYPES ty_check_category TYPE c LENGTH 6.
+
+  TYPES:
+    BEGIN OF ty_attributes,
+      "! <p class="shorttext">Check Category</p>
+      "! Consistency Check Category
+      "! $values {@link zif_aff_edck_v1.data:co_check_category}
+      "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
+      "! $required
+      CheckCategory             TYPE ty_check_category,
+      "! <p class="shorttext">Check Classification</p>
+      "! Consistency Check ID Classification
+      "! $values {@link zif_aff_edck_v1.data:co_check_classification}
+      "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
+      "! $required
+      CheckIdClassification     TYPE ty_check_classification,
+      "! <p class="shorttext">Additional Check Class</p>
+      "! Consistency Check Class
+      CheckClass                TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Result Derivation Indicator</p>
+      "! Result Process Derived by BAdI
+      ResultDerivationIndicator TYPE abap_bool,
+    END OF ty_Attributes.
+
+  TYPES:
+    "! <p class="shorttext">Consistency Check ID</p>
+    "! Check ID (EDCK) v1
+    BEGIN OF ty_main,
+      "! $required
+      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      "! <p class="shorttext">Header</p>
+      "! Header
+      "! $required
+      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      "! <p class="shorttext">Check ID Definition</p>
+      "! Attributes of a Consistency Check
+      "! $required
+      attributes     TYPE ty_attributes,
+    END OF ty_main.
+
+  CONSTANTS:
+    "! <p class="shorttext">Check Classification</p>
+    "! Check Classification
+    BEGIN OF co_check_classification,
+      "! <p class="shorttext">Core delivered checks</p>
+      "! Core delivered checks
+      core       TYPE ty_check_classification VALUE 'C',
+      "! <p class="shorttext">Additionally (Extended) implemented checks</p>
+      "! Additionally (Extended) implemented checks
+      Additional TYPE ty_check_classification VALUE 'A',
+    END OF co_check_classification.
+
+  CONSTANTS:
+    "! <p class="shorttext">Check Category</p>
+    "! Check Category
+    BEGIN OF co_check_category,
+      "! <p class="shorttext">Existence Check</p>
+      "! Existence Check
+      Exist  TYPE ty_check_category VALUE 'EXIST',
+      "! <p class="shorttext">Status Check</p>
+      "! Status Check
+      status TYPE ty_check_category VALUE 'STATUS',
+      "! <p class="shorttext">Edocument Existence Check</p>
+      "! Edocument Existence Check
+      edochk TYPE ty_check_category VALUE 'EDOCHK',
+      "! <p class="shorttext"> Content Mismatch</p>
+      "!  Content Mismatch
+      conmis TYPE ty_check_category VALUE 'CONMIS',
+    END OF co_check_category.
+ENDINTERFACE.
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.json b/file-formats/edck/type/zif_aff_edck_v1.intf.json
new file mode 100644
index 000000000..59f7f02e7
--- /dev/null
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.json
@@ -0,0 +1,7 @@
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "AFF type for EDCK",
+    "originalLanguage": "en"
+  }
+}
diff --git a/file-formats/edcr/.DS_Store b/file-formats/edcr/.DS_Store
new file mode 100644
index 0000000000000000000000000000000000000000..5f3235c0e6b2f5fabc3f657cf817c577473caf1f
GIT binary patch
literal 6148
zcmeHKu};H447DLcB$ke_-OSdB^{B$i(jP#jhz^aC0S2~g{j-jI6VLWhwF*IEK>|HX
zzL&H8a>*OwSVVO3x}J;7M5Klr%FdRtS>AkPXC+br)$Xx<o-ZG}wjWha2aH?Ei@ZrM
zPhap4xwdPX)wWxqzP^6n+}vO7Z;!ccxBfQYZ+`r2(@)I|6`%rCfC^B7zpDUxwpo1<
z$dw9E0V;4%z`hR&ZkP)Wf&S^h;v)die&gM6?Xv_hSpb*|4uOckG^oI!Y8f#!=!mCM
zmkSPoK^OItai4OsmI+1ubi|XFi{?PCRDcScDsUd#nf3oW_{98wO5%<RP=SA?fL6`2
zS>TmQZymjy_1Xk~fPWfly&Q|TVxYHTY^)Vu9@QngMm`rD0-cVy(}DaEFkNU=;5QWb
E0K%{*L;wH)

literal 0
HcmV?d00001

diff --git a/file-formats/edcr/edcr-v1.json b/file-formats/edcr/edcr-v1.json
new file mode 100644
index 000000000..e171fe1c8
--- /dev/null
+++ b/file-formats/edcr/edcr-v1.json
@@ -0,0 +1,63 @@
+{
+  "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edcr/edcr-v1.json",
+  "title": "Representation Type",
+  "description": "Representation Type (EDCR) v1",
+  "type": "object",
+  "properties": {
+    "formatVersion": {
+      "title": "ABAP File Format Version",
+      "description": "The ABAP file format version",
+      "type": "string",
+      "const": "1"
+    },
+    "header": {
+      "title": "Header",
+      "description": "Header",
+      "type": "object",
+      "properties": {
+        "description": {
+          "title": "Description",
+          "description": "Description of the ABAP object",
+          "type": "string",
+          "maxLength": 60
+        },
+        "originalLanguage": {
+          "title": "Original Language",
+          "description": "Original language of the ABAP object",
+          "type": "string",
+          "minLength": 2
+        },
+        "abapLanguageVersion": {
+          "title": "ABAP Language Version",
+          "description": "ABAP language version",
+          "type": "string",
+          "enum": [
+            "standard",
+            "cloudDevelopment"
+          ],
+          "enumTitles": [
+            "Standard",
+            "ABAP Cloud Development"
+          ],
+          "enumDescriptions": [
+            "Standard",
+            "ABAP cloud development"
+          ],
+          "default": "standard"
+        }
+      },
+      "additionalProperties": false,
+      "required": [
+        "description",
+        "originalLanguage"
+      ]
+    }
+  },
+  "additionalProperties": false,
+  "required": [
+    "formatVersion",
+    "header"
+  ]
+}
diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
new file mode 100644
index 000000000..ddd5cd8d6
--- /dev/null
+++ b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
@@ -0,0 +1,14 @@
+interface ZIF_AFF_EDCR_V1
+  public .
+ TYPES:
+    "! <p class="shorttext">Representation Type</p>
+    "! Representation Type (EDCR) v1
+    BEGIN OF ty_main,
+      "! $required
+      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      "! <p class="shorttext">Header</p>
+      "! Header
+      "! $required
+      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+    END OF ty_main.
+endinterface.
diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.json b/file-formats/edcr/type/zif_aff_edcr_v1.intf.json
new file mode 100644
index 000000000..62a97b841
--- /dev/null
+++ b/file-formats/edcr/type/zif_aff_edcr_v1.intf.json
@@ -0,0 +1,7 @@
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "AFF type for EDCR",
+    "originalLanguage": "en"
+  }
+}

From 09c7a8b087f31b531cf91d6683f6b8e1bce32cda Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Wed, 3 Jul 2024 13:40:45 +0530
Subject: [PATCH 02/26] Abaplint fix

---
 file-formats/edck/README.md                   |  2 +-
 .../edck/type/zif_aff_edck_v1.intf.abap       | 17 ++++++-----
 file-formats/edcr/README.md                   |  5 ++++
 .../edcr/type/zif_aff_edcr_v1.intf.abap       | 29 ++++++++++---------
 4 files changed, 30 insertions(+), 23 deletions(-)
 create mode 100644 file-formats/edcr/README.md

diff --git a/file-formats/edck/README.md b/file-formats/edck/README.md
index 6f471a428..a45c4a510 100644
--- a/file-formats/edck/README.md
+++ b/file-formats/edck/README.md
@@ -2,4 +2,4 @@
 
 File | Cardinality | Definition | Schema | Example
 :--- | :--- | :--- | :--- | :---
-`<name>.edck.json` | 1 | [`zif_aff_edck_v1.intf.abap`](./type/zif_aff_edck_v1.intf.abap) | [`edck-v1.json`](./edck-v1.json) | [`z_aff_example_edck.edck.json`](./examples/z_aff_example_edck.edck.json)
+`<name>.edck.json` | 1 | [`zif_aff_edck_v1.intf.abap`](./type/zif_aff_edck_v1.intf.abap) | [`edck-v1.json`](./edck-v1.json)
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 5857688eb..61bb90daf 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -1,5 +1,6 @@
 INTERFACE zif_aff_edck_v1
-  PUBLIC .
+ PUBLIC.
+
   TYPES ty_check_classification TYPE c LENGTH 1.
   TYPES ty_check_category TYPE c LENGTH 6.
 
@@ -10,20 +11,20 @@ INTERFACE zif_aff_edck_v1
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
       "! $required
-      CheckCategory             TYPE ty_check_category,
+      checkcategory             TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency Check ID Classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
       "! $required
-      CheckIdClassification     TYPE ty_check_classification,
+      checkidclassification     TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency Check Class
-      CheckClass                TYPE zif_aff_types_v1=>ty_object_name_30,
+      checkclass                TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Result Derivation Indicator</p>
       "! Result Process Derived by BAdI
-      ResultDerivationIndicator TYPE abap_bool,
-    END OF ty_Attributes.
+      resultderivationindicator TYPE abap_bool,
+    END OF ty_attributes.
 
   TYPES:
     "! <p class="shorttext">Consistency Check ID</p>
@@ -50,7 +51,7 @@ INTERFACE zif_aff_edck_v1
       core       TYPE ty_check_classification VALUE 'C',
       "! <p class="shorttext">Additionally (Extended) implemented checks</p>
       "! Additionally (Extended) implemented checks
-      Additional TYPE ty_check_classification VALUE 'A',
+      additional TYPE ty_check_classification VALUE 'A',
     END OF co_check_classification.
 
   CONSTANTS:
@@ -59,7 +60,7 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence Check
-      Exist  TYPE ty_check_category VALUE 'EXIST',
+      exist  TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status Check
       status TYPE ty_check_category VALUE 'STATUS',
diff --git a/file-formats/edcr/README.md b/file-formats/edcr/README.md
new file mode 100644
index 000000000..a2514d89b
--- /dev/null
+++ b/file-formats/edcr/README.md
@@ -0,0 +1,5 @@
+# EDCR File Format
+
+File | Cardinality | Definition | Schema | Example
+:--- | :--- | :--- | :--- | :---
+`<name>.edcr.json` | 1 | [`zif_aff_edcr_v1.intf.abap`](./type/zif_aff_edcr_v1.intf.abap) | [`edcr-v1.json`](./edcr-v1.json)
diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
index ddd5cd8d6..ed656c45d 100644
--- a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
+++ b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
@@ -1,14 +1,15 @@
-interface ZIF_AFF_EDCR_V1
-  public .
- TYPES:
-    "! <p class="shorttext">Representation Type</p>
-    "! Representation Type (EDCR) v1
-    BEGIN OF ty_main,
-      "! $required
-      format_version TYPE zif_aff_types_v1=>ty_format_version,
-      "! <p class="shorttext">Header</p>
-      "! Header
-      "! $required
-      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
-    END OF ty_main.
-endinterface.
+INTERFACE ZIF_AFF_EDCR_V1
+ PUBLIC.
+   TYPES:
+      "! <p class="shorttext">Representation Type</p>
+      "! Representation Type (EDCR) v1
+      BEGIN OF ty_main,
+        "! $required
+        format_version TYPE zif_aff_types_v1=>ty_format_version,
+        "! <p class="shorttext">Header</p>
+        "! Header
+        "! $required
+        header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      END OF ty_main.
+
+ENDINTERFACE.

From ff8a25b6495cec978a6fbdaf445faaa724f3421d Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Wed, 3 Jul 2024 13:48:23 +0530
Subject: [PATCH 03/26] Abap lint fix for EDCR


From b2e68273b1d45856f88bd30eeb1388b670de3be8 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Wed, 3 Jul 2024 13:56:45 +0530
Subject: [PATCH 04/26] abap lint fix EDCR

---
 .../edcr/type/zif_aff_edcr_v1.intf.abap       | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
index ed656c45d..2008ad810 100644
--- a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
+++ b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
@@ -1,15 +1,16 @@
 INTERFACE ZIF_AFF_EDCR_V1
  PUBLIC.
-   TYPES:
-      "! <p class="shorttext">Representation Type</p>
-      "! Representation Type (EDCR) v1
-      BEGIN OF ty_main,
-        "! $required
-        format_version TYPE zif_aff_types_v1=>ty_format_version,
-        "! <p class="shorttext">Header</p>
-        "! Header
-        "! $required
-        header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
-      END OF ty_main.
+
+ TYPES:
+   "! <p class="shorttext">Representation Type</p>
+   "! Representation Type (EDCR) v1
+   BEGIN OF ty_main,
+     "! $required
+     format_version TYPE zif_aff_types_v1=>ty_format_version,
+     "! <p class="shorttext">Header</p>
+     "! Header
+     "! $required
+     header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+   END OF ty_main.
 
 ENDINTERFACE.

From 0ab59a34655c046f67006edce8401addff7381f5 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Wed, 3 Jul 2024 14:00:24 +0530
Subject: [PATCH 05/26] abap lint fix

---
 .../edcr/type/zif_aff_edcr_v1.intf.abap       | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
index 2008ad810..79caca103 100644
--- a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
+++ b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
@@ -1,16 +1,16 @@
 INTERFACE ZIF_AFF_EDCR_V1
- PUBLIC.
+  PUBLIC.
 
- TYPES:
-   "! <p class="shorttext">Representation Type</p>
-   "! Representation Type (EDCR) v1
-   BEGIN OF ty_main,
-     "! $required
-     format_version TYPE zif_aff_types_v1=>ty_format_version,
-     "! <p class="shorttext">Header</p>
-     "! Header
-     "! $required
-     header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
-   END OF ty_main.
+  TYPES:
+    "! <p class="shorttext">Representation Type</p>
+    "! Representation Type (EDCR) v1
+    BEGIN OF ty_main,
+      "! $required
+      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      "! <p class="shorttext">Header</p>
+      "! Header
+      "! $required
+      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+    END OF ty_main.
 
 ENDINTERFACE.

From 1b106adbdca59b654ddcc05567d718ae909a543b Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Wed, 3 Jul 2024 14:04:29 +0530
Subject: [PATCH 06/26] abap lint fix

---
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 2 +-
 file-formats/edcr/type/zif_aff_edcr_v1.intf.abap | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 61bb90daf..ad9c3da69 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -1,5 +1,5 @@
 INTERFACE zif_aff_edck_v1
- PUBLIC.
+  PUBLIC.
 
   TYPES ty_check_classification TYPE c LENGTH 1.
   TYPES ty_check_category TYPE c LENGTH 6.
diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
index 79caca103..71d450443 100644
--- a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
+++ b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
@@ -1,4 +1,4 @@
-INTERFACE ZIF_AFF_EDCR_V1
+INTERFACE zif_aff_edcr_v1
   PUBLIC.
 
   TYPES:

From faa0725378876405cbc10dc497639cdc048e42c5 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Fri, 5 Jul 2024 10:22:25 +0530
Subject: [PATCH 07/26] EDCR removed

---
 file-formats/edcr/.DS_Store                   | Bin 6148 -> 0 bytes
 file-formats/edcr/README.md                   |   5 --
 file-formats/edcr/edcr-v1.json                |  63 ------------------
 .../edcr/type/zif_aff_edcr_v1.intf.abap       |  16 -----
 .../edcr/type/zif_aff_edcr_v1.intf.json       |   7 --
 5 files changed, 91 deletions(-)
 delete mode 100644 file-formats/edcr/.DS_Store
 delete mode 100644 file-formats/edcr/README.md
 delete mode 100644 file-formats/edcr/edcr-v1.json
 delete mode 100644 file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
 delete mode 100644 file-formats/edcr/type/zif_aff_edcr_v1.intf.json

diff --git a/file-formats/edcr/.DS_Store b/file-formats/edcr/.DS_Store
deleted file mode 100644
index 5f3235c0e6b2f5fabc3f657cf817c577473caf1f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 6148
zcmeHKu};H447DLcB$ke_-OSdB^{B$i(jP#jhz^aC0S2~g{j-jI6VLWhwF*IEK>|HX
zzL&H8a>*OwSVVO3x}J;7M5Klr%FdRtS>AkPXC+br)$Xx<o-ZG}wjWha2aH?Ei@ZrM
zPhap4xwdPX)wWxqzP^6n+}vO7Z;!ccxBfQYZ+`r2(@)I|6`%rCfC^B7zpDUxwpo1<
z$dw9E0V;4%z`hR&ZkP)Wf&S^h;v)die&gM6?Xv_hSpb*|4uOckG^oI!Y8f#!=!mCM
zmkSPoK^OItai4OsmI+1ubi|XFi{?PCRDcScDsUd#nf3oW_{98wO5%<RP=SA?fL6`2
zS>TmQZymjy_1Xk~fPWfly&Q|TVxYHTY^)Vu9@QngMm`rD0-cVy(}DaEFkNU=;5QWb
E0K%{*L;wH)

diff --git a/file-formats/edcr/README.md b/file-formats/edcr/README.md
deleted file mode 100644
index a2514d89b..000000000
--- a/file-formats/edcr/README.md
+++ /dev/null
@@ -1,5 +0,0 @@
-# EDCR File Format
-
-File | Cardinality | Definition | Schema | Example
-:--- | :--- | :--- | :--- | :---
-`<name>.edcr.json` | 1 | [`zif_aff_edcr_v1.intf.abap`](./type/zif_aff_edcr_v1.intf.abap) | [`edcr-v1.json`](./edcr-v1.json)
diff --git a/file-formats/edcr/edcr-v1.json b/file-formats/edcr/edcr-v1.json
deleted file mode 100644
index e171fe1c8..000000000
--- a/file-formats/edcr/edcr-v1.json
+++ /dev/null
@@ -1,63 +0,0 @@
-{
-  "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
-  "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edcr/edcr-v1.json",
-  "title": "Representation Type",
-  "description": "Representation Type (EDCR) v1",
-  "type": "object",
-  "properties": {
-    "formatVersion": {
-      "title": "ABAP File Format Version",
-      "description": "The ABAP file format version",
-      "type": "string",
-      "const": "1"
-    },
-    "header": {
-      "title": "Header",
-      "description": "Header",
-      "type": "object",
-      "properties": {
-        "description": {
-          "title": "Description",
-          "description": "Description of the ABAP object",
-          "type": "string",
-          "maxLength": 60
-        },
-        "originalLanguage": {
-          "title": "Original Language",
-          "description": "Original language of the ABAP object",
-          "type": "string",
-          "minLength": 2
-        },
-        "abapLanguageVersion": {
-          "title": "ABAP Language Version",
-          "description": "ABAP language version",
-          "type": "string",
-          "enum": [
-            "standard",
-            "cloudDevelopment"
-          ],
-          "enumTitles": [
-            "Standard",
-            "ABAP Cloud Development"
-          ],
-          "enumDescriptions": [
-            "Standard",
-            "ABAP cloud development"
-          ],
-          "default": "standard"
-        }
-      },
-      "additionalProperties": false,
-      "required": [
-        "description",
-        "originalLanguage"
-      ]
-    }
-  },
-  "additionalProperties": false,
-  "required": [
-    "formatVersion",
-    "header"
-  ]
-}
diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap b/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
deleted file mode 100644
index 71d450443..000000000
--- a/file-formats/edcr/type/zif_aff_edcr_v1.intf.abap
+++ /dev/null
@@ -1,16 +0,0 @@
-INTERFACE zif_aff_edcr_v1
-  PUBLIC.
-
-  TYPES:
-    "! <p class="shorttext">Representation Type</p>
-    "! Representation Type (EDCR) v1
-    BEGIN OF ty_main,
-      "! $required
-      format_version TYPE zif_aff_types_v1=>ty_format_version,
-      "! <p class="shorttext">Header</p>
-      "! Header
-      "! $required
-      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
-    END OF ty_main.
-
-ENDINTERFACE.
diff --git a/file-formats/edcr/type/zif_aff_edcr_v1.intf.json b/file-formats/edcr/type/zif_aff_edcr_v1.intf.json
deleted file mode 100644
index 62a97b841..000000000
--- a/file-formats/edcr/type/zif_aff_edcr_v1.intf.json
+++ /dev/null
@@ -1,7 +0,0 @@
-{
-  "formatVersion": "1",
-  "header": {
-    "description": "AFF type for EDCR",
-    "originalLanguage": "en"
-  }
-}

From e1585fea574d6d21dea1c93691b0bd163ddf398a Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Sun, 11 Aug 2024 21:55:18 +0530
Subject: [PATCH 08/26] Fix providied for comments as recieved

---
 file-formats/edck/edck-v1.json                | 44 +++++++++----------
 .../edck/type/zif_aff_edck_v1.intf.abap       | 44 +++++++++----------
 2 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
index 929cb3236..535181193 100644
--- a/file-formats/edck/edck-v1.json
+++ b/file-formats/edck/edck-v1.json
@@ -3,7 +3,7 @@
   "$schema": "https://json-schema.org/draft/2020-12/schema",
   "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edck/edck-v1.json",
   "title": "Consistency Check ID",
-  "description": "Check ID (EDCK) v1",
+  "description": "Consistency check ID (EDCK) v1",
   "type": "object",
   "properties": {
     "formatVersion": {
@@ -55,36 +55,36 @@
       ]
     },
     "attributes": {
-      "title": "Check ID Definition",
-      "description": "Attributes of a Consistency Check",
+      "title": "Consistency Check ID Definition",
+      "description": "Attributes of a consistency check ID",
       "type": "object",
       "properties": {
-        "checkcategory": {
+        "checkCategory": {
           "title": "Check Category",
-          "description": "Consistency Check Category",
+          "description": "Consistency check category",
           "type": "string",
           "enum": [
-            "exist",
-            "status",
-            "edochk",
-            "conmis"
+            "existenceCheck",
+            "statusCheck",
+            "edocumentExistenceCheck",
+            "contentMismatchCheck"
           ],
           "enumTitles": [
             "Existence Check",
             "Status Check",
             "Edocument Existence Check",
-            "Content Mismatch"
+            "Content Mismatch Check"
           ],
           "enumDescriptions": [
-            "Existence Check",
-            "Status Check",
-            "Edocument Existence Check",
-            "Content Mismatch"
+            "Existence check",
+            "Status check",
+            "Edocument existence check",
+            "Content mismatch check"
           ]
         },
-        "checkidclassification": {
+        "checkIdClassification": {
           "title": "Check Classification",
-          "description": "Consistency Check ID Classification",
+          "description": "Consistency check ID classification",
           "type": "string",
           "enum": [
             "core",
@@ -99,22 +99,22 @@
             "Additionally (Extended) implemented checks"
           ]
         },
-        "checkclass": {
+        "checkClass": {
           "title": "Additional Check Class",
-          "description": "Consistency Check Class",
+          "description": "Consistency check class",
           "type": "string",
           "maxLength": 30
         },
-        "resultderivationindicator": {
+        "resultDerivationIndicator": {
           "title": "Result Derivation Indicator",
-          "description": "Result Process Derived by BAdI",
+          "description": "Result process derived by BAdI",
           "type": "boolean"
         }
       },
       "additionalProperties": false,
       "required": [
-        "checkcategory",
-        "checkidclassification"
+        "checkCategory",
+        "checkIdClassification"
       ]
     }
   },
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index ad9c3da69..26a6e7c8a 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -7,28 +7,28 @@ INTERFACE zif_aff_edck_v1
   TYPES:
     BEGIN OF ty_attributes,
       "! <p class="shorttext">Check Category</p>
-      "! Consistency Check Category
+      "! Consistency check category
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
       "! $required
-      checkcategory             TYPE ty_check_category,
+      check_category             TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
-      "! Consistency Check ID Classification
+      "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
       "! $required
-      checkidclassification     TYPE ty_check_classification,
+      check_id_classification     TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
-      "! Consistency Check Class
-      checkclass                TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! Consistency check class
+      check_class                TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Result Derivation Indicator</p>
-      "! Result Process Derived by BAdI
-      resultderivationindicator TYPE abap_bool,
+      "! Result process derived by BAdI
+      result_derivation_indicator TYPE abap_bool,
     END OF ty_attributes.
 
   TYPES:
     "! <p class="shorttext">Consistency Check ID</p>
-    "! Check ID (EDCK) v1
+    "! Consistency check ID (EDCK) v1
     BEGIN OF ty_main,
       "! $required
       format_version TYPE zif_aff_types_v1=>ty_format_version,
@@ -36,15 +36,15 @@ INTERFACE zif_aff_edck_v1
       "! Header
       "! $required
       header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
-      "! <p class="shorttext">Check ID Definition</p>
-      "! Attributes of a Consistency Check
+      "! <p class="shorttext">Consistency Check ID Definition</p>
+      "! Attributes of a consistency check ID
       "! $required
       attributes     TYPE ty_attributes,
     END OF ty_main.
 
   CONSTANTS:
     "! <p class="shorttext">Check Classification</p>
-    "! Check Classification
+    "! Check classification
     BEGIN OF co_check_classification,
       "! <p class="shorttext">Core delivered checks</p>
       "! Core delivered checks
@@ -56,19 +56,19 @@ INTERFACE zif_aff_edck_v1
 
   CONSTANTS:
     "! <p class="shorttext">Check Category</p>
-    "! Check Category
+    "! Check category
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
-      "! Existence Check
-      exist  TYPE ty_check_category VALUE 'EXIST',
+      "! Existence check
+      existence_check  TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
-      "! Status Check
-      status TYPE ty_check_category VALUE 'STATUS',
+      "! Status check
+      status_check TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
-      "! Edocument Existence Check
-      edochk TYPE ty_check_category VALUE 'EDOCHK',
-      "! <p class="shorttext"> Content Mismatch</p>
-      "!  Content Mismatch
-      conmis TYPE ty_check_category VALUE 'CONMIS',
+      "! Edocument existence check
+      edocument_existence_check TYPE ty_check_category VALUE 'EDOCHK',
+      "! <p class="shorttext">Content Mismatch Check</p>
+      "!  Content mismatch check
+      content_mismatch_check TYPE ty_check_category VALUE 'CONMIS',
     END OF co_check_category.
 ENDINTERFACE.

From 44bebfbde2988a551e41d5d6c0c704df77ae3c94 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Sun, 11 Aug 2024 22:01:04 +0530
Subject: [PATCH 09/26] abap_lint type alignment fix

---
 .../edck/type/zif_aff_edck_v1.intf.abap       | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 26a6e7c8a..d1340a28d 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -11,19 +11,19 @@ INTERFACE zif_aff_edck_v1
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
       "! $required
-      check_category             TYPE ty_check_category,
+      check_category               TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
       "! $required
-      check_id_classification     TYPE ty_check_classification,
+      check_id_classification      TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
-      check_class                TYPE zif_aff_types_v1=>ty_object_name_30,
+      check_class                  TYPE if_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Result Derivation Indicator</p>
       "! Result process derived by BAdI
-      result_derivation_indicator TYPE abap_bool,
+      result_derivation_indicator  TYPE abap_bool,
     END OF ty_attributes.
 
   TYPES:
@@ -31,11 +31,11 @@ INTERFACE zif_aff_edck_v1
     "! Consistency check ID (EDCK) v1
     BEGIN OF ty_main,
       "! $required
-      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      format_version TYPE if_aff_types_v1=>ty_format_version,
       "! <p class="shorttext">Header</p>
       "! Header
       "! $required
-      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      header         TYPE if_aff_types_v1=>ty_header_60_cloud,
       "! <p class="shorttext">Consistency Check ID Definition</p>
       "! Attributes of a consistency check ID
       "! $required
@@ -60,15 +60,15 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence check
-      existence_check  TYPE ty_check_category VALUE 'EXIST',
+      existence_check            TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status check
-      status_check TYPE ty_check_category VALUE 'STATUS',
+      status_check               TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
       "! Edocument existence check
-      edocument_existence_check TYPE ty_check_category VALUE 'EDOCHK',
+      edocument_existence_check  TYPE ty_check_category VALUE 'EDOCHK',
       "! <p class="shorttext">Content Mismatch Check</p>
       "!  Content mismatch check
-      content_mismatch_check TYPE ty_check_category VALUE 'CONMIS',
+      content_mismatch_check     TYPE ty_check_category VALUE 'CONMIS',
     END OF co_check_category.
-ENDINTERFACE.
+ENDINTERFACE.
\ No newline at end of file

From aeb32d98310bb8f6c89669e47a5c9486322bdba9 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Sun, 11 Aug 2024 22:09:36 +0530
Subject: [PATCH 10/26] abaplint fixes

---
 .../edck/type/zif_aff_edck_v1.intf.abap        | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index d1340a28d..ac142b88d 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -11,19 +11,19 @@ INTERFACE zif_aff_edck_v1
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
       "! $required
-      check_category               TYPE ty_check_category,
+      check_category             TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
       "! $required
-      check_id_classification      TYPE ty_check_classification,
+      check_id_classification     TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
-      check_class                  TYPE if_aff_types_v1=>ty_object_name_30,
+      check_class                 TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Result Derivation Indicator</p>
       "! Result process derived by BAdI
-      result_derivation_indicator  TYPE abap_bool,
+      result_derivation_indicator TYPE abap_bool,
     END OF ty_attributes.
 
   TYPES:
@@ -31,11 +31,11 @@ INTERFACE zif_aff_edck_v1
     "! Consistency check ID (EDCK) v1
     BEGIN OF ty_main,
       "! $required
-      format_version TYPE if_aff_types_v1=>ty_format_version,
+      format_version TYPE zif_aff_types_v1=>ty_format_version,
       "! <p class="shorttext">Header</p>
       "! Header
       "! $required
-      header         TYPE if_aff_types_v1=>ty_header_60_cloud,
+      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
       "! <p class="shorttext">Consistency Check ID Definition</p>
       "! Attributes of a consistency check ID
       "! $required
@@ -60,10 +60,10 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence check
-      existence_check            TYPE ty_check_category VALUE 'EXIST',
+      existence_check  		 TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status check
-      status_check               TYPE ty_check_category VALUE 'STATUS',
+      status_check     		 TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
       "! Edocument existence check
       edocument_existence_check  TYPE ty_check_category VALUE 'EDOCHK',
@@ -71,4 +71,4 @@ INTERFACE zif_aff_edck_v1
       "!  Content mismatch check
       content_mismatch_check     TYPE ty_check_category VALUE 'CONMIS',
     END OF co_check_category.
-ENDINTERFACE.
\ No newline at end of file
+ENDINTERFACE.

From 2c6bb2a5fb8046ec54b20fb8f005a95d5036c061 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Sun, 11 Aug 2024 22:12:01 +0530
Subject: [PATCH 11/26] abaplint tab fixes

---
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index ac142b88d..352cd7a63 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -11,19 +11,19 @@ INTERFACE zif_aff_edck_v1
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
       "! $required
-      check_category             TYPE ty_check_category,
+      check_category               TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
       "! $required
-      check_id_classification     TYPE ty_check_classification,
+      check_id_classification      TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
-      check_class                 TYPE zif_aff_types_v1=>ty_object_name_30,
+      check_class                  TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Result Derivation Indicator</p>
       "! Result process derived by BAdI
-      result_derivation_indicator TYPE abap_bool,
+      result_derivation_indicator  TYPE abap_bool,
     END OF ty_attributes.
 
   TYPES:
@@ -60,10 +60,10 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence check
-      existence_check  		 TYPE ty_check_category VALUE 'EXIST',
+      existence_check            TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status check
-      status_check     		 TYPE ty_check_category VALUE 'STATUS',
+      status_check               TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
       "! Edocument existence check
       edocument_existence_check  TYPE ty_check_category VALUE 'EDOCHK',

From da26d695d25155398a550d4455fbad6fa87bbfc7 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Mon, 12 Aug 2024 13:45:11 +0530
Subject: [PATCH 12/26] abaplint Type alignment fix

---
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 352cd7a63..02d0ee8dd 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -11,19 +11,19 @@ INTERFACE zif_aff_edck_v1
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
       "! $required
-      check_category               TYPE ty_check_category,
+      check_category              TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
       "! $required
-      check_id_classification      TYPE ty_check_classification,
+      check_id_classification     TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
-      check_class                  TYPE zif_aff_types_v1=>ty_object_name_30,
+      check_class                 TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Result Derivation Indicator</p>
       "! Result process derived by BAdI
-      result_derivation_indicator  TYPE abap_bool,
+      result_derivation_indicator TYPE abap_bool,
     END OF ty_attributes.
 
   TYPES:
@@ -60,15 +60,15 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence check
-      existence_check            TYPE ty_check_category VALUE 'EXIST',
+      existence_check           TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status check
-      status_check               TYPE ty_check_category VALUE 'STATUS',
+      status_check              TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
       "! Edocument existence check
-      edocument_existence_check  TYPE ty_check_category VALUE 'EDOCHK',
+      edocument_existence_check TYPE ty_check_category VALUE 'EDOCHK',
       "! <p class="shorttext">Content Mismatch Check</p>
       "!  Content mismatch check
-      content_mismatch_check     TYPE ty_check_category VALUE 'CONMIS',
+      content_mismatch_check    TYPE ty_check_category VALUE 'CONMIS',
     END OF co_check_category.
 ENDINTERFACE.

From 26f4cd6eacc45edb05017107a1ce81a5a70ad11c Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 10:41:54 +0530
Subject: [PATCH 13/26] Markus Review comments

---
 file-formats/edck/README.md                   |   2 +-
 file-formats/edck/edck-v1.json                |  19 ++++++++----------
 file-formats/edck/examples/.DS_Store          | Bin 0 -> 6148 bytes
 .../examples/z_aff_example_edck.edck.json     |  16 +++++++++++++++
 .../edck/type/zif_aff_edck_v1.intf.abap       |  10 ++++-----
 5 files changed, 29 insertions(+), 18 deletions(-)
 create mode 100644 file-formats/edck/examples/.DS_Store
 create mode 100644 file-formats/edck/examples/z_aff_example_edck.edck.json

diff --git a/file-formats/edck/README.md b/file-formats/edck/README.md
index a45c4a510..6f471a428 100644
--- a/file-formats/edck/README.md
+++ b/file-formats/edck/README.md
@@ -2,4 +2,4 @@
 
 File | Cardinality | Definition | Schema | Example
 :--- | :--- | :--- | :--- | :---
-`<name>.edck.json` | 1 | [`zif_aff_edck_v1.intf.abap`](./type/zif_aff_edck_v1.intf.abap) | [`edck-v1.json`](./edck-v1.json)
+`<name>.edck.json` | 1 | [`zif_aff_edck_v1.intf.abap`](./type/zif_aff_edck_v1.intf.abap) | [`edck-v1.json`](./edck-v1.json) | [`z_aff_example_edck.edck.json`](./examples/z_aff_example_edck.edck.json)
diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
index 535181193..c5384e1c3 100644
--- a/file-formats/edck/edck-v1.json
+++ b/file-formats/edck/edck-v1.json
@@ -3,7 +3,7 @@
   "$schema": "https://json-schema.org/draft/2020-12/schema",
   "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edck/edck-v1.json",
   "title": "Consistency Check ID",
-  "description": "Consistency check ID (EDCK) v1",
+  "description": "Consistency check ID",
   "type": "object",
   "properties": {
     "formatVersion": {
@@ -54,9 +54,9 @@
         "originalLanguage"
       ]
     },
-    "attributes": {
-      "title": "Consistency Check ID Definition",
-      "description": "Attributes of a consistency check ID",
+    "generalInformation": {
+      "title": "General Information",
+      "description": "General information of consistency check ID",
       "type": "object",
       "properties": {
         "checkCategory": {
@@ -97,7 +97,8 @@
           "enumDescriptions": [
             "Core delivered checks",
             "Additionally (Extended) implemented checks"
-          ]
+          ],
+          "default": "core"
         },
         "checkClass": {
           "title": "Additional Check Class",
@@ -111,17 +112,13 @@
           "type": "boolean"
         }
       },
-      "additionalProperties": false,
-      "required": [
-        "checkCategory",
-        "checkIdClassification"
-      ]
+      "additionalProperties": false
     }
   },
   "additionalProperties": false,
   "required": [
     "formatVersion",
     "header",
-    "attributes"
+    "generalInformation"
   ]
 }
diff --git a/file-formats/edck/examples/.DS_Store b/file-formats/edck/examples/.DS_Store
new file mode 100644
index 0000000000000000000000000000000000000000..5008ddfcf53c02e82d7eee2e57c38e5672ef89f6
GIT binary patch
literal 6148
zcmeH~Jr2S!425mzP>H1@V-^m;4Wg<&0T*E43hX&L&p$$qDprKhvt+--jT7}7np#A3
zem<@ulZcFPQ@L2!n>{z**<q8>++&mCkOWA81W14cNZ<zv;LbK1Poaz?KmsK2CSc!(
z0ynLxE!0092;Krf2c+FF_Fe*7ECH>lEfg7;MkzE(HCqgga^y>{tEnwC%0;vJ&^%eQ
zLs35+`xjp>T0<F0fCPF1$Cyrb|F7^5{eNG?83~ZUUlGt@xh*qZDeu<Z%US-OSsOPv
j)R!Z4KLME7ReXlK;d!wEw5GODWMKRea10D2@KpjYNUI8I

literal 0
HcmV?d00001

diff --git a/file-formats/edck/examples/z_aff_example_edck.edck.json b/file-formats/edck/examples/z_aff_example_edck.edck.json
new file mode 100644
index 000000000..259fa781f
--- /dev/null
+++ b/file-formats/edck/examples/z_aff_example_edck.edck.json
@@ -0,0 +1,16 @@
+{
+
+  "formatVersion": "1",
+  "header": {
+    "description": "Example Check ID",
+    "originalLanguage": "en",
+    "abapLanguageVersion": "cloudDevelopment"
+  },
+
+  "generalInformation": {
+    "checkCategory": "existenceCheck",
+    "checkIdClassification": "core",
+    "resultDerivationIndicator": false
+  }
+  
+}
\ No newline at end of file
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 02d0ee8dd..1633630f2 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -10,13 +10,11 @@ INTERFACE zif_aff_edck_v1
       "! Consistency check category
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
-      "! $required
       check_category              TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
       "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
-      "! $required
       check_id_classification     TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
@@ -28,7 +26,7 @@ INTERFACE zif_aff_edck_v1
 
   TYPES:
     "! <p class="shorttext">Consistency Check ID</p>
-    "! Consistency check ID (EDCK) v1
+    "! Consistency check ID
     BEGIN OF ty_main,
       "! $required
       format_version TYPE zif_aff_types_v1=>ty_format_version,
@@ -36,10 +34,10 @@ INTERFACE zif_aff_edck_v1
       "! Header
       "! $required
       header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
-      "! <p class="shorttext">Consistency Check ID Definition</p>
-      "! Attributes of a consistency check ID
+      "! <p class="shorttext">General Information</p>
+      "! General information of consistency check ID
       "! $required
-      attributes     TYPE ty_attributes,
+      general_information     TYPE ty_attributes,
     END OF ty_main.
 
   CONSTANTS:

From b6d94e82532a5a13059a3ca5be54fbbb775815ff Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 10:47:26 +0530
Subject: [PATCH 14/26] abap_lint fixes

---
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 1633630f2..5082d1ead 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -33,11 +33,11 @@ INTERFACE zif_aff_edck_v1
       "! <p class="shorttext">Header</p>
       "! Header
       "! $required
-      header         TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      header TYPE zif_aff_types_v1=>ty_header_60_cloud,
       "! <p class="shorttext">General Information</p>
       "! General information of consistency check ID
       "! $required
-      general_information     TYPE ty_attributes,
+      general_information TYPE ty_attributes,
     END OF ty_main.
 
   CONSTANTS:
@@ -46,7 +46,7 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_classification,
       "! <p class="shorttext">Core delivered checks</p>
       "! Core delivered checks
-      core       TYPE ty_check_classification VALUE 'C',
+      core TYPE ty_check_classification VALUE 'C',
       "! <p class="shorttext">Additionally (Extended) implemented checks</p>
       "! Additionally (Extended) implemented checks
       additional TYPE ty_check_classification VALUE 'A',
@@ -58,15 +58,15 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence check
-      existence_check           TYPE ty_check_category VALUE 'EXIST',
+      existence_check TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status check
-      status_check              TYPE ty_check_category VALUE 'STATUS',
+      status_check TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
       "! Edocument existence check
       edocument_existence_check TYPE ty_check_category VALUE 'EDOCHK',
       "! <p class="shorttext">Content Mismatch Check</p>
       "!  Content mismatch check
-      content_mismatch_check    TYPE ty_check_category VALUE 'CONMIS',
+      content_mismatch_check TYPE ty_check_category VALUE 'CONMIS',
     END OF co_check_category.
 ENDINTERFACE.

From e20783053484ee3c67d639dccadc8c0e7f4dd0a8 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 10:51:46 +0530
Subject: [PATCH 15/26] abap_lint fix

---
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 5082d1ead..8384850ee 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -29,11 +29,11 @@ INTERFACE zif_aff_edck_v1
     "! Consistency check ID
     BEGIN OF ty_main,
       "! $required
-      format_version TYPE zif_aff_types_v1=>ty_format_version,
+      format_version      TYPE zif_aff_types_v1=>ty_format_version,
       "! <p class="shorttext">Header</p>
       "! Header
       "! $required
-      header TYPE zif_aff_types_v1=>ty_header_60_cloud,
+      header              TYPE zif_aff_types_v1=>ty_header_60_cloud,
       "! <p class="shorttext">General Information</p>
       "! General information of consistency check ID
       "! $required

From 89bf13bcf18372d1213cf270560a8752f34de9ff Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 10:56:03 +0530
Subject: [PATCH 16/26] EOL fixes

---
 file-formats/edck/examples/z_aff_example_edck.edck.json | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/file-formats/edck/examples/z_aff_example_edck.edck.json b/file-formats/edck/examples/z_aff_example_edck.edck.json
index 259fa781f..74b1144ad 100644
--- a/file-formats/edck/examples/z_aff_example_edck.edck.json
+++ b/file-formats/edck/examples/z_aff_example_edck.edck.json
@@ -1,16 +1,13 @@
 {
-
   "formatVersion": "1",
   "header": {
     "description": "Example Check ID",
     "originalLanguage": "en",
     "abapLanguageVersion": "cloudDevelopment"
   },
-
   "generalInformation": {
     "checkCategory": "existenceCheck",
     "checkIdClassification": "core",
     "resultDerivationIndicator": false
   }
-  
 }
\ No newline at end of file

From 429c803b44a5c3618923ca19c4f9f0a0038f2d38 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 11:03:16 +0530
Subject: [PATCH 17/26] compare generated schema fix


From b5c941dfb7429c3ee6d8d050a612a8a6ba359f75 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 11:14:26 +0530
Subject: [PATCH 18/26] EOL fix

---
 file-formats/edck/examples/z_aff_example_edck.edck.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/file-formats/edck/examples/z_aff_example_edck.edck.json b/file-formats/edck/examples/z_aff_example_edck.edck.json
index 74b1144ad..4ae4c315d 100644
--- a/file-formats/edck/examples/z_aff_example_edck.edck.json
+++ b/file-formats/edck/examples/z_aff_example_edck.edck.json
@@ -4,10 +4,10 @@
     "description": "Example Check ID",
     "originalLanguage": "en",
     "abapLanguageVersion": "cloudDevelopment"
-  },
+  }, 
   "generalInformation": {
     "checkCategory": "existenceCheck",
     "checkIdClassification": "core",
     "resultDerivationIndicator": false
-  }
+  } 
 }
\ No newline at end of file

From 0ae7a95e9c5e429a8a59c0c778398abb3c72cff9 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 11:18:27 +0530
Subject: [PATCH 19/26] EOL fix

---
 .../edck/examples/z_aff_example_edck.edck.json   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/file-formats/edck/examples/z_aff_example_edck.edck.json b/file-formats/edck/examples/z_aff_example_edck.edck.json
index 4ae4c315d..8c3afbd4a 100644
--- a/file-formats/edck/examples/z_aff_example_edck.edck.json
+++ b/file-formats/edck/examples/z_aff_example_edck.edck.json
@@ -1,13 +1,13 @@
 {
   "formatVersion": "1",
   "header": {
-    "description": "Example Check ID",
-    "originalLanguage": "en",
-    "abapLanguageVersion": "cloudDevelopment"
-  }, 
+      "description": "Example Check ID",
+      "originalLanguage": "en",
+      "abapLanguageVersion": "cloudDevelopment"
+  },
   "generalInformation": {
-    "checkCategory": "existenceCheck",
-    "checkIdClassification": "core",
-    "resultDerivationIndicator": false
-  } 
+      "checkCategory": "existenceCheck",
+      "checkIdClassification": "core",
+      "resultDerivationIndicator": false
+  }
 }
\ No newline at end of file

From 21472e2541b1e10afce16e3068b00e9934693ce2 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 11:21:33 +0530
Subject: [PATCH 20/26] EOL fix

---
 file-formats/edck/examples/z_aff_example_edck.edck.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/file-formats/edck/examples/z_aff_example_edck.edck.json b/file-formats/edck/examples/z_aff_example_edck.edck.json
index 8c3afbd4a..f62ca6371 100644
--- a/file-formats/edck/examples/z_aff_example_edck.edck.json
+++ b/file-formats/edck/examples/z_aff_example_edck.edck.json
@@ -10,4 +10,4 @@
       "checkIdClassification": "core",
       "resultDerivationIndicator": false
   }
-}
\ No newline at end of file
+}

From fd155499ce0cc1aa56725a20d32fca884bab502e Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 11:24:45 +0530
Subject: [PATCH 21/26] Generated JSON Schema error


From 782d3b123471a63d7dd84a68d050a20f8861fcd1 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Thu, 5 Sep 2024 11:47:12 +0530
Subject: [PATCH 22/26] generated schema issue


From 0a38384bc8665cf02c88d7e7834c68a5ea98b9e9 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Fri, 6 Sep 2024 10:11:01 +0530
Subject: [PATCH 23/26] Markus review comments

---
 file-formats/edck/edck-v1.json                   |   4 ++--
 file-formats/edck/examples/.DS_Store             | Bin 6148 -> 0 bytes
 file-formats/edck/type/zif_aff_edck_v1.intf.abap |   8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)
 delete mode 100644 file-formats/edck/examples/.DS_Store

diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
index c5384e1c3..a9c899058 100644
--- a/file-formats/edck/edck-v1.json
+++ b/file-formats/edck/edck-v1.json
@@ -91,8 +91,8 @@
             "additional"
           ],
           "enumTitles": [
-            "Core delivered checks",
-            "Additionally (Extended) implemented checks"
+            "Core Delivered Checks",
+            "Additionally (Extended) Implemented Checks"
           ],
           "enumDescriptions": [
             "Core delivered checks",
diff --git a/file-formats/edck/examples/.DS_Store b/file-formats/edck/examples/.DS_Store
deleted file mode 100644
index 5008ddfcf53c02e82d7eee2e57c38e5672ef89f6..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 6148
zcmeH~Jr2S!425mzP>H1@V-^m;4Wg<&0T*E43hX&L&p$$qDprKhvt+--jT7}7np#A3
zem<@ulZcFPQ@L2!n>{z**<q8>++&mCkOWA81W14cNZ<zv;LbK1Poaz?KmsK2CSc!(
z0ynLxE!0092;Krf2c+FF_Fe*7ECH>lEfg7;MkzE(HCqgga^y>{tEnwC%0;vJ&^%eQ
zLs35+`xjp>T0<F0fCPF1$Cyrb|F7^5{eNG?83~ZUUlGt@xh*qZDeu<Z%US-OSsOPv
j)R!Z4KLME7ReXlK;d!wEw5GODWMKRea10D2@KpjYNUI8I

diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 8384850ee..959d5b6dc 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -9,12 +9,12 @@ INTERFACE zif_aff_edck_v1
       "! <p class="shorttext">Check Category</p>
       "! Consistency check category
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
-      "! $default {@link if_aff_edck_v1.data:co_check_category.exist}
+      "! $default {@link zif_aff_edck_v1.data:co_check_category.exist}
       check_category              TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
-      "! $default {@link if_aff_edck_v1.data:co_check_classification.core}
+      "! $default {@link zif_aff_edck_v1.data:co_check_classification.core}
       check_id_classification     TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
@@ -44,10 +44,10 @@ INTERFACE zif_aff_edck_v1
     "! <p class="shorttext">Check Classification</p>
     "! Check classification
     BEGIN OF co_check_classification,
-      "! <p class="shorttext">Core delivered checks</p>
+      "! <p class="shorttext">Core Delivered Checks</p>
       "! Core delivered checks
       core TYPE ty_check_classification VALUE 'C',
-      "! <p class="shorttext">Additionally (Extended) implemented checks</p>
+      "! <p class="shorttext">Additionally (Extended) Implemented Checks</p>
       "! Additionally (Extended) implemented checks
       additional TYPE ty_check_classification VALUE 'A',
     END OF co_check_classification.

From a5ed858ec3a7279010584ca734e9be78efee2616 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Tue, 10 Sep 2024 08:58:48 +0530
Subject: [PATCH 24/26] Constant name change

---
 file-formats/edck/edck-v1.json                   | 3 ++-
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
index a9c899058..712f856df 100644
--- a/file-formats/edck/edck-v1.json
+++ b/file-formats/edck/edck-v1.json
@@ -80,7 +80,8 @@
             "Status check",
             "Edocument existence check",
             "Content mismatch check"
-          ]
+          ],
+          "default": "existenceCheck"
         },
         "checkIdClassification": {
           "title": "Check Classification",
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index 959d5b6dc..e4e6a799a 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -9,7 +9,7 @@ INTERFACE zif_aff_edck_v1
       "! <p class="shorttext">Check Category</p>
       "! Consistency check category
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
-      "! $default {@link zif_aff_edck_v1.data:co_check_category.exist}
+      "! $default {@link zif_aff_edck_v1.data:co_check_category.existence_check}
       check_category              TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification

From 9b78aadc6d7b4ec253cc6a1d12cd4ab3937b4f42 Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Fri, 27 Sep 2024 11:55:05 +0530
Subject: [PATCH 25/26] Katharina's comment

---
 file-formats/edck/edck-v1.json                | 16 ++++++-------
 .../examples/z_aff_example_edck.edck.json     | 12 +++++-----
 .../edck/type/zif_aff_edck_v1.intf.abap       | 24 +++++++++----------
 3 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
index 712f856df..1869ca1bf 100644
--- a/file-formats/edck/edck-v1.json
+++ b/file-formats/edck/edck-v1.json
@@ -83,13 +83,13 @@
           ],
           "default": "existenceCheck"
         },
-        "checkIdClassification": {
+        "checkClassification": {
           "title": "Check Classification",
           "description": "Consistency check ID classification",
           "type": "string",
           "enum": [
-            "core",
-            "additional"
+            "coreDeliveredChecks",
+            "additionalImplementedChecks"
           ],
           "enumTitles": [
             "Core Delivered Checks",
@@ -99,17 +99,17 @@
             "Core delivered checks",
             "Additionally (Extended) implemented checks"
           ],
-          "default": "core"
+          "default": "coreDeliveredChecks"
         },
-        "checkClass": {
+        "additionalCheckClass": {
           "title": "Additional Check Class",
           "description": "Consistency check class",
           "type": "string",
           "maxLength": 30
         },
-        "resultDerivationIndicator": {
-          "title": "Result Derivation Indicator",
-          "description": "Result process derived by BAdI",
+        "resultProcessDerived": {
+          "title": "Is Result Process Derived",
+          "description": "Result process derived",
           "type": "boolean"
         }
       },
diff --git a/file-formats/edck/examples/z_aff_example_edck.edck.json b/file-formats/edck/examples/z_aff_example_edck.edck.json
index f62ca6371..c34df0fa9 100644
--- a/file-formats/edck/examples/z_aff_example_edck.edck.json
+++ b/file-formats/edck/examples/z_aff_example_edck.edck.json
@@ -1,13 +1,13 @@
 {
   "formatVersion": "1",
   "header": {
-      "description": "Example Check ID",
-      "originalLanguage": "en",
-      "abapLanguageVersion": "cloudDevelopment"
+    "description": "Example Check ID",
+    "originalLanguage": "en",
+    "abapLanguageVersion": "cloudDevelopment"
   },
   "generalInformation": {
-      "checkCategory": "existenceCheck",
-      "checkIdClassification": "core",
-      "resultDerivationIndicator": false
+    "checkCategory": "existenceCheck",
+    "checkClassification": "coreDeliveredChecks",
+    "resultProcessDerived": false
   }
 }
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index e4e6a799a..e0c4c998e 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -10,18 +10,18 @@ INTERFACE zif_aff_edck_v1
       "! Consistency check category
       "! $values {@link zif_aff_edck_v1.data:co_check_category}
       "! $default {@link zif_aff_edck_v1.data:co_check_category.existence_check}
-      check_category              TYPE ty_check_category,
+      check_category         TYPE ty_check_category,
       "! <p class="shorttext">Check Classification</p>
       "! Consistency check ID classification
       "! $values {@link zif_aff_edck_v1.data:co_check_classification}
-      "! $default {@link zif_aff_edck_v1.data:co_check_classification.core}
-      check_id_classification     TYPE ty_check_classification,
+      "! $default {@link zif_aff_edck_v1.data:co_check_classification.core_delivered_checks}
+      check_classification   TYPE ty_check_classification,
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
-      check_class                 TYPE zif_aff_types_v1=>ty_object_name_30,
-      "! <p class="shorttext">Result Derivation Indicator</p>
-      "! Result process derived by BAdI
-      result_derivation_indicator TYPE abap_bool,
+      additional_check_class TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Is Result Process Derived</p>
+      "! Result process derived
+      result_process_derived TYPE abap_bool,
     END OF ty_attributes.
 
   TYPES:
@@ -46,10 +46,10 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_classification,
       "! <p class="shorttext">Core Delivered Checks</p>
       "! Core delivered checks
-      core TYPE ty_check_classification VALUE 'C',
+      core_delivered_checks         TYPE ty_check_classification VALUE 'C',
       "! <p class="shorttext">Additionally (Extended) Implemented Checks</p>
       "! Additionally (Extended) implemented checks
-      additional TYPE ty_check_classification VALUE 'A',
+      additional_implemented_checks TYPE ty_check_classification VALUE 'A',
     END OF co_check_classification.
 
   CONSTANTS:
@@ -58,15 +58,15 @@ INTERFACE zif_aff_edck_v1
     BEGIN OF co_check_category,
       "! <p class="shorttext">Existence Check</p>
       "! Existence check
-      existence_check TYPE ty_check_category VALUE 'EXIST',
+      existence_check           TYPE ty_check_category VALUE 'EXIST',
       "! <p class="shorttext">Status Check</p>
       "! Status check
-      status_check TYPE ty_check_category VALUE 'STATUS',
+      status_check              TYPE ty_check_category VALUE 'STATUS',
       "! <p class="shorttext">Edocument Existence Check</p>
       "! Edocument existence check
       edocument_existence_check TYPE ty_check_category VALUE 'EDOCHK',
       "! <p class="shorttext">Content Mismatch Check</p>
       "!  Content mismatch check
-      content_mismatch_check TYPE ty_check_category VALUE 'CONMIS',
+      content_mismatch_check    TYPE ty_check_category VALUE 'CONMIS',
     END OF co_check_category.
 ENDINTERFACE.

From f04e13cc218db21f5c711f0ce3d3bb5cc84acd3e Mon Sep 17 00:00:00 2001
From: KUMARMUKULSAP <mukul.kumar01@sap.com>
Date: Fri, 27 Sep 2024 14:46:45 +0530
Subject: [PATCH 26/26] Fixes of Result Derived field

---
 file-formats/edck/edck-v1.json                   | 2 +-
 file-formats/edck/type/zif_aff_edck_v1.intf.abap | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/file-formats/edck/edck-v1.json b/file-formats/edck/edck-v1.json
index 1869ca1bf..2c6b198f3 100644
--- a/file-formats/edck/edck-v1.json
+++ b/file-formats/edck/edck-v1.json
@@ -108,7 +108,7 @@
           "maxLength": 30
         },
         "resultProcessDerived": {
-          "title": "Is Result Process Derived",
+          "title": "Result Process Derived",
           "description": "Result process derived",
           "type": "boolean"
         }
diff --git a/file-formats/edck/type/zif_aff_edck_v1.intf.abap b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
index e0c4c998e..f5ecbdb44 100644
--- a/file-formats/edck/type/zif_aff_edck_v1.intf.abap
+++ b/file-formats/edck/type/zif_aff_edck_v1.intf.abap
@@ -19,7 +19,7 @@ INTERFACE zif_aff_edck_v1
       "! <p class="shorttext">Additional Check Class</p>
       "! Consistency check class
       additional_check_class TYPE zif_aff_types_v1=>ty_object_name_30,
-      "! <p class="shorttext">Is Result Process Derived</p>
+      "! <p class="shorttext">Result Process Derived</p>
       "! Result process derived
       result_process_derived TYPE abap_bool,
     END OF ty_attributes.