Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent library name sap_xssec versus sap-xssec #66

Open
finkmanAtSap opened this issue Dec 12, 2023 · 1 comment
Open

Inconsistent library name sap_xssec versus sap-xssec #66

finkmanAtSap opened this issue Dec 12, 2023 · 1 comment

Comments

@finkmanAtSap
Copy link

The library is called sap-xssec in the Python Package Index but is defined as sap_xssec here: https://github.com/SAP/cloud-pysec/blob/main/setup.py#L17

The description in the README (that is shown on Python Package Index, too) refers to it as sap_xssec.

I am not familiar with the Python eco system. Maybe this is as expected. Otherwise, would it be easy to unify this without causing trouble for consumers?
@robertofalk
Copy link
Member

I think it would be safe to use hyphen everywhere. @allen-sap any thoughts?

robertofalk added a commit that referenced this issue Sep 10, 2024
@robertofalk
Update README.md, closes #66
2fb050b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertofalk @finkmanAtSap