Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install process dummy robots #37

Open
JS2103 opened this issue Mar 11, 2022 · 4 comments
Open

Install process dummy robots #37

JS2103 opened this issue Mar 11, 2022 · 4 comments

Comments

@JS2103
Copy link

JS2103 commented Mar 11, 2022

Hey,
I'm currently working on my Cloud Robotics-Cluster and have problems to install the dummy robots since the RobotType is removed from the Registry API. (googlecloudrobotics/core@fc578d6)
Is there an easy way to fix the problem by myself, e.g. change the helm template?

Best regards and thanks,
Jan
copybara-service bot pushed a commit to googlecloudrobotics/core that referenced this issue Mar 14, 2022
@drigz @copybara-github
Revert "Remove RobotType from Registry API"
89163a2 
This reverts commit 069b80187c808b35b370afb450b9374b0765c95b.

Reason for revert: SAP/ewm-cloud-robotics#37

Change-Id: I2e29df5d43be8423bf28d7abb17583312456f683
GitOrigin-RevId: d27f4070dc4ee7ebda7bae5a649133e5f8616d2c
@drigz
Copy link

drigz commented Mar 14, 2022

Hi Jan, sorry for the breakage here! I wasn't aware that the RobotType was being used as it's spec still said something like "TODO: add useful features". I've reverted that change, perhaps it's enough for you to redeploy Cloud Robotics.

Are you following the https://googlecloudrobotics.github.io/core/how-to/deploy-from-sources flow or are you using binary releases?

@JS2103
Copy link
Author

JS2103 commented Mar 14, 2022

Thank you for the fast reply and solution. I used the Quickstart instructions, which uses the binary releases. Please correct me if I'm wrong.
I will give it a try tomorrow.

@drigz
Copy link

drigz commented Mar 14, 2022

OK, good to know. If you encounter similar problems in future, you can try the deploy-from-sources approach to work around it (the ewm-cloud-robotics docs link to this) until it's properly fixed, as that lets you either deploy an older version or make changes before deploying.

@oliver-goetz
Copy link
Contributor

@JS2103 I will remove the references to RobotType soon. They are not used anyhow.

In the meantime you could remove the robot type from dummy robot's helm chart: here and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drigz @oliver-goetz @JS2103