Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sourcing-2][Accessibility: ACC-264.1] Radio button: State and association not provided #11274

Closed
JyotiKumari1507 opened this issue Jan 21, 2024 · 2 comments
Assignees
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support

Comments

@JyotiKumari1507
Copy link

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Component having issue: https://sap.github.io/fundamental-ngx/#/platform/table/basic
Table with Sort and Group:
The radio buttons within the dialog 'sort' are not associated to its group header 'Sort order/Sort by' and UI type as radio button not mention and also the status 'Selected/not selected' is also not conveyed.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All latest version

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Screen reader can check by implementing similar case. Just use table with sort and group on toolbar. click sort/group icon .to open there respective dialog popup. The radio buttons within the dialog 'sort' are not associated to its group header 'Sort order/Sort by' and UI type as radio button not mention and also the status 'Selected/not selected' is also not conveyed.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

@droshev droshev added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Jan 31, 2024
@droshev droshev changed the title [Accessibility: ACC-264.1] Radio button: State and association not provided [Sourcing-2][Accessibility: ACC-264.1] Radio button: State and association not provided Jan 31, 2024
@nikolay-kolarov
Copy link

Hi @droshev,

This is about this dialog:
image

The elements with role listbox need to be labelled in order to give the semantic what is selected.
You can reuse the solution in UI5: https://ui5.sap.com/#/entity/sap.m.Table/sample/sap.m.sample.TableViewSettingsDialog
The listbox are labelled with an invisible text:
image
The selected state is given by a custom text added on aria-labelledby on focus, as listitem does not support aria-selected: https://www.w3.org/TR/wai-aria-1.2/#listitem

Best Regards,
Nikolay

@mikerodonnell89
Copy link
Member

Fixed as part of #12525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support
Projects
None yet
Development

No branches or pull requests

4 participants