Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fix - Modified the parameter 'providedDependencynames' and i… #181

Closed
wants to merge 4 commits into from

Conversation

pyogesh2
Copy link
Contributor

Purpose

Cosmetic fix - Modified the parameter 'providedDependencynames' in mta resources, datasource files

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe: Cosmetic fix handled in parameter name

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

…ts references

in mta resources, datasource files
@pyogesh2
Copy link
Contributor Author

As the underlying mta REST API returns the result in providedDendencyNames ,Therefore for consistency, named the fields also like that while developing the resource. By changing the attribute name and json encoding attribute, the response will not be correctly decoded, therefore best is to let the code as is.

@pyogesh2 pyogesh2 closed this Aug 26, 2024
@pyogesh2 pyogesh2 deleted the cosmeticfix-mta branch August 26, 2024 08:17
@Gourab1998 Gourab1998 restored the cosmeticfix-mta branch August 27, 2024 04:17
@Gourab1998 Gourab1998 reopened this Aug 27, 2024
@Gourab1998 Gourab1998 closed this Aug 27, 2024
@Gourab1998 Gourab1998 deleted the cosmeticfix-mta branch August 27, 2024 05:24
@vipinvkmenon vipinvkmenon restored the cosmeticfix-mta branch August 27, 2024 13:42
@vipinvkmenon vipinvkmenon reopened this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants