Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to align .sh calls with new arg counts #19

Open
lthealy opened this issue Apr 18, 2023 · 1 comment
Open

need to align .sh calls with new arg counts #19

lthealy opened this issue Apr 18, 2023 · 1 comment

Comments

@lthealy
Copy link
Collaborator

lthealy commented Apr 18, 2023

When adding subtypes, I also dropped a never used argument. I will put in a PR that homogenizes and reference this issue. Docker version in #18 works with proposed PR (ran locally using run-v1.sh with updated til_align repo) but will likely have one more rebuild of the image due to an updated main branch

@lthealy
Copy link
Collaborator Author

lthealy commented Apr 18, 2023

Current:

        --entrypoint Rscript \
        "$tilalign_container" \
            --vanilla \
            /code/commandLineAlign.R \
            inceptionv4 \
            "/data/results-tils" \
            0.1 \
            "/data/results-tumor" \
            0.5 \
            "" \
            output.csv \
            "/data/results-tilalign" \
            true \
            "/data/sample_info.csv"

New:

 --entrypoint Rscript \
        "$tilalign_container" \
            --vanilla \
            /code/commandLineAlign.R \
            inceptionv4 \
            "/data/results-tils" \
            0.1 \
            "/data/results-tumor" \
            0.5 \
            "/data/sample_info.csv" \ <- this gets moved up from last, and the blank one gets deleted
            output.csv \
            "/data/results-tilalign" \
            true \
            true <- this needs to be the "contains subtypes" toggle argument (Catches any version of TRUE,true,t,T,"true")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant