Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of fakepymba so the file list is passed instead of offset #100

Open
emlynjdavies opened this issue Dec 22, 2020 · 2 comments
Open

Refactor of fakepymba so the file list is passed instead of offset #100

emlynjdavies opened this issue Dec 22, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@emlynjdavies
Copy link
Contributor

spin-off from #95

the Frame.init() in fakepymba is complicated, with a lot of logic, which should be simplified and put in functions outside of the init, which pass arguments to the init function

perhaps relevant also for #51
@emlynjdavies emlynjdavies added the enhancement New feature or request label Dec 22, 2020
@emlynjdavies emlynjdavies mentioned this issue Dec 22, 2020
Merged
@emlynjdavies
Copy link
Contributor Author

@nepstad has some ideas on this

@emlynjdavies
Copy link
Contributor Author

Look at #51 before spending lots of time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emlynjdavies