Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ReadCompressed() method in bitstream class #23

Closed
Kiddinglife opened this issue Nov 24, 2017 · 2 comments
Closed

Bug: ReadCompressed() method in bitstream class #23

Kiddinglife opened this issue Nov 24, 2017 · 2 comments
Assignees

Comments

@Kiddinglife
Copy link

Kiddinglife commented Nov 24, 2017

the bug is it does not tell little endian and big endian.
I will create a pull request for this bug

@Kiddinglife Kiddinglife changed the title Bitstream has bug ReadCompressed() method in bitstream class has a bug that it does not tell little endian and big endian Nov 24, 2017
@Kiddinglife Kiddinglife changed the title ReadCompressed() method in bitstream class has a bug that it does not tell little endian and big endian Bug: ReadCompressed() method in bitstream class Nov 24, 2017
@Luke1410 Luke1410 self-assigned this Nov 26, 2017
@Luke1410
Copy link
Member

Corresponding PR: #26

@Luke1410
Copy link
Member

Luke1410 commented Jan 7, 2018

As discussed in the linked PR, this is not a bug, since the two methods referred to are private BitStream()-helpers used by the public Read/WriteCompressed() methods. The private ones have the prerequisite of being given already "normalized" (i.e. native) endian data, which all the callers correctly ensure. Therefore, this is not a bug.

The corresponding PR however contains some nice ideas for improvements, which we'll review separately at one point.

Hence closing this issue, but leaving the PR open.

@Luke1410 Luke1410 closed this as completed Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants