Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving validation support for studies reusing older studies/have multiple PRJ codes #128

Open
jfy133 opened this issue Sep 30, 2023 · 0 comments

Comments

@jfy133
Copy link
Member

jfy133 commented Sep 30, 2023

I've noticed more studies cropping up which the AMDirT validation checking isn't picking up or can't deal with.

Aida developed some pre-release checks that I recently extended (typically involving binding the libraries/samples tables together) which has picked up lots of things we have to list as 'exceptions'.

These are things such as re-use of data from previous studies, further sequencing etc. that have different PRJ codes than the 'primary' ones originally published; or re-analysis of studies not in the Dir (e.g. pop-gen)

These are currently implemented as (extremely rough!) Rscripts, and are listed here

https://github.com/SPAAM-community/AncientMetagenomeDir/wiki/Release-Procedure

We should

  1. add these cross-tables checks to AMDirT
  2. change schema/validation checks to adapt to existing 'exceptions'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant