Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributions grow out of grid without accounting/warning #33

Open
miggland opened this issue Oct 22, 2013 · 3 comments
Open

Distributions grow out of grid without accounting/warning #33

miggland opened this issue Oct 22, 2013 · 3 comments
Assignees

Comments

@miggland
Copy link
Contributor

Gion just experienced issues because he didn't know that the grid is constant for central difference/HIRES method and defined in initial distribution. His PSD grew out of the grid and then caused problems in the mass balance. A warning should be issued for this, and the solver stopped; or the grid should be extended.

@bizzinho
Copy link
Member

There is a warning if the mass balance error is above 5%... I think an online test of whether particles have left the grid might be expensive.. so maybe we just adapt the warning for mass balance errors and make the threshold lower, say 1%?

@miggland
Copy link
Contributor Author

Check of mass balance!
If using an event function: simulation can be stopped prematurely if mass balance is off by too much

@miggland
Copy link
Contributor Author

This only applies to hires, because:

  • cd is cancelled when mass balance error is too large
  • mp extends the grid

In hr, the mass balance is OK what grows out of the grid seems to 'dissolve' in the sense that it is accounted for by the mass balance for the solution phase

@bizzinho bizzinho self-assigned this May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants