Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to embed video from other sites (YouTube, etc.) #279

Open
jpdelmundo opened this issue Sep 24, 2024 · 2 comments
Open

Allow to embed video from other sites (YouTube, etc.) #279

jpdelmundo opened this issue Sep 24, 2024 · 2 comments

Comments

@jpdelmundo
Copy link

jpdelmundo commented Sep 24, 2024

Is your feature request related to a problem? Please describe.
It would be helpful to allow adding videos in a node like how adding image works right now.

Describe the solution you'd like
Similar to adding an image to node using the URL, height, and width:

video?: {
    url: string
    width: number
    height: number
}

Describe alternatives you've considered
No alternative (except for adding a URL as a data in a node menu plugin)

Additional context
Add any other context or screenshots about the feature request here.

@SSShooter
Copy link
Owner

Maybe you can try dangerouslySetInnerHTML

@jpdelmundo
Copy link
Author

jpdelmundo commented Sep 30, 2024

Using dangerouslySetInnerHTML replaces the whole node. It removes the topic text (and tags, URL from the node menu).

Even if I still include the topic text in the new html, it can't be edited because editing is skipped in beginEdit if dangerouslySetInnerHTML has a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants