Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Existing images showing as broken on CodeAuditor and Netlify #4748

Open
tiagov8 opened this issue Jan 18, 2023 · 1 comment
Open

Comments

@tiagov8
Copy link
Member

tiagov8 commented Jan 18, 2023

Cc: @tombui99 @adamcogan

Hi @bradystroud ,

https://ssw.com.au/rules/control-choice-do-you-know-when-to-use-checkboxes/

The last 2 images in this rule were caught as broken by CodeAuditor (see report)

βœ… The images are showing up in the public view

βœ… They are also included in the folder: https://github.com/SSWConsulting/SSW.Rules.Content/tree/main/rules/control-choice-do-you-know-when-to-use-checkboxes

❌ But I noticed they are broken on Netlify view:
Screenshot 2023-01-18 at 1 09 36 PM

⚠️ I also noticed they are GIFs instead of PNG/JPG. I assume that shouldn't be a problem...

  1. Please investigate and let us know what caused the problem and how to avoid/fix
@tiagov8 tiagov8 changed the title πŸ› Existing images (gifs) showing as broken on CodeAuditor πŸ› Existing images showing as broken on CodeAuditor and Netlify Jan 18, 2023
@tiagov8
Copy link
Member Author

tiagov8 commented Jan 18, 2023

Another case where it happened (not GIF this time...)

All images showing OK on https://ssw.com.au/rules/controls-do-you-include-the-number-of-results-in-comboboxes/

CodeAuditor caught 1 of the images as broken:

Screenshot 2023-01-18 at 1 21 29 PM

Netlify shows 4 images broken and 1 working fine:

Screenshot 2023-01-18 at 1 20 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant