Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - find warnings & update to not use real templates #36

Open
Aryllen opened this issue Jan 17, 2020 · 1 comment
Open

Tests - find warnings & update to not use real templates #36

Aryllen opened this issue Jan 17, 2020 · 1 comment

Comments

@Aryllen
Copy link
Collaborator

Aryllen commented Jan 17, 2020

This is technically two issues, but I'm combining into one for now.

  1. Find where warnings come from about name being an uninitialized column. The validate_by_study tests produce this warning.

  2. Currently have the tests using real templates to check the test data on, which is tedious to maintain and not necessary to check the functionality itself. Instead, use fake annotations, templates, and test data to test validation of files/studies.

@Aryllen
Copy link
Collaborator Author

Aryllen commented Feb 21, 2020

An update to 1: validate_by_study() no longer has this issue since the validation is done by dccvalidator now. Instead, combine_all_metadata() warns about specimenID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant